antidot-framework / container

src/MarshalDelegatorsConfig.php

<?php

declare(strict_types=1);

namespace Antidot\Container;

use Psr\Container\ContainerInterface;
use function is_callable;

class MarshalDelegatorsConfig
{
    public function __invoke(ContainerConfig $dependencies): ContainerConfig
    {
        foreach ($dependencies->get('delegators') as $service => $delegatorNames) {
            $factory = $this->delegateFactories($dependencies, $service);
            if (!is_callable($factory)) {
                continue;
            }
            $dependencies->set(ContainerDelegatorFactory::class, static function () use ($delegatorNames, $factory) {
                return new ContainerDelegatorFactory($delegatorNames, $factory);

It seems like $factory can also be of type null; however, parameter $factory of Antidot\Container\ContainerDelegatorFactory::__construct() does only seem to accept callable, maybe add an additional type check?

            });
            $dependencies->set(
                $service,
                static function (ContainerInterface $container) use ($service) {
                    $callable = $container->get(ContainerDelegatorFactory::class);
                    return $callable($container, $service);
                }
            );
        }

        return $dependencies;
    }

    private function delegateFactories(
        ContainerConfig $dependencies,
        string $service
    ): ?callable {
        if (false === $dependencies->has($service)) {
            return null;
        }
        // Marshal from factory
        $serviceFactory = $dependencies->get($service);
        return static function (ContainerInterface $container) use ($service, $serviceFactory) {
            return is_callable($serviceFactory)
                ? $serviceFactory($container, $service)
                : (new $serviceFactory())($container, $service);
        };
    }
}