Accessible\AutoConstructTrait

Complexity

Total Complexity

11

Size/Duplication

Total Lines	67
Duplicated Lines	20.9 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

91.89%

Importance

Changes	12
Bugs	0	Features	3

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
C	initializeProperties()	14	51	10

<?php

namespace Accessible;

use \Accessible\MethodManager\MethodCallManager;
use \Accessible\Reader\AutoConstructReader;

trait AutoConstructTrait
{
    /**
     * Directly calls the initialization method.
     */
    public function __construct()
    {
        $this->initializeProperties(func_get_args());
    }

    /**
     * Initializes the object according to its class specification and given arguments.
     *
     * @param array $properties The values to give to the properties.
     */
    protected function initializeProperties($properties = null)
    {
        $this->getPropertiesInfo();

It seems like getPropertiesInfo() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        // Initialize the properties that were defined using the Initialize / InitializeObject annotations
        $initializeValueValidationEnabled = Configuration::isInitializeValuesValidationEnabled();

        $initialValues = AutoConstructReader::getPropertiesToInitialize($this);
        foreach ($initialValues as $propertyName => $value) {
            if ($initializeValueValidationEnabled) {
                $this->assertPropertyValue($propertyName, $value);

It seems like assertPropertyValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }

            $this->$propertyName = $value;

            if (empty($this->_collectionsItemNames['byProperty'][$propertyName])) {

The property _collectionsItemNames does not exist. Did you maybe forget to declare it?

This code seems to be duplicated across your project.

                $this->updatePropertyAssociation($propertyName, array("oldValue" => null, "newValue" => $value));

It seems like updatePropertyAssociation() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            } else {
                foreach ($value as $newValue) {
                    $this->updatePropertyAssociation($propertyName, array("oldValue" => null, "newValue" => $newValue));

It seems like updatePropertyAssociation() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                }
            }
        }

        // Initialize the propeties using given arguments
        $neededArguments = AutoConstructReader::getConstructArguments($this);

        if ($neededArguments !== null && $properties !== null) {
            $numberOfNeededArguments = count($neededArguments);

            MethodCallManager::assertArgsNumber($numberOfNeededArguments, $properties);

            for ($i = 0; $i < $numberOfNeededArguments; $i++) {
                $property = $neededArguments[$i];
                $argument = $properties[$i];

                $this->assertPropertyValue($property, $argument);

It seems like assertPropertyValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $this->$property = $argument;

                // Manage associations
                if (empty($this->_collectionsItemNames['byProperty'][$property])) {

This code seems to be duplicated across your project.

                    $this->updatePropertyAssociation($property, array("oldValue" => null, "newValue" => $argument));

It seems like updatePropertyAssociation() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                } else {
                    foreach ($argument as $value) {
                        $this->updatePropertyAssociation($property, array("oldValue" => null, "newValue" => $value));

It seems like updatePropertyAssociation() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                    }
                }
            }
        }
    }
}