Classy::get_pagination() - Code Metrics - Inspection of "Merge pull request #14 from anrw/develop" - anrw/classy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bc6754...ed64c2 )

unknown

created 2016-07-13 15:40 UTC

Classy::get_pagination() B

↳ Parent: Classy

Complexity

Conditions	7
Paths	48

Size

Total Lines	58
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	7
eloc	35
c	1
b	0
f	1
nc	48
nop	1
dl	0
loc	58
rs	7.6045

How to fix Long Method

<?php
/**
 * The core theme class.
 *
 * @since 	1.0.0
 * @package Classy
 * @author 	Andrew Tolochka <[email protected]>
 */

namespace Classy;

use Windwalker\Renderer\BladeRenderer;

/**
 * Class Classy.
 */
class Classy {

	/**
	 * Singleton instance of plugin
	 *
	 * @var Classy
	 * @since  0.1.0
	 */
	protected static $single_instance = null;

	/**
	 * Creates or returns an instance of this class.
	 *
	 * @since  0.1.0
	 * @return Classy A single instance of this class.
	 */
	public static function get_instance() {

		if ( null === self::$single_instance ) {

			self::$single_instance = new self();

		}

		return self::$single_instance;

	}

	/**
	 * Define the core functionality of the them.
	 *
	 * Set the theme name and the theme version that can be used throughout the theme.
	 *
	 * @since    1.0.0
	 */
	protected function __construct() {
		$this->define_constants();

		$this->init_appearance();

		$this->load_template_function();

		$this->init_config();

		add_filter( 'theme_page_templates', array( $this, 'filter_templates' ) );
	}

	/**
	 * Init Appearance class.
	 */
	private function init_appearance() {
		new Appearance();
	}

	/**
	 * Load template functions.
	 */
	private function load_template_function() {
		require_once( CLASSY_THEME_PATH . 'app/functions/template-functions.php' );
	}

	/**
	 * Defines plugin constants
	 *
	 * @since    1.0.0
	 * @access   private
	 */
	private function define_constants() {

		$theme = wp_get_theme();

		define( 'CLASSY_THEME', $theme->template );
		define( 'CLASSY_THEME_NAME', $theme->get( 'Name' ) );
		define( 'CLASSY_THEME_PATH', get_template_directory() . '/' );
		define( 'CLASSY_THEME_DIR', get_template_directory_uri() . '/' );
		define( 'CLASSY_THEME_VERSION', $theme->get( 'Version' ) );
		define( 'CLASSY_THEME_FRAMEWORK_PATH', CLASSY_THEME_PATH . 'app/' );
		define( 'CLASSY_THEME_FRAMEWORK_DIR', CLASSY_THEME_DIR . 'app/' );

	}

	/**
	 * Init Theme Configuration
	 */
	private function init_config() {
		Config::init();
	}

	/**
	 * Filters registered templates and adds custom theme templates.
	 *
	 * @param array $page_templates Available WordPress templates.
	 *
	 * @return array
	 */
	public function filter_templates( $page_templates = array() ) {

		$custom_templates = View::get_page_templates_list();

		return array_merge( $page_templates, $custom_templates );

	}

	/**
	 * Returns theme config variable.
	 *
	 * @param string $name Variable's name.
	 *
	 * @return mixed|bool Return false if variable not found.
	 */
	public static function get_config_var( $name ) {

		$vars = Config::get_vars();

		return ( isset( $vars[ $name ] ) ) ? $vars[ $name ] : false;

	}

	/**
	 * Returns theme textdomain
	 *
	 * @return string
	 */
	public static function textdomain() {

		$textdomain = Classy::get_config_var( 'textdomain' );

		return $textdomain ? $textdomain : CLASSY_THEME;

	}

	/**
	 * Performs view render.
	 * If there is $view attribute presented, it will render requested view.
	 * If it's not it will try to find necessary view based on $wp_query
	 *
	 * @param  string|null $view View path in blade format, ex: single, layout.default, single.partials.slider and etc.
	 * @param  array|null  $data Additional params.
	 * @return void
	 */
	public static function render( $view = null, $data = null ) {

		$views = CLASSY_THEME_PATH . View::$folder;
		$cache = WP_CONTENT_DIR . '/viewcache';
		$common_scope = Scope::get_common_scope();

		if ( null !== $view && is_string( $view ) ) {

			if ( $data && is_array( $data ) ) {

				$scope = array_merge( $common_scope, $data );

			} else {

				$scope = $common_scope;

			}
		} else {

			$view = View::get_view();


			$scope = Scope::get_scope();

		}

		$renderer = new BladeRenderer( $views, array( 'cache_path' => $cache ) );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

		echo $renderer->render( $view, $scope ); // XSS: xss ok.

	}

	/**
	 * Alias for Helper::get_archives_title()
	 * Returns page title for archive page.
	 * Example: Archives, Author: John Doe, Tag: Lorem Ipsum
	 *
	 * @return string
	 */
	public static function archives_title() {

		return Helper::get_archives_title();

	}

	/**
	 * Returns posts
	 *
	 * @param  mixed  $args   Array of query args.
	 * @param  string $return object/id/Post.
	 *
	 * @return array
	 */
	public static function get_posts( $args = false, $return = '\Classy\Models\Post' ) {

		$_return = array();

		$query = Query_Helper::find_query( $args );

		if ( isset( $query->posts ) ) {

			foreach ( $query->posts as $post ) {

				if ( 'id' === $return ) {

					$_return[] = $post->id;

				} elseif ( 'object' === $return ) {

					$_return[] = $post;

				} elseif ( class_exists( $return ) ) {

					$_return[] = new $return( $post );

				}
			}
		}

		return $_return;
	}


	/**
	 * Returns post.
	 *
	 * @param  mixed  $args 		Array of query args.
	 * @param  string $return_type 	Post/object/id.
	 *
	 * @return mixed
	 */
	public static function get_post( $args = false, $return_type = '\Classy\Models\Post' ) {

		$posts = self::get_posts( $args, $return_type );

		if ( $post = reset( $posts ) ) {
			return $post;
		}

	}

	/**
	 * @todo: Write description here.
	 *
	 * @param array $prefs Args for paginate_links.
	 *
	 * @return array mixed
	 */
	public static function get_pagination( $prefs = array() ) {

		global $wp_query;
function myFunction($a, $b) {
    // Do something
}
		global $paged;
function myFunction($a, $b) {
    // Do something
}
		global $wp_rewrite;
function myFunction($a, $b) {
    // Do something
}

		$args = array();
		$args['total'] = ceil( $wp_query->found_posts / $wp_query->query_vars['posts_per_page'] );

		if ( $wp_rewrite->using_permalinks() ) {

			$url = explode( '?', get_pagenum_link( 0 ) );

			if ( isset( $url[1] ) ) {
				parse_str( $url[1], $query );
				$args['add_args'] = $query;
			}

			$args['format'] = 'page/%#%';
			$args['base'] = trailingslashit( $url[0] ).'%_%';

		} else {
			$big = 999999999;
			$args['base'] = str_replace( $big, '%#%', esc_url( get_pagenum_link( $big ) ) );
		}

		$args['type'] = 'array';
		$args['current'] = max( 1, get_query_var( 'paged' ) );
		$args['mid_size'] = max( 9 - $args['current'], 3 );
		$args['prev_next'] = false;

		if ( is_int( $prefs ) ) {
			$args['mid_size'] = $prefs - 2;
		} else {
			$args = array_merge( $args, $prefs );
		}

		$data = array();
		$data['pages'] = Helper::paginate_links( $args );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$next = get_next_posts_page_link( $args['total'] );

		if ( $next ) {
			$data['next'] = array( 'link' => untrailingslashit( $next ), 'class' => 'page-numbers next' );
		}

		$prev = previous_posts( false );

		if ( $prev ) {
			$data['prev'] = array( 'link' => untrailingslashit( $prev ), 'class' => 'page-numbers prev' );
		}

		if ( $paged < 2 ) {
			$data['prev'] = null;
		}

		return Helper::array_to_object( $data );

	}
}


Push — master ( bc6754...ed64c2 )

Classy::get_pagination() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			/**
3			* The core theme class.
4			*
5			* @since 1.0.0
6			* @package Classy
7			* @author Andrew Tolochka <[email protected]>
8			*/
9
10			namespace Classy;
11
12			use Windwalker\Renderer\BladeRenderer;
13
14			/**
15			* Class Classy.
16			*/
17			class Classy {
18
19			/**
20			* Singleton instance of plugin
21			*
22			* @var Classy
23			* @since 0.1.0
24			*/
25			protected static $single_instance = null;
26
27			/**
28			* Creates or returns an instance of this class.
29			*
30			* @since 0.1.0
31			* @return Classy A single instance of this class.
32			*/
33			public static function get_instance() {
34
35			if ( null === self::$single_instance ) {
36
37			self::$single_instance = new self();
38
39			}
40
41			return self::$single_instance;
42
43			}
44
45			/**
46			* Define the core functionality of the them.
47			*
48			* Set the theme name and the theme version that can be used throughout the theme.
49			*
50			* @since 1.0.0
51			*/
52			protected function __construct() {
53			$this->define_constants();
54
55			$this->init_appearance();
56
57			$this->load_template_function();
58
59			$this->init_config();
60
61			add_filter( 'theme_page_templates', array( $this, 'filter_templates' ) );
62			}
63
64			/**
65			* Init Appearance class.
66			*/
67			private function init_appearance() {
68			new Appearance();
69			}
70
71			/**
72			* Load template functions.
73			*/
74			private function load_template_function() {
75			require_once( CLASSY_THEME_PATH . 'app/functions/template-functions.php' );
76			}
77
78			/**
79			* Defines plugin constants
80			*
81			* @since 1.0.0
82			* @access private
83			*/
84			private function define_constants() {
85
86			$theme = wp_get_theme();
87
88			define( 'CLASSY_THEME', $theme->template );
89			define( 'CLASSY_THEME_NAME', $theme->get( 'Name' ) );
90			define( 'CLASSY_THEME_PATH', get_template_directory() . '/' );
91			define( 'CLASSY_THEME_DIR', get_template_directory_uri() . '/' );
92			define( 'CLASSY_THEME_VERSION', $theme->get( 'Version' ) );
93			define( 'CLASSY_THEME_FRAMEWORK_PATH', CLASSY_THEME_PATH . 'app/' );
94			define( 'CLASSY_THEME_FRAMEWORK_DIR', CLASSY_THEME_DIR . 'app/' );
95
96			}
97
98			/**
99			* Init Theme Configuration
100			*/
101			private function init_config() {
102			Config::init();
103			}
104
105			/**
106			* Filters registered templates and adds custom theme templates.
107			*
108			* @param array $page_templates Available WordPress templates.
109			*
110			* @return array
111			*/
112			public function filter_templates( $page_templates = array() ) {
113
114			$custom_templates = View::get_page_templates_list();
115
116			return array_merge( $page_templates, $custom_templates );
117
118			}
119
120			/**
121			* Returns theme config variable.
122			*
123			* @param string $name Variable's name.
124			*
125			* @return mixed\|bool Return false if variable not found.
126			*/
127			public static function get_config_var( $name ) {
128
129			$vars = Config::get_vars();
130
131			return ( isset( $vars[ $name ] ) ) ? $vars[ $name ] : false;
132
133			}
134
135			/**
136			* Returns theme textdomain
137			*
138			* @return string
139			*/
140			public static function textdomain() {
141
142			$textdomain = Classy::get_config_var( 'textdomain' );
143
144			return $textdomain ? $textdomain : CLASSY_THEME;
145
146			}
147
148			/**
149			* Performs view render.
150			* If there is $view attribute presented, it will render requested view.
151			* If it's not it will try to find necessary view based on $wp_query
152			*
153			* @param string\|null $view View path in blade format, ex: single, layout.default, single.partials.slider and etc.
154			* @param array\|null $data Additional params.
155			* @return void
156			*/
157			public static function render( $view = null, $data = null ) {
158
159			$views = CLASSY_THEME_PATH . View::$folder;
160			$cache = WP_CONTENT_DIR . '/viewcache';
161			$common_scope = Scope::get_common_scope();
162
163			if ( null !== $view && is_string( $view ) ) {
164
165			if ( $data && is_array( $data ) ) {
166
167			$scope = array_merge( $common_scope, $data );
168
169			} else {
170
171			$scope = $common_scope;
172
173			}
174			} else {
175
176			$view = View::get_view();
			0 ignored issues – show Coding Style introduced 2016-07-13 12:07 UTC by Report Bug Copy Issue Report Consider using a different name than the parameter `$view`. This often makes code more readable. Loading history...
177
178			$scope = Scope::get_scope();
179
180			}
181
182			$renderer = new BladeRenderer( $views, array( 'cache_path' => $cache ) );
			0 ignored issues – show Documentation introduced 2016-05-13 06:15 UTC by Report Bug Copy Issue Report `$views` is of type `string`, but the function expects a `object<SplPriorityQueue>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
183
184			echo $renderer->render( $view, $scope ); // XSS: xss ok.
185
186			}
187
188			/**
189			* Alias for Helper::get_archives_title()
190			* Returns page title for archive page.
191			* Example: Archives, Author: John Doe, Tag: Lorem Ipsum
192			*
193			* @return string
194			*/
195			public static function archives_title() {
196
197			return Helper::get_archives_title();
198
199			}
200
201			/**
202			* Returns posts
203			*
204			* @param mixed $args Array of query args.
205			* @param string $return object/id/Post.
206			*
207			* @return array
208			*/
209			public static function get_posts( $args = false, $return = '\Classy\Models\Post' ) {
210
211			$_return = array();
212
213			$query = Query_Helper::find_query( $args );
214
215			if ( isset( $query->posts ) ) {
216
217			foreach ( $query->posts as $post ) {
218
219			if ( 'id' === $return ) {
220
221			$_return[] = $post->id;
222
223			} elseif ( 'object' === $return ) {
224
225			$_return[] = $post;
226
227			} elseif ( class_exists( $return ) ) {
228
229			$_return[] = new $return( $post );
230
231			}
232			}
233			}
234
235			return $_return;
236			}
237
238
239			/**
240			* Returns post.
241			*
242			* @param mixed $args Array of query args.
243			* @param string $return_type Post/object/id.
244			*
245			* @return mixed
246			*/
247			public static function get_post( $args = false, $return_type = '\Classy\Models\Post' ) {
248
249			$posts = self::get_posts( $args, $return_type );
250
251			if ( $post = reset( $posts ) ) {
252			return $post;
253			}
254
255			}
256
257			/**
258			* @todo: Write description here.
259			*
260			* @param array $prefs Args for paginate_links.
261			*
262			* @return array mixed
263			*/
264			public static function get_pagination( $prefs = array() ) {
265
266			global $wp_query;
			0 ignored issues – show Compatibility Best Practice introduced 2016-05-13 06:15 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
267			global $paged;
			0 ignored issues – show Compatibility Best Practice introduced 2016-05-13 06:15 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
268			global $wp_rewrite;
			0 ignored issues – show Compatibility Best Practice introduced 2016-05-13 06:15 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
269
270			$args = array();
271			$args['total'] = ceil( $wp_query->found_posts / $wp_query->query_vars['posts_per_page'] );
272
273			if ( $wp_rewrite->using_permalinks() ) {
274
275			$url = explode( '?', get_pagenum_link( 0 ) );
276
277			if ( isset( $url[1] ) ) {
278			parse_str( $url[1], $query );
279			$args['add_args'] = $query;
280			}
281
282			$args['format'] = 'page/%#%';
283			$args['base'] = trailingslashit( $url[0] ).'%_%';
284
285			} else {
286			$big = 999999999;
287			$args['base'] = str_replace( $big, '%#%', esc_url( get_pagenum_link( $big ) ) );
288			}
289
290			$args['type'] = 'array';
291			$args['current'] = max( 1, get_query_var( 'paged' ) );
292			$args['mid_size'] = max( 9 - $args['current'], 3 );
293			$args['prev_next'] = false;
294
295			if ( is_int( $prefs ) ) {
296			$args['mid_size'] = $prefs - 2;
297			} else {
298			$args = array_merge( $args, $prefs );
299			}
300
301			$data = array();
302			$data['pages'] = Helper::paginate_links( $args );
			0 ignored issues – show Documentation introduced 2016-05-13 06:15 UTC by Report Bug Copy Issue Report `$args` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
303			$next = get_next_posts_page_link( $args['total'] );
304
305			if ( $next ) {
306			$data['next'] = array( 'link' => untrailingslashit( $next ), 'class' => 'page-numbers next' );
307			}
308
309			$prev = previous_posts( false );
310
311			if ( $prev ) {
312			$data['prev'] = array( 'link' => untrailingslashit( $prev ), 'class' => 'page-numbers prev' );
313			}
314
315			if ( $paged < 2 ) {
316			$data['prev'] = null;
317			}
318
319			return Helper::array_to_object( $data );
320
321			}
322			}
323

anrw / classy

Push — master ( bc6754...ed64c2 )

Classy::get_pagination() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like