Query_Helper - Code Metrics - Inspection of "Merge pull request #14 from anrw/develop" - anrw/classy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bc6754...ed64c2 )

unknown

created 2016-07-13 15:40 UTC

Query_Helper A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	67
rs	10
wmc	8
lcom	0
cbo	0

3 Methods

Rating	Name	Size	Complexity
A	find_query()	20	3
A	get_current_query()	11	1
A	handle_maybe_custom_posts_page()	14	4

<?php
namespace Classy;

class Query_Helper {

	/**
	 * Finds or creates new query based on provided params
	 *
	 * @param  array|boolean $args
	 * @return object        WP_Query
	 */
	public static function find_query( $args = false ) {

		$default_args = array();

		if ( ! $args ) {

			return self::get_current_query();

		} elseif ( is_array( $args ) ) {

			$args = array_merge( $default_args, $args );


			return new \WP_Query( $args );

		} else {

			return new \WP_Query( $default_args );

		}
	}

	/**
	 * Returns current WP_Query
	 *
	 * @return object WP_Query
	 */
	public static function get_current_query() {

		global $wp_query;
function myFunction($a, $b) {
    // Do something
}

		$query =& $wp_query;

		$query = self::handle_maybe_custom_posts_page( $query );

		return $query;

	}

	/**
	 * Checks and returns WP_Query for home posts page
	 *
	 * @param  object $query WP_Query
	 * @return object        WP_Query
	 */
	private static function handle_maybe_custom_posts_page( $query ) {

		if ( $custom_posts_page = get_option( 'page_for_posts' ) ) {

			if ( isset( $query->query['p'] ) && absint( $query->query['p'] ) === absint( $custom_posts_page ) ) {

				return new \WP_Query( array( 'post_type' => 'post' ) );

			}
		}

		return $query;

	}
}


1			<?php
2			namespace Classy;
3
4			class Query_Helper {
5
6			/**
7			* Finds or creates new query based on provided params
8			*
9			* @param array\|boolean $args
10			* @return object WP_Query
11			*/
12			public static function find_query( $args = false ) {
13
14			$default_args = array();
15
16			if ( ! $args ) {
17
18			return self::get_current_query();
19
20			} elseif ( is_array( $args ) ) {
21
22			$args = array_merge( $default_args, $args );
			0 ignored issues – show Coding Style introduced 2016-07-13 12:07 UTC by Report Bug Copy Issue Report Consider using a different name than the parameter `$args`. This often makes code more readable. Loading history...
23
24			return new \WP_Query( $args );
25
26			} else {
27
28			return new \WP_Query( $default_args );
29
30			}
31			}
32
33			/**
34			* Returns current WP_Query
35			*
36			* @return object WP_Query
37			*/
38			public static function get_current_query() {
39
40			global $wp_query;
			0 ignored issues – show Compatibility Best Practice introduced 2016-05-13 06:15 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
41
42			$query =& $wp_query;
43
44			$query = self::handle_maybe_custom_posts_page( $query );
45
46			return $query;
47
48			}
49
50			/**
51			* Checks and returns WP_Query for home posts page
52			*
53			* @param object $query WP_Query
54			* @return object WP_Query
55			*/
56			private static function handle_maybe_custom_posts_page( $query ) {
57
58			if ( $custom_posts_page = get_option( 'page_for_posts' ) ) {
59
60			if ( isset( $query->query['p'] ) && absint( $query->query['p'] ) === absint( $custom_posts_page ) ) {
61
62			return new \WP_Query( array( 'post_type' => 'post' ) );
63
64			}
65			}
66
67			return $query;
68
69			}
70			}
71

anrw / classy

Push — master ( bc6754...ed64c2 )

Query_Helper A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like