ClassyHierarchy::get_request_hierarchy_list() - Code Metrics - Inspection of "Finished renaming Template to View, now it's more..." - anrw/classy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dde21d...97dd3e )

by Andrew

created 2016-05-24 08:42 UTC

ClassyHierarchy::get_request_hierarchy_list() D

↳ Parent: ClassyHierarchy

Complexity

Conditions	24
Paths	31

Size

Total Lines	205
Code Lines	90

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	24
eloc	90
c	1
b	0
f	0
nc	31
nop	1
dl	0
loc	205
rs	4.5989

How to fix Long Method Complexity

<?php

/**
 * Implements Wordpress Hierarchy 
 */

class ClassyHierarchy {
namespace YourVendor;

class YourClass { }

	/**
	 * Stores current request for multiple use
	 * 
	 * @var string/null
	 */
	protected static $current_request = null;


	/**
	 * Protected function to get current request type
	 * 
	 * @return string
	 */
	protected static function check_request() {

		if ( is_404()) : return '404';

		elseif ( is_search() ) : return 'search';

		elseif ( is_front_page() ) : return 'front-page';

		elseif ( is_home() ) : return 'home';

		elseif ( is_post_type_archive() ) : return 'post_type_archive';

		elseif ( is_tax() ) : return 'taxonomy';

		elseif ( is_attachment() ) : return 'attachment';

		elseif ( is_single() ) : return 'single';

		elseif ( self::is_classy_template() ) : return 'classy-template';

		elseif ( is_page() ) : return 'page';

		elseif ( is_singular() ) : return 'singular';

		elseif ( is_category() ) : return 'category';

		elseif ( is_tag() ) : return 'tag';

		elseif ( is_author() ) : return 'author';

		elseif ( is_date() ) : return 'date';

		elseif ( is_archive() ) : return 'archive';

		elseif ( is_paged() ) : return 'paged';

		else :
		
			return 'index';

		endif;

	}

	/**
	 * Returns current request type
	 * 
	 * @return string
	 */
	public static function get_current_request() {

		if ( null === self::$current_request ) {

			self::$current_request = self::check_request();

		}

		return self::$current_request;

	}


	/**
	 * Returns file's absolute path
	 * 
	 * @param  string $type     view/scope
	 * @param  string $view path to view ex: "post/archive"
	 * @return string           full fule path
	 */
	public static function get_file_path($type = 'view', $view) {

		if ($type == 'view') {

			$folder = ClassyView::$folder;

			return THEME_PATH . $folder . '/' . $view . '.blade.php';			
		
		} elseif ($type == 'scope') {

			$folder = ClassyScope::$folder;

			return THEME_PATH . $folder . '/' . $view . '.php';			

		}

	}


	/**
	 * Checks if view exists
	 * 
	 * @param  string $type view/scope
	 * @param  string $view in blade path format, ex: layout/header
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
	 * @return boolean true/false
	 */
	public static function file_exists($type = 'view', $file) {

		$file = str_replace('.', '/', $file);

		$file_path = self::get_file_path($type, $file);

		return file_exists($file_path);

	}


	/**
	 * Returns view name for render, based on type of request
	 *
	 * @param  string $type view/scope
	 * @param  string $type 
	 * @return array 
	 */
	public static function get_available_file($type = 'view', $page) {

		$views = self::get_request_hierarchy_list($page);

		foreach ($views as $view) {

			if ( self::file_exists($type, $view) ):

				return $view;

			endif;

		}

		return false;

	}


	/**
	 * Returns list of filenames to check, based on type of request
	 * 
	 * @param  string $type 
	 * @return array
	 */
	private static function get_request_hierarchy_list($type) {

		$views = array();

		// Home

		if ( $type == 'home' ) :

			$views[] = 'home';

		// Single

		elseif ( $type == 'single' ) :

			$post_type = get_post_type();

			$views[] = $post_type . '.single';

			$views[] = 'single';

		// Post type

		elseif ( $type == 'post_type_archive' ) :

			$post_type = get_post_type();

			$views[] = $post_type . '.archive';

			$views[] = 'archive';


		// Taxonomy

		elseif ( $type == 'taxonomy' ):

			$term = get_queried_object();

			if ( ! empty( $term->slug ) ) {
				
				$taxonomy = $term->taxonomy;

				$views[] = "taxonomy.$taxonomy-{$term->slug}";
				$views[] = "taxonomy.$taxonomy";

			}

			$views[] = 'taxonomy.taxonomy';

			$views[] = 'taxonomy';

		// Category

		elseif ( $type == 'category' ):

			$category = get_queried_object();

			if ( ! empty( $category->slug ) ) {
				$views[] = "category.{$category->slug}";
				$views[] = "category.{$category->term_id}";
			}

			$views[] = 'category.category';

			$views[] = 'category';


		// Attachment

		elseif ( $type == 'attachment' ):

			$attachment = get_queried_object();

			if ( $attachment ) {

				if ( false !== strpos( $attachment->post_mime_type, '/' ) ) {
				
					list( $type, $subtype ) = explode( '/', $attachment->post_mime_type );
				
				} else {
				
					list( $type, $subtype ) = array( $attachment->post_mime_type, '' );
				
				}

				if ( ! empty( $subtype ) ) {
					$views[] = "attachment.{$type}.{$subtype}";
					$views[] = "attachment.{$subtype}";

					$views[] = "{$type}.{$subtype}";
					$views[] = "{$subtype}";
				}

				$views[] = "attachment.{$type}";
				$views[] = "{$type}";

			}

			$views[] = 'attachment.attachment';

			$views[] = 'attachment';


		// Tag

		elseif ( $type == 'tag' ):

			$tag = get_queried_object();

			if ( ! empty( $tag->slug ) ) {
				$views[] = "post.tag.{$tag->slug}";
				$views[] = "post.tag.{$tag->term_id}";

				$views[] = "tag.{$tag->slug}";
				$views[] = "tag.{$tag->term_id}";
			}
			$views[] = 'post.tag';

			$views[] = 'tag';


		// Author

		elseif ( $type == 'author' ):

			$author = get_queried_object();

			if ( $author instanceof WP_User ) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
				$views[] = "post.author.{$author->user_nicename}";
				$views[] = "post.author.{$author->ID}";

				$views[] = "author.{$author->user_nicename}";
				$views[] = "author.{$author->ID}";
			}

			$views[] = 'post.author';

			$views[] = 'author';


		// Front Page

		elseif ( $type == 'front-page' ):

			$views[] = 'front-page.front-page';
			$views[] = 'front-page';
			
			$views[] = 'home.home';
			$views[] = 'home';

			$views = array_merge($views, self::get_request_hierarchy_list('post_type_archive'));

		// Page

		elseif ( $type == 'classy-template' ):

			$template = self::get_classy_template();

			$views[] = $template;

			$views[] = 'page.' . $template;

			$views[] = 'template.' . $template;


		elseif ( $type == 'page' ):

			$id = get_queried_object_id();

			$pagename = get_query_var('pagename');

			if ( ! $pagename && $id ) {
				// If a static page is set as the front page, $pagename will not be set. Retrieve it from the queried object
				$post = get_queried_object();
				
				if ( $post ) {
					$pagename = $post->post_name;
				}
			}

			if ( $pagename ) {
				$views[] = 'page.' . $pagename;
			}
			
			if ( $id ) {
				$views[] = 'page.' . $id;
			}

			$views[] = 'page.page';
			
			$views[] = 'page';


		// Default

		else:

			$views[] = $type;

		endif;

		$views[] = 'index';

		return $views;

	}


	/**
	 * Checks if this is classy custom template
	 * 
	 * @return boolean
	 */
	public static function is_classy_template() {

		return self::get_classy_template() ? true : false;
	}


	/**
	 * Returns classy template name or boolean if this is not classy template
	 * 
	 * @return mixed
	 */
	public static function get_classy_template() {

		$template_slug = get_page_template_slug();

		preg_match('/classy\-(.*)/', $template_slug, $matches);

		if ( $matches && isset($matches[1]) ) return $matches[1];


		return false;

	}

}

Push — master ( dde21d...97dd3e )

ClassyHierarchy::get_request_hierarchy_list() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Missing dependencies

2. Missing use statement

1			<?php
2
3			/**
4			* Implements Wordpress Hierarchy
5			*/
6
7			class ClassyHierarchy {
			0 ignored issues – show Coding Style Compatibility introduced 2016-05-16 05:10 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
8
9			/**
10			* Stores current request for multiple use
11			*
12			* @var string/null
13			*/
14			protected static $current_request = null;
15
16
17			/**
18			* Protected function to get current request type
19			*
20			* @return string
21			*/
22			protected static function check_request() {
23
24			if ( is_404()) : return '404';
25
26			elseif ( is_search() ) : return 'search';
27
28			elseif ( is_front_page() ) : return 'front-page';
29
30			elseif ( is_home() ) : return 'home';
31
32			elseif ( is_post_type_archive() ) : return 'post_type_archive';
33
34			elseif ( is_tax() ) : return 'taxonomy';
35
36			elseif ( is_attachment() ) : return 'attachment';
37
38			elseif ( is_single() ) : return 'single';
39
40			elseif ( self::is_classy_template() ) : return 'classy-template';
41
42			elseif ( is_page() ) : return 'page';
43
44			elseif ( is_singular() ) : return 'singular';
45
46			elseif ( is_category() ) : return 'category';
47
48			elseif ( is_tag() ) : return 'tag';
49
50			elseif ( is_author() ) : return 'author';
51
52			elseif ( is_date() ) : return 'date';
53
54			elseif ( is_archive() ) : return 'archive';
55
56			elseif ( is_paged() ) : return 'paged';
57
58			else :
59
60			return 'index';
61
62			endif;
63
64			}
65
66			/**
67			* Returns current request type
68			*
69			* @return string
70			*/
71			public static function get_current_request() {
72
73			if ( null === self::$current_request ) {
74
75			self::$current_request = self::check_request();
76
77			}
78
79			return self::$current_request;
80
81			}
82
83
84			/**
85			* Returns file's absolute path
86			*
87			* @param string $type view/scope
88			* @param string $view path to view ex: "post/archive"
89			* @return string full fule path
90			*/
91			public static function get_file_path($type = 'view', $view) {
92
93			if ($type == 'view') {
94
95			$folder = ClassyView::$folder;
96
97			return THEME_PATH . $folder . '/' . $view . '.blade.php';
98
99			} elseif ($type == 'scope') {
100
101			$folder = ClassyScope::$folder;
102
103			return THEME_PATH . $folder . '/' . $view . '.php';
104
105			}
106
107			}
108
109
110			/**
111			* Checks if view exists
112			*
113			* @param string $type view/scope
114			* @param string $view in blade path format, ex: layout/header
			0 ignored issues – show Bug introduced 2016-05-24 08:45 UTC by Report Bug Copy Issue Report There is no parameter named `$view`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
115			* @return boolean true/false
116			*/
117			public static function file_exists($type = 'view', $file) {
118
119			$file = str_replace('.', '/', $file);
120
121			$file_path = self::get_file_path($type, $file);
122
123			return file_exists($file_path);
124
125			}
126
127
128			/**
129			* Returns view name for render, based on type of request
130			*
131			* @param string $type view/scope
132			* @param string $type
133			* @return array
134			*/
135			public static function get_available_file($type = 'view', $page) {
136
137			$views = self::get_request_hierarchy_list($page);
138
139			foreach ($views as $view) {
140
141			if ( self::file_exists($type, $view) ):
142
143			return $view;
144
145			endif;
146
147			}
148
149			return false;
150
151			}
152
153
154			/**
155			* Returns list of filenames to check, based on type of request
156			*
157			* @param string $type
158			* @return array
159			*/
160			private static function get_request_hierarchy_list($type) {
161
162			$views = array();
163
164			// Home
165
166			if ( $type == 'home' ) :
167
168			$views[] = 'home';
169
170			// Single
171
172			elseif ( $type == 'single' ) :
173
174			$post_type = get_post_type();
175
176			$views[] = $post_type . '.single';
177
178			$views[] = 'single';
179
180			// Post type
181
182			elseif ( $type == 'post_type_archive' ) :
183
184			$post_type = get_post_type();
185
186			$views[] = $post_type . '.archive';
187
188			$views[] = 'archive';
189
190
191			// Taxonomy
192
193			elseif ( $type == 'taxonomy' ):
194
195			$term = get_queried_object();
196
197			if ( ! empty( $term->slug ) ) {
198
199			$taxonomy = $term->taxonomy;
200
201			$views[] = "taxonomy.$taxonomy-{$term->slug}";
202			$views[] = "taxonomy.$taxonomy";
203
204			}
205
206			$views[] = 'taxonomy.taxonomy';
207
208			$views[] = 'taxonomy';
209
210			// Category
211
212			elseif ( $type == 'category' ):
213
214			$category = get_queried_object();
215
216			if ( ! empty( $category->slug ) ) {
217			$views[] = "category.{$category->slug}";
218			$views[] = "category.{$category->term_id}";
219			}
220
221			$views[] = 'category.category';
222
223			$views[] = 'category';
224
225
226			// Attachment
227
228			elseif ( $type == 'attachment' ):
229
230			$attachment = get_queried_object();
231
232			if ( $attachment ) {
233
234			if ( false !== strpos( $attachment->post_mime_type, '/' ) ) {
235
236			list( $type, $subtype ) = explode( '/', $attachment->post_mime_type );
237
238			} else {
239
240			list( $type, $subtype ) = array( $attachment->post_mime_type, '' );
241
242			}
243
244			if ( ! empty( $subtype ) ) {
245			$views[] = "attachment.{$type}.{$subtype}";
246			$views[] = "attachment.{$subtype}";
247
248			$views[] = "{$type}.{$subtype}";
249			$views[] = "{$subtype}";
250			}
251
252			$views[] = "attachment.{$type}";
253			$views[] = "{$type}";
254
255			}
256
257			$views[] = 'attachment.attachment';
258
259			$views[] = 'attachment';
260
261
262			// Tag
263
264			elseif ( $type == 'tag' ):
265
266			$tag = get_queried_object();
267
268			if ( ! empty( $tag->slug ) ) {
269			$views[] = "post.tag.{$tag->slug}";
270			$views[] = "post.tag.{$tag->term_id}";
271
272			$views[] = "tag.{$tag->slug}";
273			$views[] = "tag.{$tag->term_id}";
274			}
275			$views[] = 'post.tag';
276
277			$views[] = 'tag';
278
279
280			// Author
281
282			elseif ( $type == 'author' ):
283
284			$author = get_queried_object();
285
286			if ( $author instanceof WP_User ) {
			0 ignored issues – show Bug introduced 2016-05-13 06:15 UTC by Report Bug Copy Issue Report The class `WP_User` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
287			$views[] = "post.author.{$author->user_nicename}";
288			$views[] = "post.author.{$author->ID}";
289
290			$views[] = "author.{$author->user_nicename}";
291			$views[] = "author.{$author->ID}";
292			}
293
294			$views[] = 'post.author';
295
296			$views[] = 'author';
297
298
299			// Front Page
300
301			elseif ( $type == 'front-page' ):
302
303			$views[] = 'front-page.front-page';
304			$views[] = 'front-page';
305
306			$views[] = 'home.home';
307			$views[] = 'home';
308
309			$views = array_merge($views, self::get_request_hierarchy_list('post_type_archive'));
310
311			// Page
312
313			elseif ( $type == 'classy-template' ):
314
315			$template = self::get_classy_template();
316
317			$views[] = $template;
318
319			$views[] = 'page.' . $template;
320
321			$views[] = 'template.' . $template;
322
323
324			elseif ( $type == 'page' ):
325
326			$id = get_queried_object_id();
327
328			$pagename = get_query_var('pagename');
329
330			if ( ! $pagename && $id ) {
331			// If a static page is set as the front page, $pagename will not be set. Retrieve it from the queried object
332			$post = get_queried_object();
333
334			if ( $post ) {
335			$pagename = $post->post_name;
336			}
337			}
338
339			if ( $pagename ) {
340			$views[] = 'page.' . $pagename;
341			}
342
343			if ( $id ) {
344			$views[] = 'page.' . $id;
345			}
346
347			$views[] = 'page.page';
348
349			$views[] = 'page';
350
351
352			// Default
353
354			else:
355
356			$views[] = $type;
357
358			endif;
359
360			$views[] = 'index';
361
362			return $views;
363
364			}
365
366
367			/**
368			* Checks if this is classy custom template
369			*
370			* @return boolean
371			*/
372			public static function is_classy_template() {
373
374			return self::get_classy_template() ? true : false;
375			}
376
377
378			/**
379			* Returns classy template name or boolean if this is not classy template
380			*
381			* @return mixed
382			*/
383			public static function get_classy_template() {
384
385			$template_slug = get_page_template_slug();
386
387			preg_match('/classy\-(.*)/', $template_slug, $matches);
388
389			if ( $matches && isset($matches[1]) ) return $matches[1];
			0 ignored issues – show Bug Best Practice introduced 2016-05-14 14:11 UTC by Report Bug Copy Issue Report The expression `$matches` of type `string[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
390
391			return false;
392
393			}
394
395			}

anrw / classy

Push — master ( dde21d...97dd3e )

ClassyHierarchy::get_request_hierarchy_list() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like