ClassyImage - Code Metrics - Inspection of "Merge pull request #3 from anrw/develop" - anrw/classy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 049abe...7733bc )

by Andrew

created 2016-06-22 14:04 UTC

ClassyImage A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	4
Bugs	0	Features	1

Metric	Value
c	4
b	0
f	1
dl	0
loc	57
rs	10
wmc	6
lcom	1
cbo	1

3 Methods

Rating	Name	Size	Complexity
A	__construct()	13	3
A	get_default_image()	6	1
A	src()	14	2

<?php

class ClassyImage extends ClassyBasis {
namespace YourVendor;

class YourClass { }

	/**
	 * Current image id
	 * @var int
	 */
	public $ID;

	/**
	 * Main constructor function. Requires image id
	 * @param int $pid
	 */
	public function __construct( $pid = null ) {

		// Checks if image with this id exists
		if ( $pid && wp_get_attachment_image_src( $pid ) ) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false

			$this->ID = $pid;

		} else {

			$this->ID = 0;

		}
	}

	/**
	 * Returns default image url
	 * @return string
	 */
	public static function get_default_image() {

		// You can put here any url
		return THEME_DIR . '/assets/noimage.png';

	}

	/**
	 * Returns image url. In case image ID is 0 or not set returns default image
	 * @param  string $size
	 * @return string
	 */
	public function src( $size = 'medium' ) {

		if ( $this->ID ) {

			$thumb = wp_get_attachment_image_src( $this->ID, $size );

			return $thumb[0];

		} else {

			return self::get_default_image();

		}
	}
}


1			<?php
2
3			class ClassyImage extends ClassyBasis {
			0 ignored issues – show Coding Style Compatibility introduced 2016-05-13 06:15 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4
5			/**
6			* Current image id
7			* @var int
8			*/
9			public $ID;
10
11			/**
12			* Main constructor function. Requires image id
13			* @param int $pid
14			*/
15			public function __construct( $pid = null ) {
16
17			// Checks if image with this id exists
18			if ( $pid && wp_get_attachment_image_src( $pid ) ) {
			0 ignored issues – show Bug Best Practice introduced 2016-06-22 14:03 UTC by Report Bug Copy Issue Report The expression `$pid` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be zero. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
19
20			$this->ID = $pid;
21
22			} else {
23
24			$this->ID = 0;
25
26			}
27			}
28
29			/**
30			* Returns default image url
31			* @return string
32			*/
33			public static function get_default_image() {
34
35			// You can put here any url
36			return THEME_DIR . '/assets/noimage.png';
37
38			}
39
40			/**
41			* Returns image url. In case image ID is 0 or not set returns default image
42			* @param string $size
43			* @return string
44			*/
45			public function src( $size = 'medium' ) {
46
47			if ( $this->ID ) {
48
49			$thumb = wp_get_attachment_image_src( $this->ID, $size );
50
51			return $thumb[0];
52
53			} else {
54
55			return self::get_default_image();
56
57			}
58			}
59			}
60

anrw / classy

Push — master ( 049abe...7733bc )

ClassyImage A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like