Classy\Menu

Complexity

Total Complexity

36

Size/Duplication

Total Lines	183
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	4
Bugs	1	Features	3

8 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	21	8
B	init()	0	22	6
A	get_first_menu_id()	0	11	4
A	get_locations_menu_id()	0	11	3
B	check_menu_id()	0	13	5
B	get_menu_id_by_name()	0	13	5
A	get_menu_name_by_id()	0	11	4
A	get_items()	0	3	1

<?php
/**
 * Class for handling menu functionality.
 *
 * @package Classy
 */

namespace Classy;

/**
 * Class Menu.
 */
class Menu {

	/**
	 * Menu ID.
	 *
	 * @var int
	 */
	public $ID;

	/**
	 * Menu title.
	 *
	 * @var string
	 */
	public $title;

	/**
	 * Items.
	 *
	 * @var array
	 */
	protected $items;

	/**
	 * Main constructor. Tries to find menu id based on provided arg (or not) and inits menu.
	 *
	 * @param string $arg It can be menu id, slug or full name.
	 */
	public function __construct( $arg = null ) {
		$locations = get_nav_menu_locations();

		if ( is_numeric( $arg ) && 0 !== absint( $arg ) ) {
			$menu_id = $this->check_menu_id( $arg );
		} elseif ( is_array( $locations ) && count( $locations ) ) {
			$menu_id = $this->get_locations_menu_id( $locations, $arg );
		} elseif ( is_string( $arg ) ) {
			$menu_id = $this->get_menu_id_by_name( $arg );
		}

		if ( ! isset( $menu_id ) ) {
			$menu_id = $this->get_first_menu_id();
		}

		if ( $menu_id ) {
			$this->ID = $menu_id;

It seems like $menu_id can also be of type boolean. However, the property $ID is declared as type integer. Maybe add an additional type check?

			$this->title = $this->get_menu_name_by_id($menu_id);

It seems like $this->get_menu_name_by_id($menu_id) of type integer or boolean is incompatible with the declared type string of property $title.

			$this->init();
		}
	}

	/**
	 * Init menu.
	 */
	protected function init() {
		$_return = array();
		$items = wp_get_nav_menu_items( $this->ID );

		foreach ( $items as $item ) {
			$_return[ $item->ID ] = new Menu_Item( $item );
		}

		// Apply nesting.
		foreach ( $_return as $item_id => $item ) {
			if (
				isset( $item->menu_item_parent ) &&
				$item->menu_item_parent &&
				isset( $_return[ $item->menu_item_parent ] )
			) {
				$_return[ $item->menu_item_parent ]->add_child( $item );
				unset( $_return[ $item_id ] );
			}
		}

		$this->items = $_return;
	}

	/**
	 * Returns first menu id or false if there are no menus.
	 *
	 * @return int|bool
	 */
	protected function get_first_menu_id() {
		$menus = get_terms( 'nav_menu', array( 'hide_empty' => true ) );

		if ( is_array( $menus ) && count( $menus ) ) {
			if ( isset( $menus[0]->term_id ) ) {
				return $menus[0]->term_id;
			}
		}

		return false;
	}

	/**
	 * Performs menu id lookup inside navigation Menus.
	 *
	 * @param  array      $locations locations that are returned by get_nav_menu_locations().
	 * @param  int|string $arg navigation id.
	 * @return int
	 */
	protected function get_locations_menu_id( $locations, $arg ) {
		if ( is_numeric( $arg ) ) {
			$arg = array_search( $arg, $locations );
		}

		if ( isset( $locations[ $arg ] ) ) {
			$menu_id = $locations[ $arg ];

			return $menu_id;
		}
	}

	/**
	 * Checks if the provided menu id exists.
	 *
	 * @param int $menu_id Menu ID.
	 *
	 * @return int|boolean
	 */
	protected function check_menu_id( $menu_id ) {
		$menus = get_terms( 'nav_menu', array( 'hide_empty' => true ) );

		if ( is_array( $menus ) && count( $menus ) ) {
			foreach ( $menus as $menu ) {
				if ( absint( $menu->term_id ) === absint( $menu_id ) ) {
					return $menu_id;
				}
			}
		}

		return false;
	}

	/**
	 * Returns menu id by menu name/slug.
	 *
	 * @param string $slug Menu's name.
	 *
	 * @return int|bool
	 */
	protected function get_menu_id_by_name( $slug = null ) {
		if ( $slug && is_string( $slug ) ) {

The expression $slug of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

			if ( $menu_id = get_term_by( 'slug', $slug, 'nav_menu' ) ) {
				return $menu_id;
			}

			if ( $menu_id = get_term_by( 'name', $slug, 'nav_menu' ) ) {
				return $menu_id;
			}
		}

		return false;
	}

	/**
	 * Returns menu name by menu id.
	 *
	 * @param string $name Menu's name.

There is no parameter named $name. Was it maybe removed?

	 *
	 * @return int|bool
	 */
	protected function get_menu_name_by_id( $id = null ) {
		if ( $id && is_int( $id ) ) {
			$menu_obj = wp_get_nav_menu_object($id);

			if ( $menu_obj ) {
				return $menu_obj->name;
			}
		}

		return false;
	}


	/**
	 * Returns menu items.
	 *
	 * @return array
	 */
	public function get_items() {
		return $this->items;
	}
}