Query_Helper::handle_maybe_custom_posts_page() - Code Metrics - anrw/classy - Measure and Improve Code Quality continuously with Scrutinizer

Query_Helper::handle_maybe_custom_posts_page() A
last analyzed 2016-08-22 10:54 UTC

↳ Parent: Query_Helper

Complexity

Conditions	4
Paths	3

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	1	Features	1

Metric	Value
cc	4
eloc	7
nc	3
nop	1
dl	0
loc	12
rs	9.2
c	4
b	1
f	1

<?php
/**
 * Helper for work with WP_Query.
 *
 * @package Classy
 */

namespace Classy;

/**
 * Class Query_Helper.
 */
class Query_Helper {

	/**
	 * Finds or creates new query based on provided params.
	 *
	 * @param array|boolean $args Args for WP_Query.
	 *
	 * @return \WP_Query
	 */
	public static function find_query( $args = false ) {
		$default_args = array();

		if ( ! $args ) {
			return self::get_current_query();
		}

		if ( is_array( $args ) ) {
			return new \WP_Query( array_merge( $default_args, $args ) );
		}

		return new \WP_Query( $default_args );
	}

	/**
	 * Returns current WP_Query.
	 *
	 * @return \WP_Query
	 */
	public static function get_current_query() {
		global $wp_query;
function myFunction($a, $b) {
    // Do something
}
		$query =& $wp_query;
		$query = self::handle_maybe_custom_posts_page( $query );

		return $query;
	}

	/**
	 * Checks and returns WP_Query for home posts page.
	 *
	 * @param \WP_Query $query WP_Query object.
	 *
	 * @return \WP_Query
	 */
	private static function handle_maybe_custom_posts_page( $query ) {
		if ( $custom_posts_page = get_option( 'page_for_posts' ) ) {
			if (
				isset( $query->query['p'] ) &&
				absint( $query->query['p'] ) === absint( $custom_posts_page )
			) {
				return new \WP_Query( array( 'post_type' => 'post' ) );
			}
		}

		return $query;
	}
}


1			<?php
2			/**
3			* Helper for work with WP_Query.
4			*
5			* @package Classy
6			*/
7
8			namespace Classy;
9
10			/**
11			* Class Query_Helper.
12			*/
13			class Query_Helper {
14
15			/**
16			* Finds or creates new query based on provided params.
17			*
18			* @param array\|boolean $args Args for WP_Query.
19			*
20			* @return \WP_Query
21			*/
22			public static function find_query( $args = false ) {
23			$default_args = array();
24
25			if ( ! $args ) {
26			return self::get_current_query();
27			}
28
29			if ( is_array( $args ) ) {
30			return new \WP_Query( array_merge( $default_args, $args ) );
31			}
32
33			return new \WP_Query( $default_args );
34			}
35
36			/**
37			* Returns current WP_Query.
38			*
39			* @return \WP_Query
40			*/
41			public static function get_current_query() {
42			global $wp_query;
			0 ignored issues – show Compatibility Best Practice introduced 2016-05-13 06:15 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
43			$query =& $wp_query;
44			$query = self::handle_maybe_custom_posts_page( $query );
45
46			return $query;
47			}
48
49			/**
50			* Checks and returns WP_Query for home posts page.
51			*
52			* @param \WP_Query $query WP_Query object.
53			*
54			* @return \WP_Query
55			*/
56			private static function handle_maybe_custom_posts_page( $query ) {
57			if ( $custom_posts_page = get_option( 'page_for_posts' ) ) {
58			if (
59			isset( $query->query['p'] ) &&
60			absint( $query->query['p'] ) === absint( $custom_posts_page )
61			) {
62			return new \WP_Query( array( 'post_type' => 'post' ) );
63			}
64			}
65
66			return $query;
67			}
68			}
69

anrw / classy

Query_Helper::handle_maybe_custom_posts_page() A last analyzed 2016-08-22 10:54 UTC

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like

Query_Helper::handle_maybe_custom_posts_page() A
last analyzed 2016-08-22 10:54 UTC