anpk12 / sysinfo

src/Sysinfo/Snapshot.php

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 23 and the first side effect is on line 140.

/*
Copyright 2016 Anton Petersson

This file is part of Sysinfo.

Sysinfo is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

Sysinfo is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with Sysinfo.  If not, see <http://www.gnu.org/licenses/>.
*/

namespace Anpk12\Sysinfo;

class Snapshot
{
    private $procDir;
    function __construct($procDir='/proc')

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->procDir = $procDir;
        $this->readLoadAvg();
        $this->readMeminfo();
    }

    private $loadavgData = [];
    private function readLoadAvg()
    {
        $f = fopen($this->procDir . "/loadavg", "r");
        if ( !$f )
            throw new Exception("failed to read loadavg");
        if ( ($str = fgets($f)) != FALSE )

It seems like you are loosely comparing $str = fgets($f) of type string to the boolean FALSE. If you are specifically checking for a non-empty string, consider using the more explicit !== '' instead.

        {
            $this->loadavgData = explode(" ", $str);
            unset($this->loadavgData[3]);
            unset($this->loadavgData[4]);
        }
        fclose($f);
    }

    public function loadavg()
    {
        return $this->loadavgData;
    }

    private $meminfoData = [];
    private function readMeminfo()
    {
        $f = fopen($this->procDir . "/meminfo", "r");
        $this->meminfoData = [];
        if ( !$f )
            throw new Exception("failed to read meminfo");
        while ( ($str = fgets($f)) != FALSE )

It seems like you are loosely comparing $str = fgets($f) of type string to the boolean FALSE. If you are specifically checking for a non-empty string, consider using the more explicit !== '' instead.

        {
            $numMatches = preg_match_all(
            "/([[:alpha:]()_0-9]+):\s+([0-9]+)(?:\s([[:alpha:]]+)){0,1}/",
                $str, $entry, PREG_SPLIT_DELIM_CAPTURE);
            if ( $numMatches > 0 )
            {
                $key = $entry[0][1];
                $newEntry = array('value' => $entry[0][2]);
                if ( isset($entry[0][3]) )
                {
                    $newEntry['unit'] = $entry[0][3];
                }
                $this->meminfoData[$key] = $newEntry;
            }
        }
        fclose($f);
    }

    /**
    Return all info from /proc/meminfo
    */
    public function meminfo()
    {
        return $this->meminfoData;
    }

    public function memTotal()
    {
        return $this->meminfoData['MemTotal'];
    }

    public function memAvailable()
    {
        return  $this->meminfoData['MemAvailable'];
    }

    public function htmlReport($summary=false)
    {
        $report = "<h2>Host system stats</h2>";
        $report .= "<h3>Memory</h3>";
        if ( $summary === true )
        {
            $mema = $this->memAvailable();
            $memt = $this->memTotal();
            $report .= "<p><strong>".entryStr($mema)."</strong> available
                out of a total of <strong>".entryStr($memt)."</strong></p>";
        } else
        {
            $report .= $this->memHtmlReport();
        }

        $report .= "<h3>Load</h3>";
        $loadavg = $this->loadavg();
        $report .= "<p>Average number of jobs in run queue or 
            waiting for disk I/O the last 1, 5, and 15 minutes: <strong>"
            .$loadavg[0]."</strong>, <strong>".$loadavg[1]."</strong>, <strong>".$loadavg[2]."</strong></p>";

        return $report;
    }
    public function memHtmlReport()
    {
        $mem = $this->meminfo();

        $html = '<table>';
        foreach ( $mem as $key => $entry )
        {
            $html .= '<tr>';
            $html .= '<td class="sysinfo_key">'.$key.
                '</td><td class="sysinfo_value">'.$entry['value'] .'</td>';
            if ( isset($entry['unit']) )
            {
                $html .= '<td class="sysinfo_unit">'.$entry['unit'].'</td>';
            }
            $html .= '</tr>';
        }
        $html .= '</table>';

        return $html;
    }
};

function entryStr($entry)
{
    return $entry['value'].$entry['unit'];
}