Issues in RoleRepository.php (master) - Issues in master - anomalylabs/users-module - Measure and Improve Code Quality continuously with Scrutinizer

Issues (56)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Role/RoleRepository.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php namespace Anomaly\UsersModule\Role;

use Anomaly\Streams\Platform\Entry\EntryCollection;
use Anomaly\Streams\Platform\Entry\EntryRepository;
use Anomaly\UsersModule\Role\Contract\RoleInterface;
use Anomaly\UsersModule\Role\Contract\RoleRepositoryInterface;
use Illuminate\Support\Collection;

/**
 * Class RoleRepositoryInterface
 *
 * @link          http://pyrocms.com/
 * @author        PyroCMS, Inc. <[email protected]>
 * @author        Ryan Thompson <[email protected]>
 */
class RoleRepository extends EntryRepository implements RoleRepositoryInterface
{

    /**
     * The role model.
     *
     * @var RoleModel
     */
    protected $model;

    /**
     * Create a new RoleRepositoryInterface instance.
     *
     * @param RoleModel $model
     */
    function __construct(RoleModel $model)

    {
        $this->model = $model;
    }

    /**
     * Return all but the admin role.
     *
     * @return RoleCollection
     */
    public function allButAdmin()
    {
        return $this->model->where('slug', '!=', 'admin')->get();
    }

    /**
     * Find a role by it's slug.
     *
     * @param $slug
     * @return null|RoleInterface
     */
    public function findBySlug($slug)
    {
        return $this->model->where('slug', $slug)->first();
    }

    /**
     * Find a role by a permission key.
     *
     * @param $permission
     * @return null|EntryCollection
     */
    public function findByPermission($permission)
    {
        $query = $this->model->newQuery();

        foreach ((array)$permission as $key) {
            $query->where('permissions', 'LIKE', '%"' . str_replace('*', '%', $key) . '"%');
        }

        return $query->get();
    }

    /**
     * Update permissions for a role.
     *
     * @param  RoleInterface $role
     * @param  array         $permissions
     * @return RoleInterface
     */
    public function updatePermissions(RoleInterface $role, array $permissions)
    {
        $role->permissions = $permissions;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $role->save();

        return $role;
    }
}


1			<?php namespace Anomaly\UsersModule\Role;
2
3			use Anomaly\Streams\Platform\Entry\EntryCollection;
4			use Anomaly\Streams\Platform\Entry\EntryRepository;
5			use Anomaly\UsersModule\Role\Contract\RoleInterface;
6			use Anomaly\UsersModule\Role\Contract\RoleRepositoryInterface;
7			use Illuminate\Support\Collection;
8
9			/**
10			* Class RoleRepositoryInterface
11			*
12			* @link http://pyrocms.com/
13			* @author PyroCMS, Inc. <[email protected]>
14			* @author Ryan Thompson <[email protected]>
15			*/
16			class RoleRepository extends EntryRepository implements RoleRepositoryInterface
17			{
18
19			/**
20			* The role model.
21			*
22			* @var RoleModel
23			*/
24			protected $model;
25
26			/**
27			* Create a new RoleRepositoryInterface instance.
28			*
29			* @param RoleModel $model
30			*/
31			function __construct(RoleModel $model)
			0 ignored issues – show Best Practice introduced 2015-12-02 14:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
32			{
33			$this->model = $model;
34			}
35
36			/**
37			* Return all but the admin role.
38			*
39			* @return RoleCollection
40			*/
41			public function allButAdmin()
42			{
43			return $this->model->where('slug', '!=', 'admin')->get();
44			}
45
46			/**
47			* Find a role by it's slug.
48			*
49			* @param $slug
50			* @return null\|RoleInterface
51			*/
52			public function findBySlug($slug)
53			{
54			return $this->model->where('slug', $slug)->first();
55			}
56
57			/**
58			* Find a role by a permission key.
59			*
60			* @param $permission
61			* @return null\|EntryCollection
62			*/
63			public function findByPermission($permission)
64			{
65			$query = $this->model->newQuery();
66
67			foreach ((array)$permission as $key) {
68			$query->where('permissions', 'LIKE', '%"' . str_replace('*', '%', $key) . '"%');
69			}
70
71			return $query->get();
72			}
73
74			/**
75			* Update permissions for a role.
76			*
77			* @param RoleInterface $role
78			* @param array $permissions
79			* @return RoleInterface
80			*/
81			public function updatePermissions(RoleInterface $role, array $permissions)
82			{
83			$role->permissions = $permissions;
			0 ignored issues – show Bug introduced 2015-12-02 14:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `permissions` on the interface `Anomaly\UsersModule\Role\Contract\RoleInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
84
85			$role->save();
86
87			return $role;
88			}
89			}
90

anomalylabs / users-module

Issues (56)

Security Analysis no request data

src/Role/RoleRepository.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like