CompleteResetFormBuilder - Code Metrics - Inspection of "Progress with forms and cleaning things up." - anomalylabs/users-module - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3f0650...a210b6 )

by Ryan

created 2015-12-07 02:47 UTC

CompleteResetFormBuilder A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	96
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	7
c	2
b	0
f	0
lcom	1
cbo	0
dl	0
loc	96
rs	10

5 Methods

Rating	Name	Size	Complexity
A	onReady()	10	3
A	getEmail()	4	1
A	setEmail()	6	1
A	getCode()	4	1
A	setCode()	6	1

<?php namespace Anomaly\UsersModule\User\Reset;

use Anomaly\Streams\Platform\Ui\Form\FormBuilder;
use Illuminate\Contracts\Encryption\Encrypter;
use Illuminate\Http\Request;

/**
 * Class CompleteResetFormBuilder
 *
 * @link          http://anomaly.is/streams-platform
 * @author        AnomalyLabs, Inc. <[email protected]>
 * @author        Ryan Thompson <[email protected]>
 * @package       Anomaly\UsersModule\User\Reset
 */
class CompleteResetFormBuilder extends FormBuilder
{

    /**
     * The reset code.
     *
     * @var null|string
     */
    protected $code = null;

    /**
     * The user email.
     *
     * @var null|string
     */
    protected $email = null;

    /**
     * No model.
     *
     * @var bool
     */
    protected $model = false;

    /**
     * The form actions.
     *
     * @var array
     */
    protected $actions = [
        'submit'
    ];

    /**
     * Fired just before building.
     *
     * @param Encrypter $encrypter
     * @param Request   $request
     */
    public function onReady(Encrypter $encrypter, Request $request)
    {
        if (!$this->getCode()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->setCode($encrypter->decrypt($request->get('code')));
        }

        if (!$this->getEmail()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->setEmail($encrypter->decrypt($request->get('email')));
        }
    }

    /**
     * Get the email.
     *
     * @return null|string
     */
    public function getEmail()
    {
        return $this->email;
    }

    /**
     * Set the email.
     *
     * @param $email
     * @return $this
     */
    public function setEmail($email)
    {
        $this->email = $email;

        return $this;
    }

    /**
     * Get the code.
     *
     * @return null|string
     */
    public function getCode()
    {
        return $this->code;
    }

    /**
     * Set the code.
     *
     * @param $code
     * @return $this
     */
    public function setCode($code)
    {
        $this->code = $code;

        return $this;
    }
}


1			<?php namespace Anomaly\UsersModule\User\Reset;
2
3			use Anomaly\Streams\Platform\Ui\Form\FormBuilder;
4			use Illuminate\Contracts\Encryption\Encrypter;
5			use Illuminate\Http\Request;
6
7			/**
8			* Class CompleteResetFormBuilder
9			*
10			* @link http://anomaly.is/streams-platform
11			* @author AnomalyLabs, Inc. <[email protected]>
12			* @author Ryan Thompson <[email protected]>
13			* @package Anomaly\UsersModule\User\Reset
14			*/
15			class CompleteResetFormBuilder extends FormBuilder
16			{
17
18			/**
19			* The reset code.
20			*
21			* @var null\|string
22			*/
23			protected $code = null;
24
25			/**
26			* The user email.
27			*
28			* @var null\|string
29			*/
30			protected $email = null;
31
32			/**
33			* No model.
34			*
35			* @var bool
36			*/
37			protected $model = false;
38
39			/**
40			* The form actions.
41			*
42			* @var array
43			*/
44			protected $actions = [
45			'submit'
46			];
47
48			/**
49			* Fired just before building.
50			*
51			* @param Encrypter $encrypter
52			* @param Request $request
53			*/
54			public function onReady(Encrypter $encrypter, Request $request)
55			{
56			if (!$this->getCode()) {
			0 ignored issues – show Bug Best Practice introduced 2015-12-07 02:49 UTC by Report Bug Copy Issue Report The expression `$this->getCode()` of type `null\|string` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
57			$this->setCode($encrypter->decrypt($request->get('code')));
58			}
59
60			if (!$this->getEmail()) {
			0 ignored issues – show Bug Best Practice introduced 2015-12-07 02:49 UTC by Report Bug Copy Issue Report The expression `$this->getEmail()` of type `null\|string` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
61			$this->setEmail($encrypter->decrypt($request->get('email')));
62			}
63			}
64
65			/**
66			* Get the email.
67			*
68			* @return null\|string
69			*/
70			public function getEmail()
71			{
72			return $this->email;
73			}
74
75			/**
76			* Set the email.
77			*
78			* @param $email
79			* @return $this
80			*/
81			public function setEmail($email)
82			{
83			$this->email = $email;
84
85			return $this;
86			}
87
88			/**
89			* Get the code.
90			*
91			* @return null\|string
92			*/
93			public function getCode()
94			{
95			return $this->code;
96			}
97
98			/**
99			* Set the code.
100			*
101			* @param $code
102			* @return $this
103			*/
104			public function setCode($code)
105			{
106			$this->code = $code;
107
108			return $this;
109			}
110			}
111

anomalylabs / users-module

Push — master ( 3f0650...a210b6 )

CompleteResetFormBuilder A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like