Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php namespace Anomaly\UsersModule\Http\Middleware; |
||
19 | class AuthorizeRouteRoles |
||
20 | { |
||
21 | |||
22 | /** |
||
23 | * The auth guard. |
||
24 | * |
||
25 | * @var Guard |
||
26 | */ |
||
27 | protected $auth; |
||
28 | |||
29 | /** |
||
30 | * The route object. |
||
31 | * |
||
32 | * @var Route |
||
33 | */ |
||
34 | protected $route; |
||
35 | |||
36 | /** |
||
37 | * The redirect utility. |
||
38 | * |
||
39 | * @var Redirector |
||
40 | */ |
||
41 | protected $redirect; |
||
42 | |||
43 | /** |
||
44 | * The message bag. |
||
45 | * |
||
46 | * @var MessageBag |
||
47 | */ |
||
48 | protected $messages; |
||
49 | |||
50 | /** |
||
51 | * Create a new AuthorizeModuleAccess instance. |
||
52 | * |
||
53 | * @param Guard $auth |
||
54 | * @param Route $route |
||
55 | * @param Redirector $redirect |
||
56 | * @param MessageBag $messages |
||
57 | */ |
||
58 | public function __construct(Route $route, Redirector $redirect, MessageBag $messages, Guard $auth) |
||
65 | |||
66 | /** |
||
67 | * Check the authorization of module access. |
||
68 | * |
||
69 | * @param Request $request |
||
70 | * @param \Closure $next |
||
71 | * @return \Illuminate\Http\RedirectResponse |
||
72 | */ |
||
73 | public function handle(Request $request, Closure $next) |
||
101 | } |
||
102 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.