ActivateUserByCode::handle() - Code Metrics - anomalylabs/users-module - Measure and Improve Code Quality continuously with Scrutinizer

ActivateUserByCode::handle() A
last analyzed 2017-05-19 08:34 UTC

↳ Parent: ActivateUserByCode

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
c	0
b	0
f	0
rs	9.4285
cc	3
eloc	9
nc	3
nop	1

<?php namespace Anomaly\UsersModule\User\Command;

use Anomaly\UsersModule\User\Contract\UserInterface;
use Anomaly\UsersModule\User\Contract\UserRepositoryInterface;


/**
 * Class ActivateUserByCode
 *
 * @link          http://pyrocms.com/
 * @author        PyroCMS, Inc. <[email protected]>
 * @author        Ryan Thompson <[email protected]>
 */
class ActivateUserByCode
{

    /**
     * The user instance.
     *
     * @var UserInterface
     */
    protected $user;

    /**
     * The activation code.
     *
     * @var string
     */
    protected $code;

    /**
     * Create a new ActivateUserByCode instance.
     *
     * @param UserInterface $user
     * @param               $code
     */
    function __construct(UserInterface $user, $code)

    {
        $this->user = $user;
        $this->code = $code;
    }

    /**
     * Handle the command.
     *
     * @param  UserRepositoryInterface $users
     * @return bool
     */
    public function handle(UserRepositoryInterface $users)
    {
        if (!$user = $users->findByActivationCode($this->code)) {
            return false;
        }

        if ($this->user->getId() !== $user->getId()) {
            return false;
        }

        $this->user->activated       = true;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->user->activation_code = null;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $users->save($this->user);

        return true;
    }
}


1			<?php namespace Anomaly\UsersModule\User\Command;
2
3			use Anomaly\UsersModule\User\Contract\UserInterface;
4			use Anomaly\UsersModule\User\Contract\UserRepositoryInterface;
5
6
7			/**
8			* Class ActivateUserByCode
9			*
10			* @link http://pyrocms.com/
11			* @author PyroCMS, Inc. <[email protected]>
12			* @author Ryan Thompson <[email protected]>
13			*/
14			class ActivateUserByCode
15			{
16
17			/**
18			* The user instance.
19			*
20			* @var UserInterface
21			*/
22			protected $user;
23
24			/**
25			* The activation code.
26			*
27			* @var string
28			*/
29			protected $code;
30
31			/**
32			* Create a new ActivateUserByCode instance.
33			*
34			* @param UserInterface $user
35			* @param $code
36			*/
37			function __construct(UserInterface $user, $code)
			0 ignored issues – show Best Practice introduced 2015-12-02 14:19 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
38			{
39			$this->user = $user;
40			$this->code = $code;
41			}
42
43			/**
44			* Handle the command.
45			*
46			* @param UserRepositoryInterface $users
47			* @return bool
48			*/
49			public function handle(UserRepositoryInterface $users)
50			{
51			if (!$user = $users->findByActivationCode($this->code)) {
52			return false;
53			}
54
55			if ($this->user->getId() !== $user->getId()) {
56			return false;
57			}
58
59			$this->user->activated = true;
			0 ignored issues – show Bug introduced 2015-12-02 14:19 UTC by Report Bug Copy Issue Report Accessing `activated` on the interface `Anomaly\UsersModule\User\Contract\UserInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
60			$this->user->activation_code = null;
			0 ignored issues – show Bug introduced 2015-12-02 14:19 UTC by Report Bug Copy Issue Report Accessing `activation_code` on the interface `Anomaly\UsersModule\User\Contract\UserInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
61
62			$users->save($this->user);
63
64			return true;
65			}
66			}
67

anomalylabs / users-module

ActivateUserByCode::handle() A last analyzed 2017-05-19 08:34 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

ActivateUserByCode::handle() A
last analyzed 2017-05-19 08:34 UTC