Issues in EntryTranslationsModel.php (master) - Issues in master - anomalylabs/streams-platform - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1191)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Entry/EntryTranslationsModel.php (10 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php namespace Anomaly\Streams\Platform\Entry;

use Anomaly\Streams\Platform\Assignment\Contract\AssignmentInterface;
use Anomaly\Streams\Platform\Model\EloquentModel;
use Carbon\Carbon;

/**
 * Class EntryTranslationsModel
 *
 * @link   http://pyrocms.com/
 * @author PyroCMS, Inc. <[email protected]>
 * @author Ryan Thompson <[email protected]>
 */
class EntryTranslationsModel extends EloquentModel
{

    /**
     * This model uses timestamps.
     *
     * @var bool
     */
    public $timestamps = true;

    /**
     * Cache minutes.
     *
     * @var int
     */
    //protected $cacheMinutes = 99999;


    /**
     * Boot the model.
     */
    protected static function boot()
    {
        self::observe(app(substr(__CLASS__, 0, -5) . 'Observer'));

        parent::boot();
    }

    /**
     * Return the last modified datetime.
     *
     * @return Carbon
     */
    public function lastModified()
    {
        return $this->updated_at ?: $this->created_at;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Get the locale.
     *
     * @return string
     */
    public function getLocale()
    {
        return $this->getAttributeFromArray($this->getLocaleKey());
    }

    /**
     * Get an attribute.
     *
     * @param  string $key
     * @return mixed
     */
    public function getAttribute($key)
    {
        if ($key === 'locale') {
            return parent::getAttribute('locale');
        }

        if (!$parent = $this->getParent()) {
            return $this->attributes[$key];
        }

        /* @var AssignmentInterface $assignment */
        $assignment = $parent->getAssignment($key);

        if (!$assignment) {
            return parent::getAttribute($key);
        }

        $type = $assignment->getFieldType($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $type->setEntry($this);
        $type->setLocale($this->locale);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $accessor = $type->getAccessor();
        $modifier = $type->getModifier();

        return $modifier->restore($accessor->get($key));

    }

    /**
     * Get the parent.
     *
     * @return EntryModel
     */
    public function getParent()
    {
        return isset($this->relations['parent']) ? $this->relations['parent'] : null;
    }

    /**
     * Set the attribute.
     *
     * @param string $key
     * @param mixed  $value
     */
    public function setAttribute($key, $value)

    {
        if (!$parent = $this->getParent()) {
            return null;
        }

        /* @var AssignmentInterface $assignment */
        $assignment = $parent->getAssignment($key);

        if (!$assignment) {
            parent::setAttribute($key, $value);

            return;
        }

        $type = $assignment->getFieldType($this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $type->setEntry($this);
        $type->setLocale($this->locale);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $accessor = $type->getAccessor();
        $modifier = $type->getModifier();

        $accessor->set($modifier->modify($value));
    }

    /**
     * Fire field type events.
     *
     * @param       $trigger
     * @param array $payload
     */
    public function fireFieldTypeEvents($trigger, $payload = [])
    {
        if (!$parent = $this->getParent()) {
            return null;
        }

        $assignments = $parent->getAssignments();

        /* @var AssignmentInterface $assignment */
        foreach ($assignments->translatable() as $assignment) {
            $fieldType = $assignment->getFieldType();

            $fieldType->setValue($parent->getFieldValue($assignment->getFieldSlug()));

            $fieldType->setEntry($this);
            $fieldType->setLocale($this->locale);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            $fieldType->fire($trigger, array_merge(compact('fieldType', 'entry'), $payload));
        }
    }

    /**
     * Truncate the translation's table.
     *
     * @return mixed
     */
    public function truncate()
    {
        return $this->newQuery()->truncate();
    }

    /**
     * Let the parent handle calls if they don't exist here.
     *
     * @param  string $name
     * @param  array  $arguments
     * @return mixed
     */
    public function __call($name, $arguments)
    {
        return call_user_func_array([$this->getParent(), $name], $arguments);
    }

    /**
     * Get the attribute from the parent
     * if it does not exist here.
     *
     * @param  string $key
     * @return mixed
     */
    public function __get($key)
    {
        $value = parent::__get($key);

        if (!$value && $parent = $this->getParent()) {
            return $parent->{$key};
        }

        return $value;
    }
}


1		<?php namespace Anomaly\Streams\Platform\Entry;
2
3		use Anomaly\Streams\Platform\Assignment\Contract\AssignmentInterface;
4		use Anomaly\Streams\Platform\Model\EloquentModel;
5		use Carbon\Carbon;
6
7		/**
8		* Class EntryTranslationsModel
9		*
10		* @link http://pyrocms.com/
11		* @author PyroCMS, Inc. <[email protected]>
12		* @author Ryan Thompson <[email protected]>
13		*/
14		class EntryTranslationsModel extends EloquentModel
15		{
16
17		/**
18		* This model uses timestamps.
19		*
20		* @var bool
21		*/
22		public $timestamps = true;
23
24		/**
25		* Cache minutes.
26		*
27		* @var int
28		*/
29		//protected $cacheMinutes = 99999;
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-22 19:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
30
31		/**
32		* Boot the model.
33		*/
34		protected static function boot()
35		{
36		self::observe(app(substr(__CLASS__, 0, -5) . 'Observer'));
37
38		parent::boot();
39		}
40
41		/**
42		* Return the last modified datetime.
43		*
44		* @return Carbon
45		*/
46		public function lastModified()
47		{
48		return $this->updated_at ?: $this->created_at;
		0 ignored issues – show Documentation introduced 2016-04-22 19:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `updated_at` does not exist on `object<Anomaly\Streams\P...EntryTranslationsModel>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-04-22 19:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `created_at` does not exist on `object<Anomaly\Streams\P...EntryTranslationsModel>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
49		}
50
51		/**
52		* Get the locale.
53		*
54		* @return string
55		*/
56		public function getLocale()
57		{
58		return $this->getAttributeFromArray($this->getLocaleKey());
59		}
60
61		/**
62		* Get an attribute.
63		*
64		* @param string $key
65		* @return mixed
66		*/
67		public function getAttribute($key)
68		{
69		if ($key === 'locale') {
70		return parent::getAttribute('locale');
71		}
72
73		if (!$parent = $this->getParent()) {
74		return $this->attributes[$key];
75		}
76
77		/* @var AssignmentInterface $assignment */
78		$assignment = $parent->getAssignment($key);
79
80		if (!$assignment) {
81		return parent::getAttribute($key);
82		}
83
84		$type = $assignment->getFieldType($this);
		0 ignored issues – show Documentation introduced 2016-04-22 19:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this` is of type `this<Anomaly\Streams\Pla...EntryTranslationsModel>`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
85
86		$type->setEntry($this);
87		$type->setLocale($this->locale);
		0 ignored issues – show Documentation introduced 2016-04-22 19:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `locale` does not exist on `object<Anomaly\Streams\P...EntryTranslationsModel>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
88
89		$accessor = $type->getAccessor();
90		$modifier = $type->getModifier();
91
92		return $modifier->restore($accessor->get($key));
		0 ignored issues – show Unused Code introduced 2016-04-22 19:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `FieldTypeAccessor::get()` has too many arguments starting with `$key`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
93		}
94
95		/**
96		* Get the parent.
97		*
98		* @return EntryModel
99		*/
100		public function getParent()
101		{
102		return isset($this->relations['parent']) ? $this->relations['parent'] : null;
103		}
104
105		/**
106		* Set the attribute.
107		*
108		* @param string $key
109		* @param mixed $value
110		*/
111	View Code Duplication	public function setAttribute($key, $value)
		0 ignored issues – show Duplication introduced 2016-04-22 19:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
112		{
113		if (!$parent = $this->getParent()) {
114		return null;
115		}
116
117		/* @var AssignmentInterface $assignment */
118		$assignment = $parent->getAssignment($key);
119
120		if (!$assignment) {
121		parent::setAttribute($key, $value);
122
123		return;
124		}
125
126		$type = $assignment->getFieldType($this);
		0 ignored issues – show Documentation introduced 2016-04-22 19:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this` is of type `this<Anomaly\Streams\Pla...EntryTranslationsModel>`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
127
128		$type->setEntry($this);
129		$type->setLocale($this->locale);
		0 ignored issues – show Documentation introduced 2016-04-22 19:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `locale` does not exist on `object<Anomaly\Streams\P...EntryTranslationsModel>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
130
131		$accessor = $type->getAccessor();
132		$modifier = $type->getModifier();
133
134		$accessor->set($modifier->modify($value));
135		}
136
137		/**
138		* Fire field type events.
139		*
140		* @param $trigger
141		* @param array $payload
142		*/
143		public function fireFieldTypeEvents($trigger, $payload = [])
144		{
145		if (!$parent = $this->getParent()) {
146		return null;
147		}
148
149		$assignments = $parent->getAssignments();
150
151		/* @var AssignmentInterface $assignment */
152		foreach ($assignments->translatable() as $assignment) {
153		$fieldType = $assignment->getFieldType();
154
155		$fieldType->setValue($parent->getFieldValue($assignment->getFieldSlug()));
156
157		$fieldType->setEntry($this);
158		$fieldType->setLocale($this->locale);
		0 ignored issues – show Documentation introduced 2016-04-22 19:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `locale` does not exist on `object<Anomaly\Streams\P...EntryTranslationsModel>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
159
160		$fieldType->fire($trigger, array_merge(compact('fieldType', 'entry'), $payload));
161		}
162		}
163
164		/**
165		* Truncate the translation's table.
166		*
167		* @return mixed
168		*/
169		public function truncate()
170		{
171		return $this->newQuery()->truncate();
172		}
173
174		/**
175		* Let the parent handle calls if they don't exist here.
176		*
177		* @param string $name
178		* @param array $arguments
179		* @return mixed
180		*/
181		public function __call($name, $arguments)
182		{
183		return call_user_func_array([$this->getParent(), $name], $arguments);
184		}
185
186		/**
187		* Get the attribute from the parent
188		* if it does not exist here.
189		*
190		* @param string $key
191		* @return mixed
192		*/
193		public function __get($key)
194		{
195		$value = parent::__get($key);
196
197		if (!$value && $parent = $this->getParent()) {
198		return $parent->{$key};
199		}
200
201		return $value;
202		}
203		}
204

anomalylabs / streams-platform

Issues (1191)

Security Analysis not enabled

src/Entry/EntryTranslationsModel.php (10 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like