FieldFiller - Code Metrics - Inspection of "Fix issue with nested section normalization on som..." - anomalylabs/streams-platform - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0e9bc5...7ef25f )

by Ryan

created 2017-01-30 05:53 UTC

FieldFiller A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
dl	0
loc	66
rs	10
c	0
b	0
f	0
wmc	8
lcom	0
cbo	3

1 Method

Rating	Name	Duplication	Size	Complexity
B	fill()	0	57	8

<?php namespace Anomaly\Streams\Platform\Ui\Form\Component\Field;

use Anomaly\Streams\Platform\Ui\Form\FormBuilder;

/**
 * Class FieldFiller
 *
 * @link   http://pyrocms.com/
 * @author PyroCMS, Inc. <[email protected]>
 * @author Ryan Thompson <[email protected]>
 */
class FieldFiller
{

    /**
     * Fill in fields.
     *
     * @param FormBuilder $builder
     */
    public function fill(FormBuilder $builder)
    {
        $fields = $builder->getFields();
        $stream = $builder->getFormStream();

        /*
         * If no Stream, skip it.
         */
        if (!$stream) {
            if (array_search('*', $fields) !== false) {
                unset($fields[array_search('*', $fields)]);

                $builder->setFields($fields);
            }

            return;
        }

        /*
         * Fill with everything by default.
         */
        $fill = $stream->getAssignments()->fieldSlugs();

        /*
         * Loop over field configurations and unset
         * them from the fill fields.
         *
         * If we come across the fill marker then
         * set the position.
         */
        foreach ($fields as $parameters) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if (is_string($parameters) && $parameters === '*') {
                continue;
            }

            /**
             * If we found a field then
             * unset it from the fill fields.
             */
            if (($search = array_search($parameters['field'], $fill)) !== false) {
                unset($fill[$search]);
            }
        }

        /*
         * If we have a fill marker then splice
         * in the remaining fill fields in place
         * of the fill marker.
         */
        if (($position = array_search('*', $fields)) !== false) {
            array_splice($fields, $position, null, $fill);

            unset($fields[array_search('*', $fields)]);
        }

        $builder->setFields($fields);
    }
}


1			<?php namespace Anomaly\Streams\Platform\Ui\Form\Component\Field;
2
3			use Anomaly\Streams\Platform\Ui\Form\FormBuilder;
4
5			/**
6			* Class FieldFiller
7			*
8			* @link http://pyrocms.com/
9			* @author PyroCMS, Inc. <[email protected]>
10			* @author Ryan Thompson <[email protected]>
11			*/
12			class FieldFiller
13			{
14
15			/**
16			* Fill in fields.
17			*
18			* @param FormBuilder $builder
19			*/
20			public function fill(FormBuilder $builder)
21			{
22			$fields = $builder->getFields();
23			$stream = $builder->getFormStream();
24
25			/*
26			* If no Stream, skip it.
27			*/
28			if (!$stream) {
29			if (array_search('*', $fields) !== false) {
30			unset($fields[array_search('*', $fields)]);
31
32			$builder->setFields($fields);
33			}
34
35			return;
36			}
37
38			/*
39			* Fill with everything by default.
40			*/
41			$fill = $stream->getAssignments()->fieldSlugs();
42
43			/*
44			* Loop over field configurations and unset
45			* them from the fill fields.
46			*
47			* If we come across the fill marker then
48			* set the position.
49			*/
50			foreach ($fields as $parameters) {
			0 ignored issues – show Bug introduced 2016-04-22 19:08 UTC by Report Bug Copy Issue Report The expression `$fields` of type `array\|string` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
51			if (is_string($parameters) && $parameters === '*') {
52			continue;
53			}
54
55			/**
56			* If we found a field then
57			* unset it from the fill fields.
58			*/
59			if (($search = array_search($parameters['field'], $fill)) !== false) {
60			unset($fill[$search]);
61			}
62			}
63
64			/*
65			* If we have a fill marker then splice
66			* in the remaining fill fields in place
67			* of the fill marker.
68			*/
69			if (($position = array_search('*', $fields)) !== false) {
70			array_splice($fields, $position, null, $fill);
71
72			unset($fields[array_search('*', $fields)]);
73			}
74
75			$builder->setFields($fields);
76			}
77			}
78

anomalylabs / streams-platform

Push — master ( 0e9bc5...7ef25f )

FieldFiller A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like