anomalylabs /
streams-platform
| Conditions | 8 |
| Paths | 10 |
| Total Lines | 55 |
| Code Lines | 19 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php namespace Anomaly\Streams\Platform\Ui\Form\Component\Field; |
||
| 20 | public function fill(FormBuilder $builder) |
||
| 21 | { |
||
| 22 | $fields = $builder->getFields(); |
||
| 23 | $stream = $builder->getFormStream(); |
||
| 24 | |||
| 25 | /* |
||
| 26 | * If no Stream, skip it. |
||
| 27 | */ |
||
| 28 | if (!$stream) { |
||
| 29 | if (array_search('*', $fields) !== false) { |
||
| 30 | unset($fields[array_search('*', $fields)]); |
||
| 31 | |||
| 32 | $builder->setFields($fields); |
||
| 33 | } |
||
| 34 | |||
| 35 | return; |
||
| 36 | } |
||
| 37 | |||
| 38 | /* |
||
| 39 | * Fill with everything by default. |
||
| 40 | */ |
||
| 41 | $fill = $stream->getAssignments()->fieldSlugs(); |
||
| 42 | |||
| 43 | /* |
||
| 44 | * Loop over field configurations and unset |
||
| 45 | * them from the fill fields. |
||
| 46 | * |
||
| 47 | * If we come across the fill marker then |
||
| 48 | * set the position. |
||
| 49 | */ |
||
| 50 | foreach ($fields as $parameters) { |
||
|
|
|||
| 51 | if (is_string($parameters) && $parameters === '*') { |
||
| 52 | continue; |
||
| 53 | } |
||
| 54 | |||
| 55 | $search = array_search($parameters['field'], $fill); |
||
| 56 | |||
| 57 | // Make sure it actually found something before unsetting |
||
| 58 | if($search != false) |
||
| 59 | unset($fill[$search]); |
||
| 60 | } |
||
| 61 | |||
| 62 | /* |
||
| 63 | * If we have a fill marker then splice |
||
| 64 | * in the remaining fill fields in place |
||
| 65 | * of the fill marker. |
||
| 66 | */ |
||
| 67 | if (($position = array_search('*', $fields)) !== false) { |
||
| 68 | array_splice($fields, $position, null, $fill); |
||
| 69 | |||
| 70 | unset($fields[array_search('*', $fields)]); |
||
| 71 | } |
||
| 72 | |||
| 73 | $builder->setFields($fields); |
||
| 74 | } |
||
| 75 | } |
||
| 76 |
There are different options of fixing this problem.
If you want to be on the safe side, you can add an additional type-check:
If you are sure that the expression is traversable, you might want to add a doc comment cast to improve IDE auto-completion and static analysis:
Mark the issue as a false-positive: Just hover the remove button, in the top-right corner of this issue for more options.