Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php namespace Anomaly\Streams\Platform\Addon\Console\Command; |
||
13 | View Code Duplication | class WriteAddonPhpUnit |
|
|
|||
14 | { |
||
15 | |||
16 | /** |
||
17 | * The addon path. |
||
18 | * |
||
19 | * @var string |
||
20 | */ |
||
21 | private $path; |
||
22 | |||
23 | /** |
||
24 | * The addon type. |
||
25 | * |
||
26 | * @var string |
||
27 | */ |
||
28 | private $type; |
||
29 | |||
30 | /** |
||
31 | * The addon slug. |
||
32 | * |
||
33 | * @var string |
||
34 | */ |
||
35 | private $slug; |
||
36 | |||
37 | /** |
||
38 | * The vendor slug. |
||
39 | * |
||
40 | * @var string |
||
41 | */ |
||
42 | private $vendor; |
||
43 | |||
44 | /** |
||
45 | * Create a new WriteAddonPhpUnit instance. |
||
46 | * |
||
47 | * @param $path |
||
48 | * @param $type |
||
49 | * @param $slug |
||
50 | * @param $vendor |
||
51 | */ |
||
52 | public function __construct($path, $type, $slug, $vendor) |
||
59 | |||
60 | /** |
||
61 | * Handle the command. |
||
62 | * |
||
63 | * @param Parser $parser |
||
64 | * @param Filesystem $filesystem |
||
65 | */ |
||
66 | public function handle(Parser $parser, Filesystem $filesystem) |
||
78 | } |
||
79 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.