SetDefaultOptions::handle() - Code Metrics - Inspection of "Default the table limit to 9999 when the table is..." - anomalylabs/streams-platform - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#200)

by bloveless

created 2016-05-24 20:09 UTC

SetDefaultOptions::handle() C

↳ Parent: SetDefaultOptions

Complexity

Conditions	12
Paths	48

Size

Total Lines	49
Code Lines	15

Duplication

Lines	7
Ratio	14.29 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
c	2
b	1
f	0
dl	7
loc	49
rs	5.1474
cc	12
eloc	15
nc	48
nop	1

How to fix Complexity

<?php namespace Anomaly\Streams\Platform\Ui\Table\Command;

use Anomaly\Streams\Platform\Addon\Module\ModuleCollection;
use Anomaly\Streams\Platform\Ui\Table\TableBuilder;
use Illuminate\Contracts\Bus\SelfHandling;

/**
 * Class SetDefaultOptions
 *
 * @link    http://anomaly.is/streams-platform
 * @author  AnomalyLabs, Inc. <[email protected]>
 * @author  Ryan Thompson <[email protected]>
 * @package Anomaly\Streams\Platform\Ui\Table\Command
 */
class SetDefaultOptions implements SelfHandling
{

    /**
     * The table builder.
     *
     * @var TableBuilder
     */
    protected $builder;

    /**
     * Create a new SetDefaultOptions instance.
     *
     * @param TableBuilder $builder
     */
    public function __construct(TableBuilder $builder)
    {
        $this->builder = $builder;
    }

    /**
     * Handle the command.
     *
     * @param ModuleCollection $modules
     */
    public function handle(ModuleCollection $modules)
    {
        $table = $this->builder->getTable();

        /**
         * Set the default sortable option.
         */
        if ($table->getOption('sortable') === null) {

            $stream = $table->getStream();

            if ($stream && $stream->isSortable()) {

                $table->setOption('sortable', true);
                $table->setOption('limit', $table->getOption('limit', 9999));
            }
        }

        /**
         * Set the default limit if the table is sortable
         */
        if (($table->getOption('sortable') === true) && ($table->getOption('limit') === null)) {

            $table->setOption('limit', $table->getOption('limit', 9999));
        }

        /**
         * Set the default breadcrumb.
         */
        if ($table->getOption('breadcrumb') === null && $title = $table->getOption('title')) {
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
            $table->setOption('breadcrumb', $title);
        }

        /**
         * If the table ordering is currently being overridden
         * then set the values from the request on the builder
         * last so it actually has an effect.
         */
        if ($orderBy = $this->builder->getRequestValue('order_by')) {
            $table->setOption('order_by', [$orderBy => $this->builder->getRequestValue('sort', 'asc')]);
        }

        /**
         * If the permission is not set then
         * try and automate it.
         */
        if ($table->getOption('permission') === null && ($module = $modules->active()) && ($stream = $this->builder->getTableStream())
        ) {
            $table->setOption('permission', $module->getNamespace($stream->getSlug() . '.read'));
        }
    }
}


1		<?php namespace Anomaly\Streams\Platform\Ui\Table\Command;
2
3		use Anomaly\Streams\Platform\Addon\Module\ModuleCollection;
4		use Anomaly\Streams\Platform\Ui\Table\TableBuilder;
5		use Illuminate\Contracts\Bus\SelfHandling;
6
7		/**
8		* Class SetDefaultOptions
9		*
10		* @link http://anomaly.is/streams-platform
11		* @author AnomalyLabs, Inc. <[email protected]>
12		* @author Ryan Thompson <[email protected]>
13		* @package Anomaly\Streams\Platform\Ui\Table\Command
14		*/
15		class SetDefaultOptions implements SelfHandling
16		{
17
18		/**
19		* The table builder.
20		*
21		* @var TableBuilder
22		*/
23		protected $builder;
24
25		/**
26		* Create a new SetDefaultOptions instance.
27		*
28		* @param TableBuilder $builder
29		*/
30		public function __construct(TableBuilder $builder)
31		{
32		$this->builder = $builder;
33		}
34
35		/**
36		* Handle the command.
37		*
38		* @param ModuleCollection $modules
39		*/
40		public function handle(ModuleCollection $modules)
41		{
42		$table = $this->builder->getTable();
43
44		/**
45		* Set the default sortable option.
46		*/
47		if ($table->getOption('sortable') === null) {
48
49		$stream = $table->getStream();
50
51	View Code Duplication	if ($stream && $stream->isSortable()) {
		0 ignored issues – show Duplication introduced 2016-05-24 20:16 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
52		$table->setOption('sortable', true);
53		$table->setOption('limit', $table->getOption('limit', 9999));
54		}
55		}
56
57		/**
58		* Set the default limit if the table is sortable
59		*/
60	View Code Duplication	if (($table->getOption('sortable') === true) && ($table->getOption('limit') === null)) {
		0 ignored issues – show Duplication introduced 2016-05-24 20:16 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
61		$table->setOption('limit', $table->getOption('limit', 9999));
62		}
63
64		/**
65		* Set the default breadcrumb.
66		*/
67		if ($table->getOption('breadcrumb') === null && $title = $table->getOption('title')) {
		0 ignored issues – show Bug introduced 2016-04-22 19:08 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$title` is correct as `$table->getOption('title')` (which targets `Anomaly\Streams\Platform...able\Table::getOption()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
68		$table->setOption('breadcrumb', $title);
69		}
70
71		/**
72		* If the table ordering is currently being overridden
73		* then set the values from the request on the builder
74		* last so it actually has an effect.
75		*/
76		if ($orderBy = $this->builder->getRequestValue('order_by')) {
77		$table->setOption('order_by', [$orderBy => $this->builder->getRequestValue('sort', 'asc')]);
78		}
79
80		/**
81		* If the permission is not set then
82		* try and automate it.
83		*/
84		if ($table->getOption('permission') === null && ($module = $modules->active()) && ($stream = $this->builder->getTableStream())
85		) {
86		$table->setOption('permission', $module->getNamespace($stream->getSlug() . '.read'));
87		}
88		}
89		}
90

anomalylabs / streams-platform

Pull Request — master (#200)

SetDefaultOptions::handle() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like