FieldFactory::make() - Code Metrics - Inspection of "Allow overriding field types for stream entries to..." - anomalylabs/streams-platform - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bfcf14...e377ec )

by Ryan

created 2016-08-03 02:43 UTC

FieldFactory::make() B

↳ Parent: FieldFactory

Complexity

Conditions	8
Paths	4

Size

Total Lines	54
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	54
rs	7.4119
cc	8
eloc	27
nc	4
nop	3

How to fix Long Method

<?php namespace Anomaly\Streams\Platform\Ui\Form\Component\Field;

use Anomaly\Streams\Platform\Addon\FieldType\FieldType;
use Anomaly\Streams\Platform\Addon\FieldType\FieldTypeBuilder;
use Anomaly\Streams\Platform\Entry\Contract\EntryInterface;
use Anomaly\Streams\Platform\Stream\Contract\StreamInterface;
use Anomaly\Streams\Platform\Support\Hydrator;
use Illuminate\Http\Request;

/**
 * Class FieldFactory
 *
 * @link          http://anomaly.is/streams-platform
 * @author        AnomalyLabs, Inc. <[email protected]>
 * @author        Ryan Thompson <[email protected]>
 * @package       Anomaly\Streams\Platform\Ui\Form\Component\Field
 */
class FieldFactory
{

    /**
     * The field type builder utility.
     *
     * @var FieldTypeBuilder
     */
    protected $builder;

    /**
     * The request object.
     *
     * @var Request
     */
    protected $request;

    /**
     * The hydrator utility.
     *
     * @var Hydrator
     */
    protected $hydrator;

    /**
     * Create a new FieldFactory instance.
     *
     * @param FieldTypeBuilder $builder
     * @param Request          $request
     * @param Hydrator         $hydrator
     */
    public function __construct(FieldTypeBuilder $builder, Request $request, Hydrator $hydrator)

    {
        $this->builder  = $builder;
        $this->request  = $request;
        $this->hydrator = $hydrator;
    }

    /**
     * Make a field type.
     *
     * @param array           $parameters
     * @param StreamInterface $stream
     * @param null            $entry
     * @return FieldType
     */
    public function make(array $parameters, StreamInterface $stream = null, $entry = null)
    {
        /* @var EntryInterface $entry */
        if ($stream && $entry instanceof EntryInterface && $entry->hasField(array_get($parameters, 'field'))) {

            /**
             * Allow overriding the type here
             * should they want to do that.
             */
            if (array_get($parameters, 'type')) {
                $field = $this->builder->build($parameters);
            } else {
                $field = clone($entry->getFieldType(array_get($parameters, 'field')));
            }

            $modifier = $field->getModifier();

            $value = array_pull($parameters, 'value');

            /* @var EntryInterface $entry */
            $field->setValue(
                (!is_null($value)) ? $modifier->restore($value) : $entry->getAttribute($field->getField())
            );
        } elseif (is_object($entry)) {

            $field    = $this->builder->build($parameters);
            $modifier = $field->getModifier();

            $value = array_pull($parameters, 'value');

            $field->setValue((!is_null($value)) ? $modifier->restore($value) : $entry->{$field->getField()});
        } else {

            $field    = $this->builder->build($parameters);
            $modifier = $field->getModifier();

            $field->setValue($modifier->restore(array_pull($parameters, 'value')));
        }

        // Set the entry.
        $field->setEntry($entry);

        // Merge in rules and validators.
        $field
            ->mergeRules(array_pull($parameters, 'rules', []))
            ->mergeConfig(array_pull($parameters, 'config', []))
            ->mergeMessages(array_pull($parameters, 'messages', []))
            ->mergeValidators(array_pull($parameters, 'validators', []));

        // Hydrate the field with parameters.
        $this->hydrator->hydrate($field, $parameters);

        return $field;
    }
}


1			<?php namespace Anomaly\Streams\Platform\Ui\Form\Component\Field;
2
3			use Anomaly\Streams\Platform\Addon\FieldType\FieldType;
4			use Anomaly\Streams\Platform\Addon\FieldType\FieldTypeBuilder;
5			use Anomaly\Streams\Platform\Entry\Contract\EntryInterface;
6			use Anomaly\Streams\Platform\Stream\Contract\StreamInterface;
7			use Anomaly\Streams\Platform\Support\Hydrator;
8			use Illuminate\Http\Request;
9
10			/**
11			* Class FieldFactory
12			*
13			* @link http://anomaly.is/streams-platform
14			* @author AnomalyLabs, Inc. <[email protected]>
15			* @author Ryan Thompson <[email protected]>
16			* @package Anomaly\Streams\Platform\Ui\Form\Component\Field
17			*/
18			class FieldFactory
19			{
20
21			/**
22			* The field type builder utility.
23			*
24			* @var FieldTypeBuilder
25			*/
26			protected $builder;
27
28			/**
29			* The request object.
30			*
31			* @var Request
32			*/
33			protected $request;
34
35			/**
36			* The hydrator utility.
37			*
38			* @var Hydrator
39			*/
40			protected $hydrator;
41
42			/**
43			* Create a new FieldFactory instance.
44			*
45			* @param FieldTypeBuilder $builder
46			* @param Request $request
47			* @param Hydrator $hydrator
48			*/
49			public function __construct(FieldTypeBuilder $builder, Request $request, Hydrator $hydrator)
			0 ignored issues – show Bug introduced 2016-04-22 19:08 UTC by Report Bug Copy Issue Report You have injected the Request via parameter `$request`. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via `getCurrentRequest()`. Loading history...
50			{
51			$this->builder = $builder;
52			$this->request = $request;
53			$this->hydrator = $hydrator;
54			}
55
56			/**
57			* Make a field type.
58			*
59			* @param array $parameters
60			* @param StreamInterface $stream
61			* @param null $entry
62			* @return FieldType
63			*/
64			public function make(array $parameters, StreamInterface $stream = null, $entry = null)
65			{
66			/* @var EntryInterface $entry */
67			if ($stream && $entry instanceof EntryInterface && $entry->hasField(array_get($parameters, 'field'))) {
68
69			/**
70			* Allow overriding the type here
71			* should they want to do that.
72			*/
73			if (array_get($parameters, 'type')) {
74			$field = $this->builder->build($parameters);
75			} else {
76			$field = clone($entry->getFieldType(array_get($parameters, 'field')));
77			}
78
79			$modifier = $field->getModifier();
80
81			$value = array_pull($parameters, 'value');
82
83			/* @var EntryInterface $entry */
84			$field->setValue(
85			(!is_null($value)) ? $modifier->restore($value) : $entry->getAttribute($field->getField())
86			);
87			} elseif (is_object($entry)) {
88
89			$field = $this->builder->build($parameters);
90			$modifier = $field->getModifier();
91
92			$value = array_pull($parameters, 'value');
93
94			$field->setValue((!is_null($value)) ? $modifier->restore($value) : $entry->{$field->getField()});
95			} else {
96
97			$field = $this->builder->build($parameters);
98			$modifier = $field->getModifier();
99
100			$field->setValue($modifier->restore(array_pull($parameters, 'value')));
101			}
102
103			// Set the entry.
104			$field->setEntry($entry);
105
106			// Merge in rules and validators.
107			$field
108			->mergeRules(array_pull($parameters, 'rules', []))
109			->mergeConfig(array_pull($parameters, 'config', []))
110			->mergeMessages(array_pull($parameters, 'messages', []))
111			->mergeValidators(array_pull($parameters, 'validators', []));
112
113			// Hydrate the field with parameters.
114			$this->hydrator->hydrate($field, $parameters);
115
116			return $field;
117			}
118			}
119

anomalylabs / streams-platform

Push — master ( bfcf14...e377ec )

FieldFactory::make() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like