Authorizer::checkPermission() - Code Metrics - Inspection of "Merge branch '1.2'" - anomalylabs/streams-platform - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7e2d40...45edf2 )

by Ryan

created 2016-11-14 07:57 UTC

Authorizer::checkPermission() D

↳ Parent: Authorizer

Complexity

Conditions	17
Paths	16

Size

Total Lines	86
Code Lines	45

Duplication

Lines	28
Ratio	32.56 %

Importance

Changes

Metric	Value
cc	17
eloc	45
nc	16
nop	2
dl	28
loc	86
rs	4.8361
c	0
b	0
f	0

How to fix Long Method Complexity

<?php namespace Anomaly\Streams\Platform\Support;

use Anomaly\UsersModule\Role\Contract\RoleInterface;
use Anomaly\UsersModule\User\Contract\UserInterface;
use Illuminate\Config\Repository;
use Illuminate\Contracts\Auth\Guard;
use Illuminate\Http\Request;

class Authorizer
{

    /**
     * The auth utility.
     *
     * @var null|Guard
     */
    protected $guard = null;

    /**
     * The guest role.
     *
     * @var RoleInterface
     */
    protected $guest;

    /**
     * The config repository.
     *
     * @var Repository
     */
    protected $config;

    /**
     * The request object.
     *
     * @var Request
     */
    protected $request;

    /**
     * Create a new Authorizer instance.
     *
     * @param Guard      $guard
     * @param Repository $config
     * @param Request    $request
     */
    public function __construct(Guard $guard, Repository $config, Request $request)

    {
        $this->guard   = $guard;
        $this->config  = $config;
        $this->request = $request;
    }

    /**
     * Authorize a user against a permission.
     *
     * @param                $permission
     * @param  UserInterface $user
     * @return bool
     */
    public function authorize($permission, UserInterface $user = null)
    {
        if (!$user) {
            $user = $this->guard->user();
        }

        if (!$user) {
            $user = $this->request->user();
        }

        if (!$user && $guest = $this->getGuest()) {
            return $guest->hasPermission($permission);
        }

        if (!$user) {
            return false;
        }

        return $this->checkPermission($permission, $user);
    }

    /**
     * Authorize a user against any permission.
     *
     * @param  array         $permissions
     * @param  UserInterface $user
     * @param  bool          $strict
     * @return bool
     */
    public function authorizeAny(array $permissions, UserInterface $user = null, $strict = false)

    {
        if (!$user) {
            $user = $this->guard->user();
        }

        if (!$user) {
            return !$strict;
        }

        foreach ($permissions as $permission) {
            if ($this->checkPermission($permission, $user)) {
                return true;
            }
        }

        return false;
    }

    /**
     * Authorize a user against all permission.
     *
     * @param  array         $permissions
     * @param  UserInterface $user
     * @param  bool          $strict
     * @return bool
     */
    public function authorizeAll(array $permissions, UserInterface $user = null, $strict = false)

    {
        if (!$user) {
            $user = $this->guard->user();
        }

        if (!$user) {
            return !$strict;
        }

        foreach ($permissions as $permission) {
            if (!$this->checkPermission($permission, $user)) {
                return false;
            }
        }

        return true;
    }

    /**
     * Return a user's permission.
     *
     * @param                $permission
     * @param  UserInterface $user
     * @return bool
     */
    protected function checkPermission($permission, UserInterface $user)
    {
        /*
         * No permission, let it proceed.
         */
        if (!$permission) {
            return true;
        }

        /*
         * If the permission does not actually exist
         * then we cant really do anything with it.
         */
        if (str_is('*::*.*', $permission) && !ends_with($permission, '*')) {
            $parts = explode('.', str_replace('::', '.', $permission));
            $end   = array_pop($parts);
            $group = array_pop($parts);
            $parts = explode('::', $permission);

            // If it does not exist, we are authorized.
            if (!in_array($end, (array)$this->config->get($parts[0] . '::permissions.' . $group))) {
                return true;
            }
        } elseif (ends_with($permission, '*')) {
            $parts = explode('::', $permission);

            $addon = array_shift($parts);

            /*
             * Check vendor.module.slug::group.*
             * then check vendor.module.slug::*
             */
            if (str_is('*.*.*::*.*.*', $permission)) {
                $end = trim(substr($permission, strpos($permission, '::') + 2), '.*');

                if (!$permissions = $this->config->get($addon . '::permissions.' . $end)) {
                    return true;
                } else {
                    return $user->hasAnyPermission($permissions);
                }
            } elseif (str_is('*.*.*::*.*', $permission)) {
                $end = trim(substr($permission, strpos($permission, '::') + 2), '.*');

                if (!$permissions = $this->config->get($addon . '::permissions.' . $end)) {

                    return true;
                } else {
                    $check = [];

                    foreach ($permissions as &$permission) {
                        $check[] = $addon . '::' . $end . '.' . $permission;
                    }

                    return $user->hasAnyPermission($check);
                }
            } else {

                if (!$permissions = $this->config->get($addon . '::permissions')) {
                    return true;
                } else {
                    $check = [];

                    foreach ($permissions as $group => &$permission) {
                        foreach ($permission as $access) {
                            $check[] = $addon . '::' . $group . '.' . $access;
                        }
                    }

                    return $user->hasAnyPermission($check);
                }
            }
        } else {
            $parts = explode('::', $permission);

            $end = array_pop($parts);

            if (!in_array($end, (array)$this->config->get($parts[0] . '::permissions'))) {
                return true;
            }
        }

        // Check if the user actually has permission.
        if (!$user || !$user->hasPermission($permission)) {
            return false;
        }

        return true;
    }

    /**
     * Get the guest role.
     *
     * @return RoleInterface
     */
    public function getGuest()
    {
        return $this->guest;
    }

    /**
     * Set the guest role.
     *
     * @param  RoleInterface $guest
     * @return $this
     */
    public function setGuest(RoleInterface $guest)
    {
        $this->guest = $guest;

        return $this;
    }
}


1		<?php namespace Anomaly\Streams\Platform\Support;
2
3		use Anomaly\UsersModule\Role\Contract\RoleInterface;
4		use Anomaly\UsersModule\User\Contract\UserInterface;
5		use Illuminate\Config\Repository;
6		use Illuminate\Contracts\Auth\Guard;
7		use Illuminate\Http\Request;
8
9		class Authorizer
10		{
11
12		/**
13		* The auth utility.
14		*
15		* @var null\|Guard
16		*/
17		protected $guard = null;
18
19		/**
20		* The guest role.
21		*
22		* @var RoleInterface
23		*/
24		protected $guest;
25
26		/**
27		* The config repository.
28		*
29		* @var Repository
30		*/
31		protected $config;
32
33		/**
34		* The request object.
35		*
36		* @var Request
37		*/
38		protected $request;
39
40		/**
41		* Create a new Authorizer instance.
42		*
43		* @param Guard $guard
44		* @param Repository $config
45		* @param Request $request
46		*/
47		public function __construct(Guard $guard, Repository $config, Request $request)
		0 ignored issues – show Bug introduced 2016-11-14 08:03 UTC by Report Bug Copy Issue Report You have injected the Request via parameter `$request`. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via `getCurrentRequest()`. Loading history...
48		{
49		$this->guard = $guard;
50		$this->config = $config;
51		$this->request = $request;
52		}
53
54		/**
55		* Authorize a user against a permission.
56		*
57		* @param $permission
58		* @param UserInterface $user
59		* @return bool
60		*/
61		public function authorize($permission, UserInterface $user = null)
62		{
63		if (!$user) {
64		$user = $this->guard->user();
65		}
66
67		if (!$user) {
68		$user = $this->request->user();
69		}
70
71		if (!$user && $guest = $this->getGuest()) {
72		return $guest->hasPermission($permission);
73		}
74
75		if (!$user) {
76		return false;
77		}
78
79		return $this->checkPermission($permission, $user);
80		}
81
82		/**
83		* Authorize a user against any permission.
84		*
85		* @param array $permissions
86		* @param UserInterface $user
87		* @param bool $strict
88		* @return bool
89		*/
90	View Code Duplication	public function authorizeAny(array $permissions, UserInterface $user = null, $strict = false)
		0 ignored issues – show Duplication introduced 2016-04-22 19:08 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
91		{
92		if (!$user) {
93		$user = $this->guard->user();
94		}
95
96		if (!$user) {
97		return !$strict;
98		}
99
100		foreach ($permissions as $permission) {
101		if ($this->checkPermission($permission, $user)) {
102		return true;
103		}
104		}
105
106		return false;
107		}
108
109		/**
110		* Authorize a user against all permission.
111		*
112		* @param array $permissions
113		* @param UserInterface $user
114		* @param bool $strict
115		* @return bool
116		*/
117	View Code Duplication	public function authorizeAll(array $permissions, UserInterface $user = null, $strict = false)
		0 ignored issues – show Duplication introduced 2016-04-22 19:08 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
118		{
119		if (!$user) {
120		$user = $this->guard->user();
121		}
122
123		if (!$user) {
124		return !$strict;
125		}
126
127		foreach ($permissions as $permission) {
128		if (!$this->checkPermission($permission, $user)) {
129		return false;
130		}
131		}
132
133		return true;
134		}
135
136		/**
137		* Return a user's permission.
138		*
139		* @param $permission
140		* @param UserInterface $user
141		* @return bool
142		*/
143		protected function checkPermission($permission, UserInterface $user)
144		{
145		/*
146		* No permission, let it proceed.
147		*/
148		if (!$permission) {
149		return true;
150		}
151
152		/*
153		* If the permission does not actually exist
154		* then we cant really do anything with it.
155		*/
156		if (str_is('::.', $permission) && !ends_with($permission, '')) {
157		$parts = explode('.', str_replace('::', '.', $permission));
158		$end = array_pop($parts);
159		$group = array_pop($parts);
160		$parts = explode('::', $permission);
161
162		// If it does not exist, we are authorized.
163		if (!in_array($end, (array)$this->config->get($parts[0] . '::permissions.' . $group))) {
164		return true;
165		}
166		} elseif (ends_with($permission, '*')) {
167		$parts = explode('::', $permission);
168
169		$addon = array_shift($parts);
170
171		/*
172		* Check vendor.module.slug::group.*
173		* then check vendor.module.slug::*
174		*/
175		if (str_is('..::..', $permission)) {
176		$end = trim(substr($permission, strpos($permission, '::') + 2), '.*');
177
178		if (!$permissions = $this->config->get($addon . '::permissions.' . $end)) {
179		return true;
180		} else {
181		return $user->hasAnyPermission($permissions);
182		}
183		} elseif (str_is('..::.*', $permission)) {
184		$end = trim(substr($permission, strpos($permission, '::') + 2), '.*');
185
186	View Code Duplication	if (!$permissions = $this->config->get($addon . '::permissions.' . $end)) {
		0 ignored issues – show Duplication introduced 2016-04-22 19:08 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
187		return true;
188		} else {
189		$check = [];
190
191		foreach ($permissions as &$permission) {
192		$check[] = $addon . '::' . $end . '.' . $permission;
193		}
194
195		return $user->hasAnyPermission($check);
196		}
197	View Code Duplication	} else {
		0 ignored issues – show Duplication introduced 2016-04-22 19:08 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
198		if (!$permissions = $this->config->get($addon . '::permissions')) {
199		return true;
200		} else {
201		$check = [];
202
203		foreach ($permissions as $group => &$permission) {
204		foreach ($permission as $access) {
205		$check[] = $addon . '::' . $group . '.' . $access;
206		}
207		}
208
209		return $user->hasAnyPermission($check);
210		}
211		}
212		} else {
213		$parts = explode('::', $permission);
214
215		$end = array_pop($parts);
216
217		if (!in_array($end, (array)$this->config->get($parts[0] . '::permissions'))) {
218		return true;
219		}
220		}
221
222		// Check if the user actually has permission.
223		if (!$user \|\| !$user->hasPermission($permission)) {
224		return false;
225		}
226
227		return true;
228		}
229
230		/**
231		* Get the guest role.
232		*
233		* @return RoleInterface
234		*/
235		public function getGuest()
236		{
237		return $this->guest;
238		}
239
240		/**
241		* Set the guest role.
242		*
243		* @param RoleInterface $guest
244		* @return $this
245		*/
246		public function setGuest(RoleInterface $guest)
247		{
248		$this->guest = $guest;
249
250		return $this;
251		}
252		}
253

anomalylabs / streams-platform

Push — master ( 7e2d40...45edf2 )

Authorizer::checkPermission() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like