ButtonNormalizer::process() - Code Metrics - anomalylabs/streams-platform - Measure and Improve Code Quality continuously with Scrutinizer

ButtonNormalizer::process() F
last analyzed 2017-05-11 19:17 UTC

↳ Parent: ButtonNormalizer

Complexity

Conditions	14
Paths	384

Size

Total Lines	76
Code Lines	25

Duplication

Lines	76
Ratio	100 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	14
eloc	25
c	2
b	0
f	0
nc	384
nop	2
dl	76
loc	76
rs	3.9629

How to fix Long Method Complexity

<?php namespace Anomaly\Streams\Platform\Ui\Form\Component\Button;

use Anomaly\Streams\Platform\Ui\Form\FormBuilder;

/**
 * Class ButtonNormalizer
 *
 * @link   http://pyrocms.com/
 * @author PyroCMS, Inc. <[email protected]>
 * @author Ryan Thompson <[email protected]>
 */
class ButtonNormalizer

{

    /**
     * Normalize button input.
     *
     * @param FormBuilder $builder
     */
    public function normalize(FormBuilder $builder)
    {
        $buttons = $builder->getButtons();

        foreach ($buttons as $key => &$button) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $button = $this->process($key, $button);
        }

        $builder->setButtons($buttons);
    }

    /**
     * Process a button.
     *
     * @param $key
     * @param $button
     * @return array|string
     */
    protected function process($key, $button)
    {
        /*
         * If the button is a string then use
         * it as the button parameter.
         */
        if (is_string($button)) {
            $button = [
                'button' => $button,
            ];
        }

        /*
         * If the key is a string and the button
         * is an array without a button param then
         * move the key into the button as that param.
         */
        if (!is_integer($key) && !isset($button['button'])) {
            $button['button'] = $key;
        }

        /**
         * Default to size "sm"
         */
        if (!isset($button['size'])) {
            $button['size'] = 'sm';
        }

        /*
         * Make sure some default parameters exist.
         */
        $button['attributes'] = array_get($button, 'attributes', []);

        /*
         * Move the HREF if any to the attributes.
         */
        if (isset($button['href'])) {
            array_set($button['attributes'], 'href', array_pull($button, 'href'));
        }

        /*
         * Move the target if any to the attributes.
         */
        if (isset($button['target'])) {
            array_set($button['attributes'], 'target', array_pull($button, 'target'));
        }

        /*
         * Move all data-* keys
         * to attributes.
         */
        foreach ($button as $attribute => $value) {
            if (str_is('data-*', $attribute)) {
                array_set($button, 'attributes.' . $attribute, array_pull($button, $attribute));
            }
        }

        /*
         * Make sure the HREF is absolute.
         */
        if (
            isset($button['attributes']['href']) &&
            is_string($button['attributes']['href']) &&
            !starts_with($button['attributes']['href'], ['http', '{'])
        ) {
            $button['attributes']['href'] = url($button['attributes']['href']);
        }

        if (isset($button['dropdown'])) {
            foreach ($button['dropdown'] as $key => &$dropdown) {
                $dropdown = $this->process($key, $dropdown);
            }
        }

        return $button;
    }
}


1		<?php namespace Anomaly\Streams\Platform\Ui\Form\Component\Button;
2
3		use Anomaly\Streams\Platform\Ui\Form\FormBuilder;
4
5		/**
6		* Class ButtonNormalizer
7		*
8		* @link http://pyrocms.com/
9		* @author PyroCMS, Inc. <[email protected]>
10		* @author Ryan Thompson <[email protected]>
11		*/
12	View Code Duplication	class ButtonNormalizer
		0 ignored issues – show Duplication introduced 2017-03-26 03:54 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14
15		/**
16		* Normalize button input.
17		*
18		* @param FormBuilder $builder
19		*/
20		public function normalize(FormBuilder $builder)
21		{
22		$buttons = $builder->getButtons();
23
24		foreach ($buttons as $key => &$button) {
		0 ignored issues – show Bug introduced 2016-04-22 19:08 UTC by Report Bug Copy Issue Report The expression `$buttons` of type `array\|string` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
25		$button = $this->process($key, $button);
26		}
27
28		$builder->setButtons($buttons);
29		}
30
31		/**
32		* Process a button.
33		*
34		* @param $key
35		* @param $button
36		* @return array\|string
37		*/
38		protected function process($key, $button)
39		{
40		/*
41		* If the button is a string then use
42		* it as the button parameter.
43		*/
44		if (is_string($button)) {
45		$button = [
46		'button' => $button,
47		];
48		}
49
50		/*
51		* If the key is a string and the button
52		* is an array without a button param then
53		* move the key into the button as that param.
54		*/
55		if (!is_integer($key) && !isset($button['button'])) {
56		$button['button'] = $key;
57		}
58
59		/**
60		* Default to size "sm"
61		*/
62		if (!isset($button['size'])) {
63		$button['size'] = 'sm';
64		}
65
66		/*
67		* Make sure some default parameters exist.
68		*/
69		$button['attributes'] = array_get($button, 'attributes', []);
70
71		/*
72		* Move the HREF if any to the attributes.
73		*/
74		if (isset($button['href'])) {
75		array_set($button['attributes'], 'href', array_pull($button, 'href'));
76		}
77
78		/*
79		* Move the target if any to the attributes.
80		*/
81		if (isset($button['target'])) {
82		array_set($button['attributes'], 'target', array_pull($button, 'target'));
83		}
84
85		/*
86		* Move all data-* keys
87		* to attributes.
88		*/
89		foreach ($button as $attribute => $value) {
90		if (str_is('data-*', $attribute)) {
91		array_set($button, 'attributes.' . $attribute, array_pull($button, $attribute));
92		}
93		}
94
95		/*
96		* Make sure the HREF is absolute.
97		*/
98		if (
99		isset($button['attributes']['href']) &&
100		is_string($button['attributes']['href']) &&
101		!starts_with($button['attributes']['href'], ['http', '{'])
102		) {
103		$button['attributes']['href'] = url($button['attributes']['href']);
104		}
105
106		if (isset($button['dropdown'])) {
107		foreach ($button['dropdown'] as $key => &$dropdown) {
108		$dropdown = $this->process($key, $dropdown);
109		}
110		}
111
112		return $button;
113		}
114		}
115

anomalylabs / streams-platform

ButtonNormalizer::process() F last analyzed 2017-05-11 19:17 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like

ButtonNormalizer::process() F
last analyzed 2017-05-11 19:17 UTC