Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php namespace Anomaly\SettingsModule\Setting\Command; |
||
14 | View Code Duplication | class GetSetting implements SelfHandling |
|
|
|||
15 | { |
||
16 | |||
17 | /** |
||
18 | * The setting key. |
||
19 | * |
||
20 | * @var string |
||
21 | */ |
||
22 | protected $key; |
||
23 | |||
24 | /** |
||
25 | * The default value. |
||
26 | * |
||
27 | * @var mixed |
||
28 | */ |
||
29 | protected $default; |
||
30 | |||
31 | /** |
||
32 | * Create a new GetSetting instance. |
||
33 | * |
||
34 | * @param $key |
||
35 | * @param null $default |
||
36 | */ |
||
37 | public function __construct($key, $default = null) |
||
42 | |||
43 | /** |
||
44 | * Handle the command. |
||
45 | * |
||
46 | * @param SettingRepositoryInterface $settings |
||
47 | * @return mixed |
||
48 | */ |
||
49 | public function handle(SettingRepositoryInterface $settings) |
||
53 | } |
||
54 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.