ApcuStore::get() - Code Metrics - Inspection of "Added ApcuStore as Redis alternative" - ankitpokhrel/tus-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#212)

by Ankit

created 2019-11-28 21:35 UTC

ApcuStore::get() A

↳ Parent: ApcuStore

Complexity

Conditions	5
Paths	3

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	5

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	5
c	1
b	0
f	0
nc	3
nop	2
dl	0
loc	11
ccs	6
cts	6
cp	1
crap	5
rs	9.6111

<?php

namespace TusPhp\Cache;

use Carbon\Carbon;
use APCUIterator;

class ApcuStore extends AbstractCache
{

    /**
     * {@inheritDoc}
     */
    public function get(string $key, bool $withExpired = false)
    {
        $contents = apcu_fetch($this->getActualCacheKey($key)) ?: null;

        if ($withExpired) {
            return $contents ?: null;
        }

        $isExpired = Carbon::parse($contents['expires_at'])->lt(Carbon::now());

        return $isExpired ? null : $contents;
    }

    /**
     * {@inheritDoc}
     */
    public function set(string $key, $value)
    {
        $contents = $this->get($key) ?: [];

        if (\is_array($value)) {
            $contents = $value + $contents;
        } else {
            array_push($contents, $value);
        }

        return apcu_store($this->getActualCacheKey($key), $contents, $this->getTtl());
    }

    /**
     * {@inheritDoc}
     */
    public function delete(string $key): bool
    {
        return apcu_delete($this->getActualCacheKey($key));

    }

    /**
     * {@inheritDoc}
     */
    public function keys(): array
    {
        $iterator = new APCUIterator('/^' . preg_quote($this->getPrefix()) . '.*$/', APC_ITER_KEY);
        return array_column(iterator_to_array($iterator, false), 'key');
    }

    /**
     * Get actual cache key with prefix.
     *
     * @param string $key
     *
     * @return string
     */
    protected function getActualCacheKey(string $key): string
    {
        $prefix = $this->getPrefix();

        if (false === strpos($key, $prefix)) {
            $key = $prefix . $key;
        }

        return $key;
    }
}


1		<?php
2
3		namespace TusPhp\Cache;
4
5		use Carbon\Carbon;
6		use APCUIterator;
7
8		class ApcuStore extends AbstractCache
9		{
10
11		/**
12		* {@inheritDoc}
13		*/
14	7	public function get(string $key, bool $withExpired = false)
15		{
16	7	$contents = apcu_fetch($this->getActualCacheKey($key)) ?: null;
17
18	7	if ($withExpired) {
19	1	return $contents ?: null;
20		}
21
22	7	$isExpired = Carbon::parse($contents['expires_at'])->lt(Carbon::now());
23
24	7	return $isExpired ? null : $contents;
25		}
26
27		/**
28		* {@inheritDoc}
29		*/
30	4	public function set(string $key, $value)
31		{
32	4	$contents = $this->get($key) ?: [];
33
34	4	if (\is_array($value)) {
35	4	$contents = $value + $contents;
36		} else {
37	1	array_push($contents, $value);
38		}
39
40	4	return apcu_store($this->getActualCacheKey($key), $contents, $this->getTtl());
41		}
42
43		/**
44		* {@inheritDoc}
45		*/
46	2	public function delete(string $key): bool
47		{
48	2	return apcu_delete($this->getActualCacheKey($key));
		0 ignored issues – show Bug Best Practice introduced 2019-11-26 13:32 UTC by Report Bug Copy Issue Report The expression `return apcu_delete($this...etActualCacheKey($key))` could return the type `string[]` which is incompatible with the type-hinted return `boolean`. Consider adding an additional type-check to rule them out. Loading history...
49		}
50
51		/**
52		* {@inheritDoc}
53		*/
54	1	public function keys(): array
55		{
56	1	$iterator = new APCUIterator('/^' . preg_quote($this->getPrefix()) . '.*$/', APC_ITER_KEY);
57	1	return array_column(iterator_to_array($iterator, false), 'key');
58		}
59
60		/**
61		* Get actual cache key with prefix.
62		*
63		* @param string $key
64		*
65		* @return string
66		*/
67	7	protected function getActualCacheKey(string $key): string
68		{
69	7	$prefix = $this->getPrefix();
70
71	7	if (false === strpos($key, $prefix)) {
72	7	$key = $prefix . $key;
73		}
74
75	7	return $key;
76		}
77		}
78

ankitpokhrel / tus-php

Pull Request — master (#212)

ApcuStore::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like