Complex classes like Dynamic_Featured_Image often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Dynamic_Featured_Image, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 48 | class Dynamic_Featured_Image { |
||
| 49 | /** |
||
| 50 | * Current version of the plugin. |
||
| 51 | * |
||
| 52 | * @since 3.0.0 |
||
| 53 | */ |
||
| 54 | const VERSION = '3.5.2'; |
||
| 55 | |||
| 56 | /** |
||
| 57 | * Image upload directory. |
||
| 58 | * |
||
| 59 | * @var $__upload_dir string |
||
| 60 | */ |
||
| 61 | private $__upload_dir; |
||
| 62 | |||
| 63 | /** |
||
| 64 | * Image upload URL. |
||
| 65 | * |
||
| 66 | * @var $__upload_url string |
||
| 67 | */ |
||
| 68 | private $__upload_url; |
||
| 69 | |||
| 70 | /** |
||
| 71 | * Database object. |
||
| 72 | * |
||
| 73 | * @var $__db wpdb |
||
| 74 | */ |
||
| 75 | private $__db; |
||
| 76 | |||
| 77 | /** |
||
| 78 | * Plugin text domain. |
||
| 79 | * |
||
| 80 | * @var $_textDomain string |
||
| 81 | */ |
||
| 82 | protected $_textDomain; |
||
| 83 | |||
| 84 | /** |
||
| 85 | * Title for dfi metabox. |
||
| 86 | * |
||
| 87 | * @var $_metabox string |
||
| 88 | */ |
||
| 89 | protected $_metabox_title; |
||
| 90 | |||
| 91 | /** |
||
| 92 | * Users post type filter for dfi metabox. |
||
| 93 | * |
||
| 94 | * @var $_userFilter array |
||
| 95 | */ |
||
| 96 | protected $_userFilter; |
||
| 97 | |||
| 98 | /** |
||
| 99 | * Constructor. Hooks all interactions to initialize the class. |
||
| 100 | * |
||
| 101 | * @since 1.0.0 |
||
| 102 | * @access public |
||
| 103 | * @global object $wpdb |
||
| 104 | * |
||
| 105 | * @see add_action() |
||
| 106 | */ |
||
| 107 | public function __construct() { |
||
| 143 | |||
| 144 | /** |
||
| 145 | * Return site protocol. |
||
| 146 | * |
||
| 147 | * @since 3.5.1 |
||
| 148 | * @access public |
||
| 149 | * |
||
| 150 | * @return string |
||
| 151 | */ |
||
| 152 | private function __get_protocol() { |
||
| 156 | |||
| 157 | /** |
||
| 158 | * Add required admin scripts. |
||
| 159 | * |
||
| 160 | * @since 1.0.0 |
||
| 161 | * @access public |
||
| 162 | * |
||
| 163 | * @see wp_enque_style() |
||
| 164 | * @see wp_register_script() |
||
| 165 | * @see wp_enqueue_script() |
||
| 166 | * |
||
| 167 | * @return void |
||
| 168 | */ |
||
| 169 | public function enqueue_admin_scripts() { |
||
| 192 | |||
| 193 | /** |
||
| 194 | * Add upgrade link. |
||
| 195 | * |
||
| 196 | * @access public |
||
| 197 | * @since 3.5.1 |
||
| 198 | * @action plugin_action_links |
||
| 199 | * |
||
| 200 | * @codeCoverageIgnore |
||
| 201 | * |
||
| 202 | * @param array $links Action links. |
||
| 203 | * |
||
| 204 | * @return array |
||
| 205 | */ |
||
| 206 | public function dfi_action_links( $links ) { |
||
| 213 | |||
| 214 | /** |
||
| 215 | * Add featured meta boxes dynamically. |
||
| 216 | * |
||
| 217 | * @since 1.0.0 |
||
| 218 | * @access public |
||
| 219 | * @global object $post |
||
| 220 | * |
||
| 221 | * @see get_post_meta() |
||
| 222 | * @see get_post_types() |
||
| 223 | * @see add_meta_box() |
||
| 224 | * @see add_filter() |
||
| 225 | * |
||
| 226 | * @return void |
||
| 227 | */ |
||
| 228 | public function initialize_featured_box() { |
||
| 256 | |||
| 257 | /** |
||
| 258 | * Translates more than one digit number digit by digit. |
||
| 259 | * |
||
| 260 | * @param int $number Integer to be translated. |
||
| 261 | * |
||
| 262 | * @return string Translated number |
||
| 263 | */ |
||
| 264 | protected function _get_number_translation( $number ) { |
||
| 277 | |||
| 278 | /** |
||
| 279 | * Adds meta boxes. |
||
| 280 | * |
||
| 281 | * @param array $postTypes Post types to show featured image box. |
||
| 282 | * @param object $featured Callback arguments. |
||
| 283 | * @param int $i Index of the featured image. |
||
| 284 | * |
||
| 285 | * @return void |
||
| 286 | */ |
||
| 287 | private function _dfi_add_meta_box( $postTypes, $featured = null, $i = null ) { |
||
| 316 | |||
| 317 | /** |
||
| 318 | * Separate thumb and full image url from given URL string. |
||
| 319 | * |
||
| 320 | * @since 3.3.1 |
||
| 321 | * |
||
| 322 | * @param string $urlString Url string. |
||
| 323 | * @param string $state Thumb or full. |
||
| 324 | * |
||
| 325 | * @return string|null |
||
| 326 | */ |
||
| 327 | private function _separate( $urlString, $state = 'thumb' ) { |
||
| 336 | |||
| 337 | /** |
||
| 338 | * Create a nonce field |
||
| 339 | * |
||
| 340 | * @since 3.5.0 |
||
| 341 | * |
||
| 342 | * @see wp_nonce_field() |
||
| 343 | * @see plugin_basename() |
||
| 344 | * |
||
| 345 | * @codeCoverageIgnore |
||
| 346 | * |
||
| 347 | * @param string $key Nonce key. |
||
| 348 | * |
||
| 349 | * @return string |
||
| 350 | */ |
||
| 351 | protected function _nonce_field( $key ) { |
||
| 354 | |||
| 355 | /** |
||
| 356 | * Featured meta box as seen in the admin |
||
| 357 | * |
||
| 358 | * @since 1.0.0 |
||
| 359 | * @access public |
||
| 360 | * |
||
| 361 | * @param object $post Global post object. |
||
| 362 | * @param array $featured Array containing featured image count. |
||
| 363 | * |
||
| 364 | * @throws Exception Medium size image not found. |
||
| 365 | * @return void |
||
| 366 | */ |
||
| 367 | public function featured_meta_box( $post, $featured ) { |
||
| 394 | |||
| 395 | /** |
||
| 396 | * Returns featured box html content. |
||
| 397 | * |
||
| 398 | * @since 3.1.0 |
||
| 399 | * @access private |
||
| 400 | * |
||
| 401 | * @param string $featuredImgTrimmed Medium sized image. |
||
| 402 | * @param string $featuredImg Full sized image. |
||
| 403 | * @param string $featuredId Attachment Id. |
||
| 404 | * @param string $thumbnail Thumb sized image. |
||
| 405 | * |
||
| 406 | * @return string Html content |
||
| 407 | */ |
||
| 408 | private function _get_featured_box( $featuredImgTrimmed, $featuredImg, $featuredId, $thumbnail, $postId ) { |
||
| 422 | |||
| 423 | /** |
||
| 424 | * Load new featured meta box via ajax |
||
| 425 | * |
||
| 426 | * @since 1.0.0 |
||
| 427 | * @access public |
||
| 428 | * |
||
| 429 | * @return void |
||
| 430 | */ |
||
| 431 | public function ajax_callback() { |
||
| 456 | |||
| 457 | /** |
||
| 458 | * Add custom class 'featured-meta-box' to meta box. |
||
| 459 | * |
||
| 460 | * @since 1.0.0 |
||
| 461 | * @access public |
||
| 462 | * |
||
| 463 | * @see add_metabox_classes |
||
| 464 | * |
||
| 465 | * @param array $classes Classes to add in the meta box. |
||
| 466 | * |
||
| 467 | * @return array |
||
| 468 | */ |
||
| 469 | public function add_metabox_classes( $classes ) { |
||
| 474 | |||
| 475 | /** |
||
| 476 | * Add custom fields in media uploader. |
||
| 477 | * |
||
| 478 | * @since 3.4.0 |
||
| 479 | * |
||
| 480 | * @param array $form_fields Fields to include in media attachment form. |
||
| 481 | * @param array $post Post data. |
||
| 482 | * |
||
| 483 | * @return array |
||
| 484 | */ |
||
| 485 | public function media_attachment_custom_fields( $form_fields, $post ) { |
||
| 494 | |||
| 495 | /** |
||
| 496 | * Save values of media uploader custom fields. |
||
| 497 | * |
||
| 498 | * @since 3.4.0 |
||
| 499 | * |
||
| 500 | * @param array $post Post data for database. |
||
| 501 | * @param array $attachment Attachment fields from $_POST form. |
||
| 502 | * |
||
| 503 | * @return array |
||
| 504 | */ |
||
| 505 | public function media_attachment_custom_fields_save( $post, $attachment ) { |
||
| 512 | |||
| 513 | /** |
||
| 514 | * Update featured images in the database. |
||
| 515 | * |
||
| 516 | * @since 1.0.0 |
||
| 517 | * @access public |
||
| 518 | * |
||
| 519 | * @see plugin_basename() |
||
| 520 | * @see update_post_meta() |
||
| 521 | * @see current_user_can() |
||
| 522 | * |
||
| 523 | * @param int $post_id Current post id. |
||
| 524 | * |
||
| 525 | * @return bool |
||
| 526 | */ |
||
| 527 | public function save_meta( $post_id ) { |
||
| 542 | |||
| 543 | /** |
||
| 544 | * Verify metabox nonces. |
||
| 545 | * |
||
| 546 | * @access protected |
||
| 547 | * @see wp_verify_nonce() |
||
| 548 | * |
||
| 549 | * @return bool |
||
| 550 | */ |
||
| 551 | protected function _verify_nonces() { |
||
| 564 | |||
| 565 | /** |
||
| 566 | * Add update notice. Displayed in plugin update page. |
||
| 567 | * |
||
| 568 | * @since 2.0.0 |
||
| 569 | * @access public |
||
| 570 | * |
||
| 571 | * @return void |
||
| 572 | */ |
||
| 573 | public function update_notice() { |
||
| 577 | |||
| 578 | /** |
||
| 579 | * Execute query. |
||
| 580 | * |
||
| 581 | * @param string $query Query to execute. |
||
| 582 | * |
||
| 583 | * @return null|string |
||
| 584 | */ |
||
| 585 | private function execute_query( $query ) { |
||
| 588 | |||
| 589 | /** |
||
| 590 | * Get attachment id of the image by image url. |
||
| 591 | * |
||
| 592 | * @since 3.1.7 |
||
| 593 | * @access protected |
||
| 594 | * @global object $wpdb |
||
| 595 | * |
||
| 596 | * @param string $image_url URL of an image. |
||
| 597 | * |
||
| 598 | * @return string |
||
| 599 | */ |
||
| 600 | protected function _get_attachment_id( $image_url ) { |
||
| 603 | |||
| 604 | /** |
||
| 605 | * Get image url of the image by attachment id. |
||
| 606 | * |
||
| 607 | * @since 2.0.0 |
||
| 608 | * @access public |
||
| 609 | * |
||
| 610 | * @see wp_get_attachment_image_src() |
||
| 611 | * |
||
| 612 | * @param int $attachment_id attachment id of an image. |
||
| 613 | * @param string $size size of the image to fetch (thumbnail, medium, full). |
||
| 614 | * |
||
| 615 | * @return string |
||
| 616 | */ |
||
| 617 | public function get_image_url( $attachment_id, $size = 'full' ) { |
||
| 622 | |||
| 623 | /** |
||
| 624 | * Get image thumbnail url of specific size by image url. |
||
| 625 | * |
||
| 626 | * @since 2.0.0 |
||
| 627 | * @access public |
||
| 628 | * |
||
| 629 | * @see get_image_id() |
||
| 630 | * @see wp_get_attachment_image_src() |
||
| 631 | * |
||
| 632 | * @param string $image_url url of an image. |
||
| 633 | * @param string $size size of the image to fetch (thumbnail, medium, full). |
||
| 634 | * |
||
| 635 | * @return string |
||
| 636 | */ |
||
| 637 | public function get_image_thumb( $image_url, $size = 'thumbnail' ) { |
||
| 643 | |||
| 644 | /** |
||
| 645 | * Gets attachment id from given image url. |
||
| 646 | * |
||
| 647 | * @param string $image_url url of an image. |
||
| 648 | * |
||
| 649 | * @since 2.0.0 |
||
| 650 | * @access public |
||
| 651 | * |
||
| 652 | * @return int|null attachment id of an image |
||
| 653 | */ |
||
| 654 | public function get_image_id( $image_url ) { |
||
| 668 | |||
| 669 | /** |
||
| 670 | * Get image title. |
||
| 671 | * |
||
| 672 | * @since 2.0.0 |
||
| 673 | * @access public |
||
| 674 | * |
||
| 675 | * @param string $image_url URL of an image. |
||
| 676 | * |
||
| 677 | * @return string |
||
| 678 | */ |
||
| 679 | public function get_image_title( $image_url ) { |
||
| 682 | |||
| 683 | /** |
||
| 684 | * Get image title by id. |
||
| 685 | * |
||
| 686 | * @since 2.0.0 |
||
| 687 | * @access public |
||
| 688 | * |
||
| 689 | * @param int $attachment_id Attachment id of an image. |
||
| 690 | * |
||
| 691 | * @return string |
||
| 692 | */ |
||
| 693 | public function get_image_title_by_id( $attachment_id ) { |
||
| 696 | |||
| 697 | /** |
||
| 698 | * Get image caption. |
||
| 699 | * |
||
| 700 | * @since 2.0.0 |
||
| 701 | * @access public |
||
| 702 | * |
||
| 703 | * @param string $image_url URL of an image. |
||
| 704 | * |
||
| 705 | * @return string |
||
| 706 | */ |
||
| 707 | public function get_image_caption( $image_url ) { |
||
| 710 | |||
| 711 | /** |
||
| 712 | * Get image caption by id. |
||
| 713 | * |
||
| 714 | * @since 2.0.0 |
||
| 715 | * @access public |
||
| 716 | * |
||
| 717 | * @param int $attachment_id Attachment id of an image. |
||
| 718 | * |
||
| 719 | * @return string |
||
| 720 | */ |
||
| 721 | public function get_image_caption_by_id( $attachment_id ) { |
||
| 724 | |||
| 725 | /** |
||
| 726 | * Get image alternate text. |
||
| 727 | * |
||
| 728 | * @since 2.0.0 |
||
| 729 | * @access public |
||
| 730 | * |
||
| 731 | * @see get_post_meta() |
||
| 732 | * |
||
| 733 | * @param string $image_url URL of an image. |
||
| 734 | * |
||
| 735 | * @return string |
||
| 736 | */ |
||
| 737 | public function get_image_alt( $image_url ) { |
||
| 747 | |||
| 748 | /** |
||
| 749 | * Get image alternate text by attachment id. |
||
| 750 | * |
||
| 751 | * @since 2.0.0 |
||
| 752 | * @access public |
||
| 753 | * |
||
| 754 | * @see get_post_meta() |
||
| 755 | * |
||
| 756 | * @param int $attachment_id Attachment id of an image. |
||
| 757 | * |
||
| 758 | * @return string |
||
| 759 | */ |
||
| 760 | public function get_image_alt_by_id( $attachment_id ) { |
||
| 765 | |||
| 766 | /** |
||
| 767 | * Get image description. |
||
| 768 | * |
||
| 769 | * @since 3.0.0 |
||
| 770 | * @access public |
||
| 771 | * |
||
| 772 | * @param string $image_url URL of an image. |
||
| 773 | * |
||
| 774 | * @return string |
||
| 775 | */ |
||
| 776 | public function get_image_description( $image_url ) { |
||
| 779 | |||
| 780 | /** |
||
| 781 | * Get image description by id. |
||
| 782 | * |
||
| 783 | * @since 3.0.0 |
||
| 784 | * @access public |
||
| 785 | * |
||
| 786 | * @param int $attachment_id attachment id of an image. |
||
| 787 | * |
||
| 788 | * @return string |
||
| 789 | */ |
||
| 790 | public function get_image_description_by_id( $attachment_id ) { |
||
| 793 | |||
| 794 | /** |
||
| 795 | * Get link to image. |
||
| 796 | * |
||
| 797 | * @since 3.4.0 |
||
| 798 | * @access public |
||
| 799 | * |
||
| 800 | * @param int $attachment_id Attachment id of an image. |
||
| 801 | * |
||
| 802 | * @return string|null |
||
| 803 | */ |
||
| 804 | public function get_link_to_image( $attachment_id ) { |
||
| 807 | |||
| 808 | /** |
||
| 809 | * Get all attachment ids of the post. |
||
| 810 | * |
||
| 811 | * @since 2.0.0 |
||
| 812 | * @access public |
||
| 813 | * |
||
| 814 | * @see get_post_meta() |
||
| 815 | * |
||
| 816 | * @param int $post_id id of the current post. |
||
| 817 | * |
||
| 818 | * @return array |
||
| 819 | */ |
||
| 820 | public function get_post_attachment_ids( $post_id ) { |
||
| 833 | |||
| 834 | /** |
||
| 835 | * Fetches featured image data of nth position. |
||
| 836 | * |
||
| 837 | * @since 3.0.0 |
||
| 838 | * @access public |
||
| 839 | * |
||
| 840 | * @see get_featured_images() |
||
| 841 | * |
||
| 842 | * @param int $position Position of the featured image. |
||
| 843 | * @param int $post_id Current post id. |
||
| 844 | * |
||
| 845 | * @return array if found, null otherwise. |
||
| 846 | */ |
||
| 847 | public function get_nth_featured_image( $position, $post_id = null ) { |
||
| 857 | |||
| 858 | /** |
||
| 859 | * Check if the image is attached with the particular post. |
||
| 860 | * |
||
| 861 | * @since 2.0.0 |
||
| 862 | * @access public |
||
| 863 | * |
||
| 864 | * @see get_post_attachment_ids() |
||
| 865 | * |
||
| 866 | * @param int $attachment_id Attachment id of an image. |
||
| 867 | * @param int $post_id Current post id. |
||
| 868 | * |
||
| 869 | * @return bool |
||
| 870 | */ |
||
| 871 | public function is_attached( $attachment_id, $post_id ) { |
||
| 880 | |||
| 881 | /** |
||
| 882 | * Retrieve featured images for specific post(s). |
||
| 883 | * |
||
| 884 | * @since 2.0.0 |
||
| 885 | * @access public |
||
| 886 | * |
||
| 887 | * @see get_post_meta() |
||
| 888 | * |
||
| 889 | * @param integer $post_id id of the current post. |
||
| 890 | * |
||
| 891 | * @return array |
||
| 892 | */ |
||
| 893 | public function get_featured_images( $post_id = null ) { |
||
| 925 | |||
| 926 | /** |
||
| 927 | * Check to see if the upload url is already available in path. |
||
| 928 | * |
||
| 929 | * @since 3.1.14 |
||
| 930 | * @access protected |
||
| 931 | * |
||
| 932 | * @param string $img Uploaded image. |
||
| 933 | * |
||
| 934 | * @return string |
||
| 935 | */ |
||
| 936 | protected function _get_real_upload_path( $img ) { |
||
| 944 | |||
| 945 | /** |
||
| 946 | * Retrieve featured images for specific post(s) including the default Featured Image. |
||
| 947 | * |
||
| 948 | * @since 3.1.7 |
||
| 949 | * @access public |
||
| 950 | * |
||
| 951 | * @see $this->get_featured_images() |
||
| 952 | * |
||
| 953 | * @param int $post_id Current post id. |
||
| 954 | * |
||
| 955 | * @return array An array of images or an empty array on failure |
||
| 956 | */ |
||
| 957 | public function get_all_featured_images( $post_id = null ) { |
||
| 981 | |||
| 982 | /** |
||
| 983 | * Load the plugin's textdomain hooked to 'plugins_loaded'. |
||
| 984 | * |
||
| 985 | * @since 1.0.0 |
||
| 986 | * @access public |
||
| 987 | * |
||
| 988 | * @see load_plugin_textdomain() |
||
| 989 | * @see plugin_basename() |
||
| 990 | * @action plugins_loaded |
||
| 991 | * |
||
| 992 | * @codeCoverageIgnore |
||
| 993 | * |
||
| 994 | * @return void |
||
| 995 | */ |
||
| 996 | public function load_plugin_textdomain() { |
||
| 1003 | } |
||
| 1004 | |||
| 1015 |
Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: