ankitjain28may / registration-module

source/Login.php

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 26 and the first side effect is on line 15.

/**
 * Login Class Doc Comment
 *
 * PHP version 5
 *
 * @category PHP
 * @package  Registration-Module
 * @author   Ankit Jain <ankitjain28may77@gmail.com>
 * @license  The MIT License (MIT)
 * @link     https://github.com/ankitjain28may/registration-module
 */
namespace AnkitJain\RegistrationModule;
use AnkitJain\RegistrationModule\Session;
require_once dirname(__DIR__) . '/config/database.php';

/**
 * For Login the User
 *
 * @category PHP
 * @package  Registration-Module
 * @author   Ankit Jain <ankitjain28may77@gmail.com>
 * @license  The MIT License (MIT)
 * @link     https://github.com/ankitjain28may/registration-module
 */
class Login
{
    /*
    |--------------------------------------------------------------------------
    | Login Class
    |--------------------------------------------------------------------------
    |
    | For Login.
    |
    */

    protected $flag;
    protected $error;
    protected $connect;

    /**
     * Create a new controller instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct()
    {
        $this->flag = 0;
        $this->connect = mysqli_connect(DB_HOST, DB_USER, DB_PASSWORD, DB_NAME);
        $this->error = array();
    }

    /**
     * Credentials check for allowing user to login
     *
     * @param array $data Contains the User Credentials
     *
     * @return json
     */
    public function authLogin($data)
    {
         $data = $this->emptyValue($data);

         $login = $data["login"];
         $password = $data["passLogin"];

        if (preg_match("/^.+[@]{1}.+$/", $login)) {
            if (filter_var($login, FILTER_VALIDATE_EMAIL) == false) {
                $this->onError("login", " *Enter correct Email address");
            }
        }

        if ($this->flag == 0) {
            $password = md5($password);
            $query = "
            	SELECT * FROM login WHERE email = '$login' or username = '$login'
            ";
            if ($result = $this->connect->query($query)) {
                if ($result->num_rows > 0) {

                    $row = $result->fetch_assoc();
                    $loginID = $row['login_id'];
                    $query = "
                    	SELECT id FROM register WHERE
                    	id = '$loginID' and
                    	password = '$password'
                    ";
                    if ($result = $this->connect->query($query)) {
                        if ($result->num_rows > 0) {
                            Session::put('start', $loginID);
                            return json_encode(
                                [
                                "location" => URL . "/account.php"
                                ]
                            );
                        }
                        $this->onError("passLogin", " *Invalid password");
                        return json_encode($this->error);
                    }
                    return json_encode(
                        [
                        "Error" => "You are not registered, " . $this->connect->error
                        ]
                    );
                }
                $this->onError("login", " *Invalid username or email");
                return json_encode($this->error);
            }
            return json_encode(
                [
                "Error" => "You are not registered, " . $this->connect->error
                ]
            );
        } else {
            return json_encode($this->error);
        }
    }

    /**
     * For generating Error array by key value pair
     *
     * @param string $key   Contains key
     * @param string $value Contains the Value for the key
     *
     * @return void
     */
    public function onError($key, $value)

This method seems to be duplicated in your project.

    {
        $this->flag = 1;
        $this->error = array_merge(
            $this->error,
            [
            [
            "key" => $key,
            "value" => $value
            ]
            ]
        );
    }

    /**
     * For checking whether the credentials are empty or not
     *
     * @param array $data Contains the Credentials
     *
     * @return array
     */
    public function emptyValue($data)
    {
        $errorCode = array(
            "login" => " *Enter the login field",
            "passLogin" => " *Enter the password"
        );

        foreach ($data as $key => $value) {

This code seems to be duplicated across your project.

            $data[$key] = trim($data[$key]);
            $value = trim($value);
            if (empty($value)) {
                $this->onError($key, $errorCode[$key]);
            }
        }
        return $data;
    }
}