Session - Code Metrics - ankitjain28may/registration-module - Measure and Improve Code Quality continuously with Scrutinizer

Session A
last analyzed 2017-01-24 20:07 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
wmc	4
lcom	0
cbo	0
dl	0
loc	48
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	put()	4	1
A	get()	4	2
A	forget()	4	1

<?php

/**
 * Session Class Doc Comment
 *
 * PHP version 5
 *
 * @category PHP
 * @package  Registration-Module
 * @author   Ankit Jain <[email protected]>
 * @license  The MIT License (MIT)
 * @link     https://github.com/ankitjain28may/registration-module
 */

namespace AnkitJain\RegistrationModule;
@session_start();
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

/**
 * For getting the Session values
 *
 * @category PHP
 * @package  Registration-Module
 * @author   Ankit Jain <[email protected]>
 * @license  The MIT License (MIT)
 * @link     https://github.com/ankitjain28may/registration-module
 */

class Session
{
    /*
    |--------------------------------------------------------------------------
    | Session Class
    |--------------------------------------------------------------------------
    |
    | For Manipulation with Sessions.
    |
    */

    /**
     * For generating Session with the key
     *
     * @param string $key   Contains key
     * @param string $value Contains the Value for the key
     *
     * @return void
     */
    public static function put($key, $value)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $_SESSION[$key] = $value;
    }

    /**
     * For getting Session value
     *
     * @param string $key Contains key
     *
     * @return string | null
     */
    public static function get($key)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return (isset($_SESSION[$key]) ? $_SESSION[$key] : null);
    }

    /**
     * For unsetting Session key
     *
     * @param string $key Contains key
     *
     * @return void
     */
    public static function forget($key)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        unset($_SESSION[$key]);
    }
}


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-01 14:29 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 27 and the first side effect is on line 15. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/**
3			* Session Class Doc Comment
4			*
5			* PHP version 5
6			*
7			* @category PHP
8			* @package Registration-Module
9			* @author Ankit Jain <[email protected]>
10			* @license The MIT License (MIT)
11			* @link https://github.com/ankitjain28may/registration-module
12			*/
13
14			namespace AnkitJain\RegistrationModule;
15			@session_start();
			0 ignored issues – show Security Best Practice introduced 2017-01-01 14:29 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
16
17			/**
18			* For getting the Session values
19			*
20			* @category PHP
21			* @package Registration-Module
22			* @author Ankit Jain <[email protected]>
23			* @license The MIT License (MIT)
24			* @link https://github.com/ankitjain28may/registration-module
25			*/
26
27			class Session
28			{
29			/*
30			\|--------------------------------------------------------------------------
31			\| Session Class
32			\|--------------------------------------------------------------------------
33			\|
34			\| For Manipulation with Sessions.
35			\|
36			*/
37
38			/**
39			* For generating Session with the key
40			*
41			* @param string $key Contains key
42			* @param string $value Contains the Value for the key
43			*
44			* @return void
45			*/
46			public static function put($key, $value)
			0 ignored issues – show Coding Style introduced 2017-01-01 14:29 UTC by Report Bug Copy Issue Report `put` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
47			{
48			$_SESSION[$key] = $value;
49			}
50
51			/**
52			* For getting Session value
53			*
54			* @param string $key Contains key
55			*
56			* @return string \| null
57			*/
58			public static function get($key)
			0 ignored issues – show Coding Style introduced 2017-01-01 14:29 UTC by Report Bug Copy Issue Report `get` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
59			{
60			return (isset($_SESSION[$key]) ? $_SESSION[$key] : null);
61			}
62
63			/**
64			* For unsetting Session key
65			*
66			* @param string $key Contains key
67			*
68			* @return void
69			*/
70			public static function forget($key)
			0 ignored issues – show Coding Style introduced 2017-01-01 14:29 UTC by Report Bug Copy Issue Report `forget` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
71			{
72			unset($_SESSION[$key]);
73			}
74			}
75

ankitjain28may / registration-module

Session A last analyzed 2017-01-24 20:07 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like

Session A
last analyzed 2017-01-24 20:07 UTC