Issues in TestAll.php (master) - Issues in master - ankitjain28may/openchat - Measure and Improve Code Quality continuously with Scrutinizer

Issues (90)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/TestAll.php (3 issues)

Labels

Severity

Minor 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace ChatApp\Tests;
use PHPUnit_Framework_TestCase;
use ChatApp\Register;
use ChatApp\Login;
use ChatApp\Search;
use ChatApp\Compose;
use ChatApp\Reply;
use ChatApp\Session;
use ChatApp\SideBar;
use Dotenv\Dotenv;
$dotenv = new Dotenv(dirname(__DIR__));
$dotenv->load();
session_start();

class TestAll
extends
    PHPUnit_Framework_TestCase
{

    protected $obRegister;
    protected $obLogin;

    public function setUp()
    {
        $this->obRegister = new Register();
        $this->obLogin = new Login();
    }

    // Register User 1
    public function testAuthRegister()
    {

        $output = $this->obRegister->authRegister(
            [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                "name" => 'Test',
                "email" => '[email protected]',
                "username" => 'test',
                "mob" => '1234567890',
                "passRegister" => 'testing'
            ]
        );
        $output = (array)json_decode($output);
        $this->assertEquals([
            'location' => 'http://127.0.0.1/openchat/views/account.php'
            ], $output);
        Session::forget('start');
    }

    /**
     * @depends testAuthRegister
     *  Register User2
     */
    public function testAuthRegister2()
    {
        $output = $this->obRegister->authRegister(
            [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                "name" => 'Test2',
                "email" => '[email protected]',
                "username" => 'test2',
                "mob" => '1234567890',
                "passRegister" => 'testing'
            ]
        );

        $output = (array)json_decode($output);
        $this->assertEquals([
            'location' => 'http://127.0.0.1/openchat/views/account.php'
            ], $output);

        $userId = Session::get('start');
        return $userId;
        Session::forget('start');

    }

    /**
     * @depends testAuthRegister2
     *  Testing for the register with empty username
     */
    public function testCompose()
    {
        $expectedOutput = ['location' => 'http://127.0.0.1/openchat/views/account.php'];
        $outputEmail = $this->obLogin->authLogin(
            [
                "login" => '[email protected]',
                "passLogin" => 'testing'
            ]
        );
        $outputEmail = (array)json_decode($outputEmail);
        $this->assertEquals($expectedOutput, $outputEmail);


        $expectedOutput = [
            "Compose" => [
                "0" => (object)[
                    "login_id" => bin2hex(convert_uuencode(2)),
                    "name" => "Test2",
                    "email" => "[email protected]",
                    "username" => "test2",
                    "mobile" => "1234567890",
                    "login_status" => "0"
                ]
            ]
        ];


        $compose = new Compose();
        $userId = Session::get('start');

        // Matched not found
        $output = $compose->selectUser((object)["value" => "ank", "userId" => $userId]);
        $output = (array)json_decode($output);
        $this->assertEquals(["Compose" => "Not Found"], $output);

        // For suggestion matched
        $output = $compose->selectUser((object)["value" => "t", "userId" => $userId]);
        $output = (array)json_decode($output);
        $this->assertEquals($expectedOutput, $output);

        // Not Found
        $output = $compose->selectUser((object)["value" => "", "userId" => $userId]);
        $output = (array)json_decode($output);
        $this->assertEquals(["Compose" => "Not Found"], $output);

        // Query Failed
        $output = $compose->selectUser((object)["value" => "'", "userId" => $userId]);
        $output = (array)json_decode($output);
        $this->assertEquals(["Compose" => "Query Failed"], $output);
        Session::forget('start');

    }

    /**
     * @depends testAuthRegister2
     *  Testing for Search Class
     */
    public function testSearch($userId)
    {
        $expectedOutput = ['location' => 'http://127.0.0.1/openchat/views/account.php'];
        $outputEmail = $this->obLogin->authLogin(
            [
                "login" => '[email protected]',
                "passLogin" => 'testing'
            ]
        );
        $outputEmail = (array)json_decode($outputEmail);
        $this->assertEquals($expectedOutput, $outputEmail);

        $userId = Session::get('start');
        $search = new Search();

        // Matched not found
        $output = $search->searchItem((object)["value" => "ank", "userId" => $userId]);
        $output = (array)json_decode($output);
        $this->assertEquals(["Search" => "Not Found"], $output);

        // For suggestion matched but not in total messages
        $output = $search->searchItem((object)["value" => "T", "userId" => $userId]);
        $output = (array)json_decode($output);
        $this->assertEquals(["Search" => "Not Found"], $output);

        // Not Found
        $output = $search->searchItem((object)["value" => "", "userId" => $userId]);
        $output = (array)json_decode($output);
        $this->assertEquals(["Search" => "Not Found"], $output);

        // Query Failed
        $output = $search->searchItem((object)["value" => "'", "userId" => $userId]);
        $output = (array)json_decode($output);
        $this->assertEquals(["Search" => "Not Found"], $output);
        Session::forget('start');

    }



    /**
     * @depends testAuthRegister2
     *  Testing for Reply Class
     */
    public function testReply($userId)
    {
        $expectedOutput = ['location' => 'http://127.0.0.1/openchat/views/account.php'];
        $outputEmail = $this->obLogin->authLogin(
            [
                "login" => 'test',
                "passLogin" => 'testing'
            ]
        );
        $outputEmail = (array)json_decode($outputEmail);
        $this->assertEquals($expectedOutput, $outputEmail);
        $currentId = Session::get('start');
        Session::forget('start');

        $msg = (object)[
            "name" => $userId,
            "reply" => "Hello World",
            "userId" => $currentId
        ];

        $obReply = new Reply();
        $output = $obReply->replyTo($msg);
        $this->assertEquals("Messages is sent\n", $output);

        $msg = (object)[
            "name" => $currentId,
            "reply" => "Hello World",
            "userId" => $userId
        ];

        $obReply = new Reply();
        $output = $obReply->replyTo($msg);
        $this->assertEquals("Messages is sent\n", $output);

        $output = $obReply->replyTo([]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertEquals("Failed", $output);

        $output = $obReply->replyTo((object)[
            "name" => -1,
            "reply" => "Hello World",
            "userId" => $currentId
        ]);
        $this->assertEquals("Invalid Authentication", $output);

        $output = $obReply->replyTo((object)[
            "name" => $userId,
            "reply" => "Hello",
            "userId" => $currentId
        ]);
        $this->assertEquals("Messages is sent\n", $output);
    }



    /**
     * @depends testReply
     *  Testing for Search Class
     */
    public function testSearchWithTotalMessages()
    {
        $expectedOutput = ['location' => 'http://127.0.0.1/openchat/views/account.php'];
        $outputEmail = $this->obLogin->authLogin(
            [
                "login" => 'test',
                "passLogin" => 'testing'
            ]
        );
        $outputEmail = (array)json_decode($outputEmail);
        $this->assertEquals($expectedOutput, $outputEmail);

        $userId = Session::get('start');
        $search = new Search();


        // For suggestion matched but not in total messages
        $output = $search->searchItem((object)["value" => "T", "userId" => $userId]);
        $output = json_decode($output);
        $this->assertEquals("test2", $output->Search[0]->username);
        Session::forget('start');

    }

    /**
     *  Testing for Search Class
     */
    public function testSidebar()
    {
        $expectedOutput = ['location' => 'http://127.0.0.1/openchat/views/account.php'];
        $outputEmail = $this->obLogin->authLogin(
            [
                "login" => 'test',
                "passLogin" => 'testing'
            ]
        );
        $outputEmail = (array)json_decode($outputEmail);
        $this->assertEquals($expectedOutput, $outputEmail);

        $userId = Session::get('start');
        $sidebar = new SideBar();


        // For suggestion matched but not in total messages
        $output = $sidebar->loadSideBar($userId);
        $output = json_decode($output)[0];

        $this->assertEquals("test2", $output->username);
        $this->assertEquals("Test2", $output->name);
        $this->assertEquals(bin2hex(convert_uuencode(2)), $output->login_id);

        $sidebar = new SideBar();
        $output = $sidebar->loadSideBar('');
        $this->assertEquals("Invalid Authentication", $output);

        $output = $sidebar->loadSideBar('\\');
        $this->assertEquals("Query Failed", $output);

        $output = $sidebar->loadSideBar("100");
        $this->assertEquals("null", $output);

        $sidebar = new SideBar();
        $output = $sidebar->loadSideBar(2);
        $output = json_decode($output)[0];

        $this->assertEquals("test", $output->username);
        $this->assertEquals("Test", $output->name);
        $this->assertEquals(bin2hex(convert_uuencode(1)), $output->login_id);
        Session::forget('start');
    }


    /**
     *   @depends testSidebar
     *  Empty the DB
     */
    public function test_EmptyDB()
    {
        $connect = mysqli_connect(
            getenv('DB_HOST'),
            getenv('DB_USER'),
            getenv('DB_PASSWORD'),
            getenv('DB_NAME')
        );
        $query = "TRUNCATE `login`";
        $this->assertTrue($connect->query($query));
        $query = "TRUNCATE `profile`";
        $this->assertTrue($connect->query($query));
        $query = "TRUNCATE `messages`";
        $this->assertTrue($connect->query($query));
        $query = "TRUNCATE `total_message`";
        $this->assertTrue($connect->query($query));
        $query = "TRUNCATE `register`";
        $this->assertTrue($connect->query($query));
    }

}


1		<?php
2
3		namespace ChatApp\Tests;
4		use PHPUnit_Framework_TestCase;
5		use ChatApp\Register;
6		use ChatApp\Login;
7		use ChatApp\Search;
8		use ChatApp\Compose;
9		use ChatApp\Reply;
10		use ChatApp\Session;
11		use ChatApp\SideBar;
12		use Dotenv\Dotenv;
13		$dotenv = new Dotenv(dirname(__DIR__));
14		$dotenv->load();
15		session_start();
16
17		class TestAll
18		extends
19		PHPUnit_Framework_TestCase
20		{
21
22		protected $obRegister;
23		protected $obLogin;
24
25		public function setUp()
26		{
27		$this->obRegister = new Register();
28		$this->obLogin = new Login();
29		}
30
31		// Register User 1
32	View Code Duplication	public function testAuthRegister()
33		{
34
35		$output = $this->obRegister->authRegister(
36		[
		0 ignored issues – show Documentation introduced 2017-02-13 20:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('name' => 'Test', ...Register' => 'testing')` is of type `array<string,string,{"na...assRegister":"string"}>`, but the function expects a `object`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
37		"name" => 'Test',
38		"email" => '[email protected]',
39		"username" => 'test',
40		"mob" => '1234567890',
41		"passRegister" => 'testing'
42		]
43		);
44		$output = (array)json_decode($output);
45		$this->assertEquals([
46		'location' => 'http://127.0.0.1/openchat/views/account.php'
47		], $output);
48		Session::forget('start');
49		}
50
51		/**
52		* @depends testAuthRegister
53		* Register User2
54		*/
55	View Code Duplication	public function testAuthRegister2()
56		{
57		$output = $this->obRegister->authRegister(
58		[
		0 ignored issues – show Documentation introduced 2017-02-13 20:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('name' => 'Test2',...Register' => 'testing')` is of type `array<string,string,{"na...assRegister":"string"}>`, but the function expects a `object`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
59		"name" => 'Test2',
60		"email" => '[email protected]',
61		"username" => 'test2',
62		"mob" => '1234567890',
63		"passRegister" => 'testing'
64		]
65		);
66
67		$output = (array)json_decode($output);
68		$this->assertEquals([
69		'location' => 'http://127.0.0.1/openchat/views/account.php'
70		], $output);
71
72		$userId = Session::get('start');
73		return $userId;
74		Session::forget('start');
75
76		}
77
78		/**
79		* @depends testAuthRegister2
80		* Testing for the register with empty username
81		*/
82		public function testCompose()
83		{
84		$expectedOutput = ['location' => 'http://127.0.0.1/openchat/views/account.php'];
85		$outputEmail = $this->obLogin->authLogin(
86		[
87		"login" => '[email protected]',
88		"passLogin" => 'testing'
89		]
90		);
91		$outputEmail = (array)json_decode($outputEmail);
92		$this->assertEquals($expectedOutput, $outputEmail);
93
94
95		$expectedOutput = [
96		"Compose" => [
97		"0" => (object)[
98		"login_id" => bin2hex(convert_uuencode(2)),
99		"name" => "Test2",
100		"email" => "[email protected]",
101		"username" => "test2",
102		"mobile" => "1234567890",
103		"login_status" => "0"
104		]
105		]
106		];
107
108
109		$compose = new Compose();
110		$userId = Session::get('start');
111
112		// Matched not found
113		$output = $compose->selectUser((object)["value" => "ank", "userId" => $userId]);
114		$output = (array)json_decode($output);
115		$this->assertEquals(["Compose" => "Not Found"], $output);
116
117		// For suggestion matched
118		$output = $compose->selectUser((object)["value" => "t", "userId" => $userId]);
119		$output = (array)json_decode($output);
120		$this->assertEquals($expectedOutput, $output);
121
122		// Not Found
123		$output = $compose->selectUser((object)["value" => "", "userId" => $userId]);
124		$output = (array)json_decode($output);
125		$this->assertEquals(["Compose" => "Not Found"], $output);
126
127		// Query Failed
128		$output = $compose->selectUser((object)["value" => "'", "userId" => $userId]);
129		$output = (array)json_decode($output);
130		$this->assertEquals(["Compose" => "Query Failed"], $output);
131		Session::forget('start');
132
133		}
134
135		/**
136		* @depends testAuthRegister2
137		* Testing for Search Class
138		*/
139		public function testSearch($userId)
140		{
141		$expectedOutput = ['location' => 'http://127.0.0.1/openchat/views/account.php'];
142		$outputEmail = $this->obLogin->authLogin(
143		[
144		"login" => '[email protected]',
145		"passLogin" => 'testing'
146		]
147		);
148		$outputEmail = (array)json_decode($outputEmail);
149		$this->assertEquals($expectedOutput, $outputEmail);
150
151		$userId = Session::get('start');
152		$search = new Search();
153
154		// Matched not found
155		$output = $search->searchItem((object)["value" => "ank", "userId" => $userId]);
156		$output = (array)json_decode($output);
157		$this->assertEquals(["Search" => "Not Found"], $output);
158
159		// For suggestion matched but not in total messages
160		$output = $search->searchItem((object)["value" => "T", "userId" => $userId]);
161		$output = (array)json_decode($output);
162		$this->assertEquals(["Search" => "Not Found"], $output);
163
164		// Not Found
165		$output = $search->searchItem((object)["value" => "", "userId" => $userId]);
166		$output = (array)json_decode($output);
167		$this->assertEquals(["Search" => "Not Found"], $output);
168
169		// Query Failed
170		$output = $search->searchItem((object)["value" => "'", "userId" => $userId]);
171		$output = (array)json_decode($output);
172		$this->assertEquals(["Search" => "Not Found"], $output);
173		Session::forget('start');
174
175		}
176
177
178
179		/**
180		* @depends testAuthRegister2
181		* Testing for Reply Class
182		*/
183		public function testReply($userId)
184		{
185		$expectedOutput = ['location' => 'http://127.0.0.1/openchat/views/account.php'];
186		$outputEmail = $this->obLogin->authLogin(
187		[
188		"login" => 'test',
189		"passLogin" => 'testing'
190		]
191		);
192		$outputEmail = (array)json_decode($outputEmail);
193		$this->assertEquals($expectedOutput, $outputEmail);
194		$currentId = Session::get('start');
195		Session::forget('start');
196
197		$msg = (object)[
198		"name" => $userId,
199		"reply" => "Hello World",
200		"userId" => $currentId
201		];
202
203		$obReply = new Reply();
204		$output = $obReply->replyTo($msg);
205		$this->assertEquals("Messages is sent\n", $output);
206
207		$msg = (object)[
208		"name" => $currentId,
209		"reply" => "Hello World",
210		"userId" => $userId
211		];
212
213		$obReply = new Reply();
214		$output = $obReply->replyTo($msg);
215		$this->assertEquals("Messages is sent\n", $output);
216
217		$output = $obReply->replyTo([]);
		0 ignored issues – show Documentation introduced 2017-02-13 20:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array()` is of type `array`, but the function expects a `object`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
218		$this->assertEquals("Failed", $output);
219
220		$output = $obReply->replyTo((object)[
221		"name" => -1,
222		"reply" => "Hello World",
223		"userId" => $currentId
224		]);
225		$this->assertEquals("Invalid Authentication", $output);
226
227		$output = $obReply->replyTo((object)[
228		"name" => $userId,
229		"reply" => "Hello",
230		"userId" => $currentId
231		]);
232		$this->assertEquals("Messages is sent\n", $output);
233		}
234
235
236
237		/**
238		* @depends testReply
239		* Testing for Search Class
240		*/
241		public function testSearchWithTotalMessages()
242		{
243		$expectedOutput = ['location' => 'http://127.0.0.1/openchat/views/account.php'];
244		$outputEmail = $this->obLogin->authLogin(
245		[
246		"login" => 'test',
247		"passLogin" => 'testing'
248		]
249		);
250		$outputEmail = (array)json_decode($outputEmail);
251		$this->assertEquals($expectedOutput, $outputEmail);
252
253		$userId = Session::get('start');
254		$search = new Search();
255
256
257		// For suggestion matched but not in total messages
258		$output = $search->searchItem((object)["value" => "T", "userId" => $userId]);
259		$output = json_decode($output);
260		$this->assertEquals("test2", $output->Search[0]->username);
261		Session::forget('start');
262
263		}
264
265		/**
266		* Testing for Search Class
267		*/
268		public function testSidebar()
269		{
270		$expectedOutput = ['location' => 'http://127.0.0.1/openchat/views/account.php'];
271		$outputEmail = $this->obLogin->authLogin(
272		[
273		"login" => 'test',
274		"passLogin" => 'testing'
275		]
276		);
277		$outputEmail = (array)json_decode($outputEmail);
278		$this->assertEquals($expectedOutput, $outputEmail);
279
280		$userId = Session::get('start');
281		$sidebar = new SideBar();
282
283
284		// For suggestion matched but not in total messages
285		$output = $sidebar->loadSideBar($userId);
286		$output = json_decode($output)[0];
287
288		$this->assertEquals("test2", $output->username);
289		$this->assertEquals("Test2", $output->name);
290		$this->assertEquals(bin2hex(convert_uuencode(2)), $output->login_id);
291
292		$sidebar = new SideBar();
293		$output = $sidebar->loadSideBar('');
294		$this->assertEquals("Invalid Authentication", $output);
295
296		$output = $sidebar->loadSideBar('\\');
297		$this->assertEquals("Query Failed", $output);
298
299		$output = $sidebar->loadSideBar("100");
300		$this->assertEquals("null", $output);
301
302		$sidebar = new SideBar();
303		$output = $sidebar->loadSideBar(2);
304		$output = json_decode($output)[0];
305
306		$this->assertEquals("test", $output->username);
307		$this->assertEquals("Test", $output->name);
308		$this->assertEquals(bin2hex(convert_uuencode(1)), $output->login_id);
309		Session::forget('start');
310		}
311
312
313		/**
314		* @depends testSidebar
315		* Empty the DB
316		*/
317		public function test_EmptyDB()
318		{
319		$connect = mysqli_connect(
320		getenv('DB_HOST'),
321		getenv('DB_USER'),
322		getenv('DB_PASSWORD'),
323		getenv('DB_NAME')
324		);
325		$query = "TRUNCATE `login`";
326		$this->assertTrue($connect->query($query));
327		$query = "TRUNCATE `profile`";
328		$this->assertTrue($connect->query($query));
329		$query = "TRUNCATE `messages`";
330		$this->assertTrue($connect->query($query));
331		$query = "TRUNCATE `total_message`";
332		$this->assertTrue($connect->query($query));
333		$query = "TRUNCATE `register`";
334		$this->assertTrue($connect->query($query));
335		}
336
337		}
338

ankitjain28may / openchat

Issues (90)

Security Analysis not enabled

tests/TestAll.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like