Chat::setID() - Code Metrics - Inspection of "Issue #24" - ankitjain28may/openchat - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#30)

unknown

created 2017-10-20 18:40 UTC

Chat::setID() A

↳ Parent: Chat

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	6
nc	1
nop	1

<?php
/**
 * Chat Class Doc Comment
 *
 * PHP version 5
 *
 * @category PHP
 * @package  OpenChat
 * @author   Ankit Jain <[email protected]>
 * @license  The MIT License (MIT)
 * @link     https://github.com/ankitjain28may/openchat
 */
namespace ChatApp;

use Ratchet\MessageComponentInterface;
use Ratchet\ConnectionInterface;
// use ChatApp\Models\Message;
use ChatApp\Reply;
use ChatApp\Conversation;
use ChatApp\Receiver;
use ChatApp\SideBar;
use ChatApp\Search;
use ChatApp\Compose;
use ChatApp\Online;

/**
 * This Class handles the all the main functionalities for this ChatApp.
 *
 * @category PHP
 * @package  OpenChat
 * @author   Ankit Jain <[email protected]>
 * @license  The MIT License (MIT)
 * @link     https://github.com/ankitjain28may/openchat
 */

class Chat implements MessageComponentInterface
{
    /*
    |--------------------------------------------------------------------------
    | Chat Class
    |--------------------------------------------------------------------------
    |
    | This Class handles the all the main functionalities for this ChatApp.
    |
    */

    protected $clients;

    /**
     * Create a new class instance.
     *
     * @return void

     */
    public function __construct()
    {
        $this->clients = new \SplObjectStorage;
    }

    /**
     * Open the Socket Connection and get client connection
     *
     * @param ConnectionInterface $conn To store client details
     *
     * @return void
     */
    public function onOpen(ConnectionInterface $conn)
    {
        $conn = $this->setID($conn);
        $this->clients->attach($conn);
        echo "New connection! ({$conn->resourceId})\n";
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        Online::setOnlineStatus($conn->userId);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    /**
     * Set Session Id in Connection object
     *
     * @param ConnectionInterface $conn To store client details
     *
     * @return $conn

     */
    public function setID($conn)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        session_id($conn->WebSocket->request->getCookies()['PHPSESSID']);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        @session_start();
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        $conn->userId = $_SESSION['start'];
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        session_write_close();
        return $conn;
    }

    /**
     * Send Messages to Clients
     *
     * @param ConnectionInterface $from To store client details
     * @param string              $msg  To store message
     *
     * @return void
     */
    public function onMessage(ConnectionInterface $from, $msg)
    {
        $msg = (object)json_decode($msg);
        if ($msg->type == 'OpenChat initiated..!') {
            $initial = (object)array();
            $initial->initial = json_decode($this->onSidebar($from->userId));
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

            if ($initial->initial != null) {
                $initial->conversation = json_decode(
                    $this->onConversation(
                        json_encode(
                            [
                            "details" => $initial->initial[0]->login_id,
                            "load" => 20,
                            "userId" => $from->userId
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                            ]
                        ), true
                    )
                );
            }
            $from->send(json_encode($initial));
        } else if ($msg->type == 'Load Sidebar') {
            $sidebar = (object)array();
            $sidebar->sidebar = json_decode($this->onSidebar($from->userId));
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $from->send(json_encode($sidebar));
        } else if ($msg->type == 'Initiated') {
            $msg->userId = $from->userId;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $result = (object)array();
            $result->conversation = json_decode(
                $this->onConversation(json_encode($msg), false)
            );
            $from->send(json_encode($result));
        } else if ($msg->type == 'Search') {
            $msg->userId = $from->userId;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $searchResult = $this->onSearch($msg);
            $from->send($searchResult);
        } else if ($msg->type == 'Compose') {
            $msg->userId = $from->userId;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $composeResult = $this->onCompose($msg);
            $from->send($composeResult);
        } else if ($msg->type == 'typing') {
            $msg->userId = $from->userId;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $msg->name = convert_uudecode(hex2bin($msg->name));
            foreach ($this->clients as $client) {
                if ($client->userId == $msg->name) {
                    $client->send(json_encode(array('typing' => 'typing')));
                }
            }
        } else {
            $msg->userId = $from->userId;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $msg->name = convert_uudecode(hex2bin($msg->name));

            $getReturn = $this->onReply($msg);
            echo $getReturn;

            $receiveResult = (object)array();
            $sentResult = (object)array();
            foreach ($this->clients as $client) {
                if ($client->userId == $msg->name) {
                    $receiveResult->sidebar = json_decode(
                        $this->onSidebar($client->userId)
                    );

                    $receiveResult->reply = json_decode(
                        $this->onReceiver(
                            json_encode(
                                [
                                "details" => $client->userId,
                                "load" => 20,
                                "userId" => $from->userId
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                                ]
                            ), true
                        )
                    );

                    $client->send(json_encode($receiveResult));
                } else if ($client == $from) {
                    $sentResult->sidebar = json_decode(
                        $this->onSidebar($client->userId)
                    );

                    $sentResult->conversation = json_decode(
                        $this->onConversation(
                            json_encode(
                                [
                                "details" => bin2hex(convert_uuencode($msg->name)),
                                "load" => 20,
                                "userId" => $from->userId
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                                ]
                            ), true
                        )
                    );
                    $client->send(json_encode($sentResult));
                }
            }

        }
    }

    /**
     * To Call SideBar Class
     *
     * @param string $data To store data
     *
     * @return string
     */
    public function onSidebar($data)
    {
        $obSidebar = new SideBar();
        return $obSidebar->loadSideBar($data);
    }

    /**
     * To Call Conversation Class
     *
     * @param string  $data to store data
     * @param boolean $para to store True/False
     *
     * @return string
     */
    public function onConversation($data, $para)
    {
        $obConversation = new Conversation();
        return $obConversation->conversationLoad($data, $para);
    }

    /**
     * To Call Receiver Class
     *
     * @param string  $data to store data
     * @param boolean $para to store True/False
     *
     * @return string
     */
    public function onReceiver($data, $para)
    {
        $obReceiver = new Receiver();
        return $obReceiver->receiverLoad($data, $para);
    }

    /**
     * To Call Search Class
     *
     * @param string $data to store data
     *
     * @return string
     */
    public function onSearch($data)
    {
        $obSearch = new Search();
        return $obSearch->searchItem($data);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * To Call Compose Class
     *
     * @param string $data to store data
     *
     * @return string
     */
    public function onCompose($data)
    {
        $obCompose = new Compose();
        return $obCompose->selectUser($data);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * To Call Reply Class
     *
     * @param string $data to store data
     *
     * @return string
     */
    public function onReply($data)
    {
        $obReply = new Reply();
        return $obReply->replyTo($data);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * To Call Online Class
     *
     * @param ConnectionInterface $conn To store client details
     *
     * @return void
     */
    public function onClose(ConnectionInterface $conn)
    {
        Online::removeOnlineStatus($conn->userId);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->clients->detach($conn);
        echo "Connection {$conn->resourceId} has disconnected\n";
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    /**
     * To Show error due to any problem occured
     *
     * @param ConnectionInterface $conn To store client details
     * @param \Exception          $e    To store exception
     *
     * @return void
     */
    public function onError(ConnectionInterface $conn, \Exception $e)
    {
        echo "An error has occurred: {$e->getMessage()}\n";
        $conn->close();
    }

}


Pull Request — master (#30)

Chat::setID() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2			/**
3			* Chat Class Doc Comment
4			*
5			* PHP version 5
6			*
7			* @category PHP
8			* @package OpenChat
9			* @author Ankit Jain <[email protected]>
10			* @license The MIT License (MIT)
11			* @link https://github.com/ankitjain28may/openchat
12			*/
13			namespace ChatApp;
14
15			use Ratchet\MessageComponentInterface;
16			use Ratchet\ConnectionInterface;
17			// use ChatApp\Models\Message;
18			use ChatApp\Reply;
19			use ChatApp\Conversation;
20			use ChatApp\Receiver;
21			use ChatApp\SideBar;
22			use ChatApp\Search;
23			use ChatApp\Compose;
24			use ChatApp\Online;
25
26			/**
27			* This Class handles the all the main functionalities for this ChatApp.
28			*
29			* @category PHP
30			* @package OpenChat
31			* @author Ankit Jain <[email protected]>
32			* @license The MIT License (MIT)
33			* @link https://github.com/ankitjain28may/openchat
34			*/
35
36			class Chat implements MessageComponentInterface
37			{
38			/*
39			\|--------------------------------------------------------------------------
40			\| Chat Class

ankitjain28may / openchat

Pull Request — master (#30)

Chat::setID() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like