ankitjain28may / openchat

src/Chat.php

Unused Use Statements -2 removed lines

@@ -2,11 +2,9 @@
 namespace ChatApp;
 use Ratchet\MessageComponentInterface;
 use Ratchet\ConnectionInterface;
-use ChatApp\Models\Message;
 use ChatApp\Reply;
 use ChatApp\Conversation;
 use ChatApp\Receiver;
-use ChatApp\SideBar;
 use ChatApp\Search;
 use ChatApp\Compose;
 

Braces +6 added lines, -12 removed lines

@@ -55,33 +55,28 @@ 
                 );
             }
             $from->send(json_encode($initial));
-        }
-        elseif ($msg->type == 'Load Sidebar')
+        } elseif ($msg->type == 'Load Sidebar')
         {
             $sidebar = (object) array();
             $sidebar->sidebar = json_decode($this->onSidebar($from->userId));
             $from->send(json_encode($sidebar));
-        }
-        elseif ($msg->type == 'Initiated')
+        } elseif ($msg->type == 'Initiated')
         {
             $msg->userId = $from->userId;
             $result = (object) array();
             $result->conversation = json_decode($this->onConversation(json_encode($msg), False));
             $from->send(json_encode($result));
-        }
-        elseif ($msg->type == 'Search')
+        } elseif ($msg->type == 'Search')
         {
             $msg->userId = $from->userId;
             $searchResult = $this->onSearch($msg);
             $from->send($searchResult);
-        }
-        elseif ($msg->type == 'Compose')
+        } elseif ($msg->type == 'Compose')
         {
             $msg->userId = $from->userId;
             $composeResult = $this->onCompose($msg);
             $from->send($composeResult);
-        }
-        else
+        } else
         {
             $msg->userId = $from->userId;
             $getReturn = $this->onReply($msg);
@@ -106,8 +101,7 @@ 
                     );
 
                     $client->send(json_encode($receiveResult));
-                }
-                elseif($client == $from)
+                } elseif($client == $from)
                 {
                     $sentResult->sidebar = json_decode($this->onSidebar($client->userId));
 

src/Time.php

Braces +9 added lines, -8 removed lines

@@ -16,14 +16,15 @@
     function TimeConversion($time)
     {
 
-        if(substr($time,4,11) == date("d M Y", time() + 16200))
-            $time = substr($time,16,5);
-        else if(substr($time,7,8) == date("M Y", time() + 16200) && substr($time, 4,2) - date("d") < 7)
-            $time = substr($time,0,3);
-        else if(substr($time,11,4) == date("Y", time() + 16200))
-            $time = substr($time,4,6);
-        else
-            $time = substr($time,4,11);
+        if(substr($time,4,11) == date("d M Y", time() + 16200)) {
+                    $time = substr($time,16,5);
+        } else if(substr($time,7,8) == date("M Y", time() + 16200) && substr($time, 4,2) - date("d") < 7) {
+                    $time = substr($time,0,3);
+        } else if(substr($time,11,4) == date("Y", time() + 16200)) {
+                    $time = substr($time,4,6);
+        } else {
+                    $time = substr($time,4,11);
+        }
 
         return $time;
     }

src/Validate.php

Braces +4 added lines, -4 removed lines

@@ -40,9 +40,9 @@ 
 		{
 			if ($result->num_rows>0) {
 				return 1;
+			} else {
+							return 0;
 			}
-			else
-				return 0;
 		}
 	}
 
@@ -52,9 +52,9 @@ 
 		if ($result=$this->connect->query($query)) {
 			if ($result->num_rows>0) {
 				return 1;
+			} else {
+							return 0;
 			}
-			else
-				return 0;
 			
 		}
 	}

src/Profile.php

Braces +4 added lines, -3 removed lines

@@ -14,12 +14,13 @@
         $connect = mysqli_connect(DB_HOST, DB_USER, DB_PASSWORD, DB_NAME);
         $query = "SELECT * from profile where login_id = '$userId'";
         $result = $connect->query($query);
-        if($result->num_rows > 0)                   // if true
+        if($result->num_rows > 0) {
+            // if true
         {
             $details = $result->fetch_assoc();
-            return $details;
         }
-        else
+            return $details;
+        } else
         {
             return NULL;
         }

src/User.php

Braces +9 added lines, -7 removed lines

@@ -30,17 +30,19 @@
 
     public function userDetails($userId, $para)
     {
-        if($para == True)
-            $this->query = "SELECT * from login where login_id = '$userId'";
-        else
-            $this->query = "SELECT * from login where username = '$userId'";
+        if($para == True) {
+                    $this->query = "SELECT * from login where login_id = '$userId'";
+        } else {
+                    $this->query = "SELECT * from login where username = '$userId'";
+        }
         $this->result = $this->connect->query($this->query);
-        if($this->result->num_rows > 0)                   // if true
+        if($this->result->num_rows > 0) {
+            // if true
         {
             $this->details = $this->result->fetch_assoc();
-            return $this->details;
         }
-        else
+            return $this->details;
+        } else
         {
             return NULL;
         }

views/logout.php

Braces +1 added lines, -2 removed lines

@@ -12,8 +12,7 @@
         header('Location: ../../index.php');
     }
 
-}
-else
+} else
 {
 	echo "Please Login";
 }

views/message.php

Braces +1 added lines, -2 removed lines

@@ -129,8 +129,7 @@
 </html>
 
 <?php
-}
-else{
+} else{
 	header('Location:http://www.localhost/openchat/login.php');
 }
 ?>

views/profile_generate.php

Braces +2 added lines, -4 removed lines

@@ -18,14 +18,12 @@
 		if($result = $connect->query($query))
 		{
 			header('Location:'.URL.'/account.php');
-		}
-		else
+		} else
 		{
 			header("Location:".URL."/error.php");
 		}
 	endif;
-}
-else
+} else
 {
 	header("Location:".URL."/error.php");
 }

views/account.php

Braces +31 added lines, -22 removed lines

@@ -22,19 +22,19 @@ 
 		$location = getenv('APP_URL') . "/views/account.php/". $row['username'];
 		header("Location:".$location);
 	}
-}
-elseif ($user != "account.php")
+} elseif ($user != "account.php")
 {
 	$obUser = new User();
 	$row = $obUser->userDetails($user, False);
 	if($row != NULL):
 		$userId = $row['login_id'];
 		$details = Profile::getProfile($userId);
-		if($details != NULL)
-			$row = array_merge($row, $details);
-		else
-			header("Location:".getenv('APP_URL')."/views/error.php");
-?>
+		if($details != NULL) {
+					$row = array_merge($row, $details);
+		} else {
+					header("Location:".getenv('APP_URL')."/views/error.php");
+		}
+		?>
 
 		<!Doctype html>
 		<html>
@@ -51,10 +51,13 @@ 
 		                <?php if(Session::get('start') != null): ?>
 							<li><a href="../message.php">Message</a></li>
 							<li><a href="../logout.php">Log out</a></li>
-						<?php else: ?>
+						<?php else {
+    : ?>
 							<li><a href="../login.php">Login</a></li>
 							<li><a href="../register.php">Register</a></li>
-						<?php endif; ?>
+						<?php endif;
+}
+?>
 		            </ul>
 		        </div>
 
@@ -68,16 +71,21 @@ 
 						<div class="brief">
 							<h1 id="name">Name: <?php echo $row['name']; ?></h1><br>
 							<?php foreach ($row as $key => $value) {
-								if($key =='username' && $value != null)
-									echo '<p>Username: '.$row["username"] .'</p><br>';
-								if($key == 'email' && $value != null)
-									echo '<p>Email Id: '.$row["email"] .'</p><br>';
-								if($key == 'status' && $value != null)
-									echo '<p>Status: '.$row["status"] .'</p><br>';
-								if($key == 'education' && $value != null)
-									echo '<p>Education: '.$row["education"] .'</p><br>';
-								if($key == 'gender' && $value != null)
-									echo '<p>Gender: 	'.$row["gender"] .'</p><br>';
+								if($key =='username' && $value != null) {
+																	echo '<p>Username: '.$row["username"] .'</p><br>';
+								}
+								if($key == 'email' && $value != null) {
+																	echo '<p>Email Id: '.$row["email"] .'</p><br>';
+								}
+								if($key == 'status' && $value != null) {
+																	echo '<p>Status: '.$row["status"] .'</p><br>';
+								}
+								if($key == 'education' && $value != null) {
+																	echo '<p>Education: '.$row["education"] .'</p><br>';
+								}
+								if($key == 'gender' && $value != null) {
+																	echo '<p>Gender: 	'.$row["gender"] .'</p><br>';
+								}
 							}
 							?>
 						</div>
@@ -119,11 +127,12 @@ 
 			</body>
 		</html>
 <?php
-	else:
+	else {
+	    :
 		header("Location:".getenv('APP_URL')."/views/error.php");
+	}
 	endif;
-}
-else
+} else
 {
 	header("Location: ".getenv('APP_URL')."/views/");
 }