Issues in account.php - Fixed Issues - Inspection of "Add profile.js n fix sscrutinizer" - ankitjain28may/openchat - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 15356d...37eca5 )

by Ankit

created 2017-01-02 17:50 UTC

account.php (6 issues)

Labels

Severity

Minor 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

require_once (__DIR__ . '/vendor/autoload.php');
require_once (__DIR__ . '/config/database.php');
use ChatApp\User;
use ChatApp\Profile;
use ChatApp\Session;

$user = explode("/", $_SERVER['REQUEST_URI']);
$user = $user[count($user)-1];
$userId = Session::get('start');
if($userId != null and $user == "account.php")
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
{
	$obUser = new User();
	$row = $obUser->UserDetails($userId, True);

	if($row != NULL)
	{
		$location = URL . "/account.php/". $row['username'];
		header("Location:".$location);
	}
}
elseif ($user != "account.php")
{
	$obUser = new User();
	$row = $obUser->UserDetails($user, False);
	if($row != NULL):
		$userId = $row['login_id'];
		$details = Profile::getProfile($userId);
		if($details != NULL)
			$row = array_merge($row, $details);
		else
			header("Location:".URL."/error.php");
?>

		<!Doctype html>
		<html>
			<head>
				<title>OpenChat || Profile</title>
		        <link rel="stylesheet" href="../css/profile.css">
			</head>
			<body>

				<div class="header">
		            <a id="brand" href="">OpenChat</a>
		            <ul class="nav-right">
		                <li><a href="../index.php">About</a></li>
		                <?php if(Session::get('start') != null): ?>
							<li><a href="../message.php">Message</a></li>
							<li><a href="../logout.php">Log out</a></li>
						<?php else: ?>
							<li><a href="../login.php">Login</a></li>
							<li><a href="../register.php">Register</a></li>
						<?php endif; ?>
		            </ul>
		        </div>

		        <div class="main">
					<div class="boxx" >

						<div class="pic">
							<img src="../assests/ankit.png">
						</div>

						<div class="brief">
							<h1 id="name">Name: <?php echo $row['name']; ?></h1><br>
							<?php foreach ($row as $key => $value) {
								if($key =='username' and $value != null)
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
									echo '<p>Username: '.$row["username"] .'</p><br>';
								if($key == 'email' and $value != null)
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
									echo '<p>Email Id: '.$row["email"] .'</p><br>';
								if($key == 'status' and $value != null)
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
									echo '<p>Status: '.$row["status"] .'</p><br>';
								if($key == 'education' and $value != null)
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
									echo '<p>Education: '.$row["education"] .'</p><br>';
								if($key == 'gender' and $value != null)
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
									echo '<p>Gender: 	'.$row["gender"] .'</p><br>';
							}
							?>
						</div>
						<?php if(Session::get('start') == $row['login_id']): ?>
							<div class="edit">
								<a href="#">Edit Profile</a>
							</div>
						<?php endif; ?>
					</div>

					<?php
						if(Session::get('start') == $row['login_id']):
					?>

					<div class="boxx" id="profile">
						<form method="post" action="../profile_generate.php">
							<label>Status : </label>
							<textarea name="status" id="status"><?php echo $row['status']; ?></textarea>
							<label>Education : </label>
							<input type="text" name="education" id="education" value="<?php echo $row['education']; ?>"></input>
							<label>Gender : </label><br>
							<input type="radio" name="gender" id="gender" value="Male" <?php echo ($row['gender']=='Male')?'checked':'' ?>> Male<br>
							<input type="radio" name="gender" id="gender" value="Female" <?php echo ($row['gender']=='Female')?'checked':'' ?>> Female<br>
							<input type="submit" name="submit" value="Done" id="submit">
						</form>
					</div>
					<?php
						endif;
					?>
				</div>

				<div class="footer">
					<h3 class="footer_text">Made with love by <a href="#">Ankit Jain</a></h3>
				</div>

			    <script type="text/javascript" src="../js/jquery-3.0.0.min.js"></script>
				<script type="text/javascript" src="../js/profile.js"></script>
			    <script type="text/javascript" src="../node_modules/place-holder.js/place-holder.min.js"></script>
			</body>
		</html>
<?php
	else:
		header("Location:".URL."/error.php");
	endif;
}
else
{
	header("Location: ".URL);
}
?>



Push — master ( 15356d...37eca5 )

account.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

ankitjain28may / openchat

Push — master ( 15356d...37eca5 )

account.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like