ankitjain28may / openchat

src/Register.php

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 8 and the first side effect is on line 6.

namespace ChatApp;
use ChatApp\Validate;
use ChatApp\Session;
require_once (dirname(__DIR__) . '/config/database.php');

class Register
{
	protected $error;
	protected $key;
	protected $obValidate;
	protected $connect;
	protected $session;

	public function __construct()

This method seems to be duplicated in your project.

	{
		$this->error = array();
		$this->key = 0;
		$this->connect = mysqli_connect(DB_HOST, DB_USER, DB_PASSWORD, DB_NAME);
		$this->session = new Session();
		$this->obValidate = new Validate();

	}

	public function authRegister($name, $email, $username, $password, $mob)
	{
		$name = trim($name);
		$email = trim($email);
		$username = trim($username);
		$password = trim($password);
		$mob = trim($mob);
		$userId = '';

		if (empty($name)) {
			$this->onError(["name" => " *Enter the name"]);
		}

		if(empty($email)) {
			$this->onError(["email" => " *Enter the email address"]);
		}
		elseif(filter_var($email, FILTER_VALIDATE_EMAIL) == false) {
			$this->onError(["email" => " *Enter correct Email address"]);
		}
		else
		{
			if($this->obValidate->validateEmailInDb($email) === 1)
			{

				$this->onError(["email" => " *Email is already registered"]);
			}
		}

		if(empty($username)) {
			$this->onError(["username" => " *Enter the username"]);
		}
		else
		{
			if($this->obValidate->validateUsernameInDb($username) === 1)
			{

				$this->onError(["username" => " *Username is already registered"]);
			}
		}

		if(empty($password)) {
			$this->onError(["password" => " *Enter the password"]);
		}

		if(empty($mob)) {
			$this->onError(["mob" => " *Enter the Mobile Number"]);
		}
		elseif (!preg_match("/^[0-9]{10}$/", $mob)) {
			$this->onError(["mob" => " *Enter correct Mobile Number"]);
		}

		if($this->key == 1)
		{
			return json_encode($this->error);
		}
		else
		{
			$this->key = 0;
			$pass = md5($password);
			$query = "INSERT INTO register VALUES(null, '$email', '$username', '$pass')";
			if(!$this->connect->query($query)) {
				$this->key = 1;
				echo "You are not registered || Error in registration2";
			}
			else
			{
				$query = "SELECT id FROM register WHERE email = '$email'";
				if($result = $this->connect->query($query)) {
					$row = $result->fetch_assoc();
					$userId = $row['id'];

					$query = "INSERT INTO login VALUES('$userId', '$name', '$email', '$username', '$mob', 0)";
					if(!$this->connect->query($query)) {
						$this->key = 1;
						echo "You are not registered || Error in registration1";
					}
				}
			}
		}
		if ($this->key == 0) {
			$this->session->put('start', $userId);
			return json_encode([
				"location" => URL."/account.php"
			]);
		}
		else
		{
			return json_encode($this->error);
		}
	}

	public function onError($value)
	{
		$this->key = 1;
		$this->error = array_merge($this->error, $value);
	}
}