Issues in database.php - New Issues - Inspection of "Directory structure and online status" - ankitjain28may/openchat - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( a87e27...976b69 )

by Ankit

created 2017-01-02 16:56 UTC

config/database.php (2 issues)

Labels

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
  // Define database connection constants
  define('DB_HOST', 'localhost');
  define('DB_USER', 'root');
  define('DB_PASSWORD','');
  define('DB_NAME', 'openchat');
  define('URL', URL());

   function URL()
  {
    $http = "http://";
    @$host = $_SERVER['SERVER_NAME'];
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
    @$port = $_SERVER['SERVER_PORT'];
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
    $fol = "";
    if(@$_SERVER['SERVER_ADDR']!=NULL)
    {
        $fol = "/".explode('/', $_SERVER['PHP_SELF'])[1];
    }
    $url = $http.$host.":".$port.$fol;
    return $url;
  }



1			<?php
2			// Define database connection constants
3			define('DB_HOST', 'localhost');
4			define('DB_USER', 'root');
5			define('DB_PASSWORD','');
6			define('DB_NAME', 'openchat');
7			define('URL', URL());
8
9			function URL()
10			{
11			$http = "http://";
12			@$host = $_SERVER['SERVER_NAME'];
			0 ignored issues – show Security Best Practice introduced 2017-01-02 16:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
13			@$port = $_SERVER['SERVER_PORT'];
			0 ignored issues – show Security Best Practice introduced 2017-01-02 16:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
14			$fol = "";
15			if(@$_SERVER['SERVER_ADDR']!=NULL)
16			{
17			$fol = "/".explode('/', $_SERVER['PHP_SELF'])[1];
18			}
19			$url = $http.$host.":".$port.$fol;
20			return $url;
21			}
22
23

ankitjain28may / openchat

Push — master ( a87e27...976b69 )

config/database.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like