ChatApp\Conversation

Complexity

Total Complexity

13

Size/Duplication

Total Lines	100
Duplicated Lines	19 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	15	15	1
C	conversationLoad()	4	76	12

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 16 and the first side effect is on line 4.

namespace ChatApp;
require_once (dirname(__DIR__) . '/vendor/autoload.php');
use ChatApp\Session;
use ChatApp\Time;
use ChatApp\User;
use Dotenv\Dotenv;
$dotenv = new Dotenv(dirname(__DIR__));
$dotenv->load();


/**
*
*/
class Conversation
{
    protected $connect;
    protected $array;
    protected $obTime;
    protected $obUser;

    public function __construct($sessionId)

This method seems to be duplicated in your project.

    {
        session_id($sessionId);
        @session_start();

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        $this->connect = mysqli_connect(
            getenv('DB_HOST'),
            getenv('DB_USER'),
            getenv('DB_PASSWORD'),
            getenv('DB_NAME')
        );
        session_write_close();
        $this->obTime = new Time();
        $this->obUser = new User();
        $this->array = array();
    }

    public function conversationLoad($msg, $para)
    {

        $flag = 1;

$flag is not used, you could remove the assignment.

        if(Session::get('start') != null && isset($msg))
        {
            $add_load = 0;
            $userId = Session::get('start');
            $msg = json_decode($msg);
            $username = $msg->username;
            $load = $msg->load;

            $fetch = $this->obUser->userDetails($username, $para);

            if($fetch != NULL)
            {
                $login_id = (int)$fetch['login_id'];

                // Unique Identifier
                if($login_id > $userId)

This code seems to be duplicated across your project.

                    $identifier = $userId.':'.$login_id;
                else
                    $identifier = $login_id.':'.$userId;

                $query = "SELECT total_messages from total_message where identifier = '$identifier'";
                if($result = $this->connect->query($query))
                {
                    if($result->num_rows > 0)
                    {
                        $total = $result->fetch_assoc();
                        $total = $total['total_messages'];
                        if($total - $load > 0)
                            if($total - $load > 10)
                                $add_load = $load + 10;
                            else
                                $add_load = $total;
                    }
                }

                $query = "SELECT message, time, sent_by FROM messages WHERE identifier_message_number = '$identifier' ORDER BY id DESC limit ".$load;
                if($result = $this->connect->query($query))
                {
                    if($result->num_rows > 0)
                    {
                        while($row = $result->fetch_assoc())
                        {
                            $row['time'] = $this->obTime->timeConversion($row['time']);
                            $row = array_merge($row,['start' => $userId]);
                            $this->array = array_merge($this->array, [$row]);
                        }

                        $this->array = array_merge([['name' => $fetch['name'], 'username' => $fetch['username'], 'id' => $fetch['login_id'], 'load' => $add_load, 'login_status' => $fetch['login_status'], 'type' => 1]], $this->array);
                        return json_encode($this->array);
                    }
                    else
                    {
                        return json_encode([['name' => $fetch['name'], 'username' => $fetch['username'], 'id' => $fetch['login_id'], 'login_status' => $fetch['login_status'], 'type' => 0]]);
                    }
                }
                else
                {
                    echo "Query Failed";
                }
            }
            else
            {
                echo "Query Failed";
            }
        }
        else
        {
            header('Location:../login.php');
        }

        $this->connect->close();
    }
}