Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
30 | class Online |
||
31 | { |
||
32 | |||
33 | /* |
||
34 | |-------------------------------------------------------------------------- |
||
35 | | Online Class |
||
36 | |-------------------------------------------------------------------------- |
||
37 | | |
||
38 | | For checking online status. |
||
39 | | |
||
40 | */ |
||
41 | |||
42 | /** |
||
43 | * Set Online Status |
||
44 | * |
||
45 | * @param string $userId To store userId |
||
46 | * |
||
47 | * @return void |
||
48 | */ |
||
49 | View Code Duplication | public static function setOnlineStatus($userId) |
|
63 | |||
64 | /** |
||
65 | * Remove Online Status |
||
66 | * |
||
67 | * @param string $userId To store userId |
||
68 | * |
||
69 | * @return void |
||
70 | */ |
||
71 | View Code Duplication | public static function removeOnlineStatus($userId) |
|
85 | } |
||
86 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.