AnimeDb\Bundle\CatalogBundle\Repository\Storage

Complexity

Total Complexity

8

Size/Duplication

Total Lines	94
Duplicated Lines	29.79 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	count()	0	9	1
B	getList()	0	26	3
B	getLastUpdate()	28	28	3
A	getLast()	0	9	1

<?php
/**
 * AnimeDb package.
 *
 * @author    Peter Gribanov <info@peter-gribanov.ru>
 * @copyright Copyright (c) 2011, Peter Gribanov
 * @license   http://opensource.org/licenses/GPL-3.0 GPL v3
 */

namespace AnimeDb\Bundle\CatalogBundle\Repository;

use Doctrine\ORM\EntityRepository;
use AnimeDb\Bundle\CatalogBundle\Entity\Storage as StorageEntity;

/**
 * @author  Peter Gribanov <info@peter-gribanov.ru>
 */
class Storage extends EntityRepository
{
    /**
     * @return int
     */
    public function count()
    {
        return $this->getEntityManager()->createQuery('
            SELECT
                COUNT(s)
            FROM
                AnimeDbCatalogBundle:Storage s
        ')->getSingleScalarResult();
    }

    /**
     * @param array $types
     *
     * @return StorageEntity[]
     */
    public function getList(array $types = [])
    {
        if (!$types || $types == StorageEntity::getTypes()) {

The expression $types of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $this->getEntityManager()->createQuery('
                SELECT
                    s
                FROM
                    AnimeDbCatalogBundle:Storage s
                ORDER BY
                    s.id DESC
            ')->getResult();
        }

        return $this->getEntityManager()->createQuery('
            SELECT
                s
            FROM
                AnimeDbCatalogBundle:Storage s
            WHERE
                s.type IN (:types)
            ORDER BY
                s.id DESC
        ')
            ->setParameter(':types', $types)
            ->getResult();
    }

    /**
     * @param int|null $id
     *
     * @return \DateTime|null
     */
    public function getLastUpdate($id = null)

This method seems to be duplicated in your project.

    {
        if ($id) {

The expression $id of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

            $result = $this->getEntityManager()->createQuery('
                SELECT
                    s.date_update
                FROM
                    AnimeDbCatalogBundle:Storage s
                WHERE
                    s.id = :id'
            )
                ->setParameter(':id', $id)
                ->getOneOrNullResult();
        } else {
            $result = $this->getEntityManager()->createQuery('
                SELECT
                    s.date_update
                FROM
                    AnimeDbCatalogBundle:Storage s
                ORDER BY
                    s.date_update DESC'
            )
                ->setMaxResults(1)
                ->getOneOrNullResult();
        }

        return $result ? $result['date_update'] : null;
    }

    /**
     * @return StorageEntity|null
     */
    public function getLast()
    {
        return $this
            ->createQueryBuilder('s')
            ->addOrderBy('s.id', 'DESC')
            ->setMaxResults(1)
            ->getQuery()
            ->getOneOrNullResult();
    }
}