AnimeDb\Bundle\CatalogBundle\DoctrineMigrations\Version20140408114519_EditListStudios

Complexity

Total Complexity

7

Size/Duplication

Total Lines	103
Duplicated Lines	9.71 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setContainer()	0	4	1
A	up()	5	20	3
A	down()	5	17	3

<?php
/**
 * AnimeDb package.
 *
 * @author    Peter Gribanov <info@peter-gribanov.ru>
 * @copyright Copyright (c) 2011, Peter Gribanov
 * @license   http://opensource.org/licenses/GPL-3.0 GPL v3
 */

namespace AnimeDb\Bundle\CatalogBundle\DoctrineMigrations;

use Doctrine\DBAL\Migrations\AbstractMigration;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\DependencyInjection\ContainerAwareInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Doctrine\DBAL\Schema\Schema;
use AnimeDb\Bundle\CatalogBundle\Entity\Studio;

/**
 * Auto-generated Migration: Please modify to your needs!
 */
class Version20140408114519_EditListStudios extends AbstractMigration implements ContainerAwareInterface
{
    /**
     * Entity manager.
     *
     * @var EntityManagerInterface
     */
    protected $em;

    /**
     * Add studios.
     *
     * @var array
     */
    protected $add = [
        'Actas',
        'OB Planning',
        'Studio Rikka',
        'Group TAC',
        'Brains Base',
        'Studio Nue',
        'Anima',
        'Hoods Entertainment',
        'Palm Studio',
        'MAPPA',
        'Cammot',
        'Fifth Avenue',
        'NAZ',
        'Pierrot Plus',
    ];

    /**
     * Rename studios.
     *
     * @var array
     */
    protected $rename = [
        'Xebec' => 'XEBEC',
        'Ufotable' => 'ufotable',
        'Shaft' => 'SHAFT',
        'A-1 Pictures' => 'A-1 Pictures Inc.',
        'Imagin' => 'IMAGIN',
        'Feel' => 'feel.',
        'Animax Entertainment' => 'Animax',
        'A.C.G.T' => 'A.C.G.T.',
        'Zexcs' => 'ZEXCS',
    ];

    /**
     * Set container.
     *
     * @param ContainerInterface $container
     */
    public function setContainer(ContainerInterface $container = null)
    {
        $this->em = $container->get('doctrine.orm.entity_manager');

It seems like $container is not always an object, but can also be of type null. Maybe add an additional type check?

    }

    /**
     * @param Schema $schema
     */
    public function up(Schema $schema)
    {
        $rep = $this->em->getRepository('AnimeDbCatalogBundle:Studio');

        // rename studios
        /* @var $studio Studio */
        foreach ($this->rename as $from => $to) {

This code seems to be duplicated across your project.

            $studio = $rep->findOneBy(['name' => $from]);
            $studio->setName($to);
            $this->em->persist($studio);
        }

        // add new studios
        foreach ($this->add as $name) {
            $studio = new Studio();
            $studio->setName($name);
            $this->em->persist($studio);
        }
        $this->em->flush();
    }

    /**
     * @param Schema $schema
     */
    public function down(Schema $schema)
    {
        $rep = $this->em->getRepository('AnimeDbCatalogBundle:Studio');

        // rename studios
        /* @var $studio Studio */
        foreach ($this->rename as $from => $to) {

This code seems to be duplicated across your project.

            $studio = $rep->findOneBy(['name' => $to]);
            $studio->setName($from);
            $this->em->persist($studio);
        }

        // remove studios
        foreach ($this->add as $name) {
            $this->em->remove($rep->findOneBy(['name' => $name]));
        }
    }
}