AnimeDb\Bundle\CatalogBundle\DoctrineMigrations\Version20140407162508_RenameItemGenres

Complexity

Total Complexity

7

Size/Duplication

Total Lines	133
Duplicated Lines	16.54 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setContainer()	0	4	1
B	up()	11	31	3
B	down()	11	35	3

<?php
/**
 * AnimeDb package.
 *
 * @author    Peter Gribanov <info@peter-gribanov.ru>
 * @copyright Copyright (c) 2011, Peter Gribanov
 * @license   http://opensource.org/licenses/GPL-3.0 GPL v3
 */

namespace AnimeDb\Bundle\CatalogBundle\DoctrineMigrations;

use Doctrine\DBAL\Migrations\AbstractMigration;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\DependencyInjection\ContainerAwareInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Doctrine\DBAL\Schema\Schema;
use AnimeDb\Bundle\CatalogBundle\Entity\Genre;

/**
 * Auto-generated Migration: Please modify to your needs!
 */
class Version20140407162508_RenameItemGenres extends AbstractMigration implements ContainerAwareInterface
{
    /**
     * @var EntityManagerInterface
     */
    protected $em;

    /**
     * Rename genres.
     *
     * @var array
     */
    protected $rename = [
        'Mysticism' => 'Mystery',
        'Ettie' => 'Ecchi',
        'For children' => ['Kids', 'Детское'],
        'Meho' => 'Mecha',
        'Musical' => ['Music', 'Музыка'],
        'Samurai action' => ['Samurai', 'Самураи'],
        'Senen' => 'Shounen',
        'Senen-ai' => 'Shounen-ai',
        'Psychology' => ['Psychological', 'Психологическое'],
        'Fantastic' => 'Sci-fi',
        'Everyday' => 'Slice of life',
        'Vampires' => 'Vampire',
        'Urey' => 'Yuri',
    ];

    /**
     * Restore genres.
     *
     * @var array
     */
    protected $restore = [
        'Mystery' => 'Mysticism',
        'Ecchi' => 'Ettie',
        'Kids' => ['For children', 'Для детей'],
        'Mecha' => 'Meho',
        'Music' => ['Musical', 'Музыкальный'],
        'Samurai' => ['Samurai action', 'Самурайский боевик'],
        'Shounen' => 'Senen',
        'Shounen-ai' => 'Senen-ai',
        'Psychological' => ['Psychology', 'Психология'],
        'Sci-fi' => 'Fantastic',
        'Slice of life' => 'Everyday',
        'Vampire' => 'Vampires',
        'Yuri' => 'Urey',
    ];

    /**
     * Set container.
     *
     * @param ContainerInterface $container
     */
    public function setContainer(ContainerInterface $container = null)
    {
        $this->em = $container->get('doctrine.orm.entity_manager');

It seems like $container is not always an object, but can also be of type null. Maybe add an additional type check?

    }

    /**
     * @param Schema $schema
     */
    public function up(Schema $schema)
    {
        $rep = $this->em->getRepository('AnimeDbCatalogBundle:Genre');

        /* @var $genre Genre */
        foreach ($this->rename as $from => $to) {

This code seems to be duplicated across your project.

            $genre = $rep->findOneBy(['name' => $from]);
            if (is_array($to)) {
                $genre->setName($to[1])->setTranslatableLocale('ru');
                $this->em->persist($genre);
                $this->em->flush($genre);

The call to EntityManagerInterface::flush() has too many arguments starting with $genre.

                $to = $to[0];
            }
            $genre->setName($to)->setTranslatableLocale('en');
            $this->em->persist($genre);
        }
        // remove
        $genre = $rep->findOneBy(['name' => 'Mystery play']);
        $this->em->remove($genre);

        // rename russian
        $genre = $rep->findOneBy(['name' => 'History']);
        $genre->setName('Исторический')->setTranslatableLocale('ru');
        $this->em->persist($genre);

        $genre = $rep->findOneBy(['name' => 'War']);
        $genre->setName('Военное')->setTranslatableLocale('ru');
        $this->em->persist($genre);

        $this->em->flush();
    }

    /**
     * @param Schema $schema
     */
    public function down(Schema $schema)
    {
        $rep = $this->em->getRepository('AnimeDbCatalogBundle:Genre');

        /* @var $genre Genre */
        foreach ($this->restore as $from => $to) {

This code seems to be duplicated across your project.

            $genre = $rep->findOneBy(['name' => $from]);
            if (is_array($to)) {
                $genre->setName($to[1])->setTranslatableLocale('ru');
                $this->em->persist($genre);
                $this->em->flush($genre);

The call to EntityManagerInterface::flush() has too many arguments starting with $genre.

                $to = $to[0];
            }
            $genre->setName($to)->setTranslatableLocale('en');
            $this->em->persist($genre);
        }
        // new genre
        $genre = new Genre();
        $genre->setName('Mystery play')->setTranslatableLocale('en');
        $this->em->persist($genre);
        $this->em->flush();
        $genre->setName('Мистерия')->setTranslatableLocale('ru');
        $this->em->persist($genre);

        // rename russian
        $genre = $rep->findOneBy(['name' => 'History']);
        $genre->setName('История')->setTranslatableLocale('ru');
        $this->em->persist($genre);

        $genre = $rep->findOneBy(['name' => 'War']);
        $genre->setName('Война')->setTranslatableLocale('ru');
        $this->em->persist($genre);

        $this->em->flush();
    }
}