Response::isSuccessful() - Code Metrics - anilahir/omnipay-moneris - Measure and Improve Code Quality continuously with Scrutinizer

Response::isSuccessful() B
last analyzed 2019-12-10 11:15 UTC

↳ Parent: Response

Complexity

Conditions	9
Paths	2

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	9

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
cc	9
eloc	8
c	2
b	1
f	0
nc	2
nop	0
dl	0
loc	15
ccs	7
cts	7
cp	1
crap	9
rs	8.0555

<?php

namespace Omnipay\Moneris\Message;

use Omnipay\Common\Message\AbstractResponse;

class Response extends AbstractResponse
{
    public function isSuccessful()
    {
        if ((

                (isset($this->data->receipt->Complete) && (bool) $this->data->receipt->Complete === true) ||
                (isset($this->data->receipt->ResSuccess) && (bool) $this->data->receipt->ResSuccess === true)
            ) &&
            (
                isset($this->data->receipt->ResponseCode) && $this->data->receipt->ResponseCode != 'null' &&
                (int) $this->data->receipt->ResponseCode >= 0 && (int) $this->data->receipt->ResponseCode <= 49
            )
        ) {
            return true;
        }

        return false;
    }

    public function getCardReference()
    {
        return isset($this->data->receipt->DataKey) ? (string) $this->data->receipt->DataKey : null;
    }

    public function getCode()
    {
        return isset($this->data->receipt->ResponseCode) ? (string) $this->data->receipt->ResponseCode : null;
    }

    public function getAuthCode()
    {
        return isset($this->data->receipt->AuthCode) ? (string) $this->data->receipt->AuthCode : null;
    }

    public function getTransactionId()
    {
        return isset($this->data->receipt->TransID) ? (string) $this->data->receipt->TransID : null;
    }

    public function getTransactionReference()
    {
        return isset($this->data->receipt->ReferenceNum) ? (string) $this->data->receipt->ReferenceNum : null;
    }

    public function getMessage()
    {
        return isset($this->data->receipt->Message) ? (string) $this->data->receipt->Message : null;
    }

    public function getOrderNumber()
    {
        return isset($this->data->receipt->ReceiptId) ? (string) $this->data->receipt->ReceiptId : null;
    }

    public function getData()
    {
        $response = null;


        try {
            $response = preg_replace('/\n/', '', ($this->data)->asXML());
        } catch (\Error $e) {
            $response = $this->data;
        }

        return $response;
    }
}


1		<?php
2
3		namespace Omnipay\Moneris\Message;
4
5		use Omnipay\Common\Message\AbstractResponse;
6
7		class Response extends AbstractResponse
8		{
9	45	public function isSuccessful()
10		{
11		if ((
		0 ignored issues – show introduced 2019-12-10 08:13 UTC by Report Bug Copy Issue Report Consider adding parentheses for clarity. Current Interpretation: `(IssetNode && (bool)$thi...ipt->ResponseCode <= 49`, Probably Intended Meaning: `IssetNode && (bool)$this...pt->ResponseCode <= 49)` Loading history...
12	45	(isset($this->data->receipt->Complete) && (bool) $this->data->receipt->Complete === true) \|\|
13	45	(isset($this->data->receipt->ResSuccess) && (bool) $this->data->receipt->ResSuccess === true)
14		) &&
15		(
16	39	isset($this->data->receipt->ResponseCode) && $this->data->receipt->ResponseCode != 'null' &&
17	45	(int) $this->data->receipt->ResponseCode >= 0 && (int) $this->data->receipt->ResponseCode <= 49
18		)
19		) {
20	21	return true;
21		}
22
23	24	return false;
24		}
25
26	3	public function getCardReference()
27		{
28	3	return isset($this->data->receipt->DataKey) ? (string) $this->data->receipt->DataKey : null;
29		}
30
31	6	public function getCode()
32		{
33	6	return isset($this->data->receipt->ResponseCode) ? (string) $this->data->receipt->ResponseCode : null;
34		}
35
36	3	public function getAuthCode()
37		{
38	3	return isset($this->data->receipt->AuthCode) ? (string) $this->data->receipt->AuthCode : null;
39		}
40
41	3	public function getTransactionId()
42		{
43	3	return isset($this->data->receipt->TransID) ? (string) $this->data->receipt->TransID : null;
44		}
45
46	6	public function getTransactionReference()
47		{
48	6	return isset($this->data->receipt->ReferenceNum) ? (string) $this->data->receipt->ReferenceNum : null;
49		}
50
51	6	public function getMessage()
52		{
53	6	return isset($this->data->receipt->Message) ? (string) $this->data->receipt->Message : null;
54		}
55
56	3	public function getOrderNumber()
57		{
58	3	return isset($this->data->receipt->ReceiptId) ? (string) $this->data->receipt->ReceiptId : null;
59		}
60
61	3	public function getData()
62		{
63	3	$response = null;
		0 ignored issues – show Unused Code introduced 2019-12-10 08:13 UTC by Report Bug Copy Issue Report The assignment to `$response` is dead and can be removed. Loading history...
64
65		try {
66	3	$response = preg_replace('/\n/', '', ($this->data)->asXML());
67	3	} catch (\Error $e) {
68	3	$response = $this->data;
69		}
70
71	3	return $response;
72		}
73		}
74

anilahir / omnipay-moneris

Response::isSuccessful() B last analyzed 2019-12-10 11:15 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Response::isSuccessful() B
last analyzed 2019-12-10 11:15 UTC