StoreFacultyRequest::response() - Code Metrics - angelov/storgman - Measure and Improve Code Quality continuously with Scrutinizer

StoreFacultyRequest::response() A
last analyzed 2017-02-01 19:30 UTC

↳ Parent: StoreFacultyRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
c	0
b	0
f	0
rs	9.4285
cc	1
eloc	7
nc	1
nop	1

<?php

/**
 * Storgman - Student Organizations Management
 * Copyright (C) 2014-2016, Dejan Angelov <[email protected]>
 *
 * This file is part of Storgman.
 *
 * Storgman is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * Storgman is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with Storgman.  If not, see <http://www.gnu.org/licenses/>.
 *
 * @package Storgman
 * @copyright Copyright (C) 2014-2016, Dejan Angelov <[email protected]>
 * @license https://github.com/angelov/storgman/blob/master/LICENSE
 * @author Dejan Angelov <[email protected]>
 */

namespace Angelov\Storgman\Settings\Http\Requests;

use Angelov\Storgman\Core\Http\Request;
use Illuminate\Http\JsonResponse;

class StoreFacultyRequest extends Request
{
    protected $rules = [
        'title'        => 'required',
        'abbreviation' => 'required',
        'university'   => 'required'
    ];

    public function response(array $errors)
    {
        $responseData = [
            'status' => "error",
            'message' => "Please fix the following errors:",
            'data' => [
                'errors' => $this->parseErrors($errors)
            ]
        ];

        return new JsonResponse($responseData);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}

1			<?php
2
3			/**
4			* Storgman - Student Organizations Management
5			* Copyright (C) 2014-2016, Dejan Angelov <[email protected]>
6			*
7			* This file is part of Storgman.
8			*
9			* Storgman is free software: you can redistribute it and/or modify
10			* it under the terms of the GNU General Public License as published by
11			* the Free Software Foundation, either version 3 of the License, or
12			* (at your option) any later version.
13			*
14			* Storgman is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU General Public License for more details.
18			*
19			* You should have received a copy of the GNU General Public License
20			* along with Storgman. If not, see <http://www.gnu.org/licenses/>.
21			*
22			* @package Storgman
23			* @copyright Copyright (C) 2014-2016, Dejan Angelov <[email protected]>
24			* @license https://github.com/angelov/storgman/blob/master/LICENSE
25			* @author Dejan Angelov <[email protected]>
26			*/
27
28			namespace Angelov\Storgman\Settings\Http\Requests;
29
30			use Angelov\Storgman\Core\Http\Request;
31			use Illuminate\Http\JsonResponse;
32
33			class StoreFacultyRequest extends Request
34			{
35			protected $rules = [
36			'title' => 'required',
37			'abbreviation' => 'required',
38			'university' => 'required'
39			];
40
41			public function response(array $errors)
42			{
43			$responseData = [
44			'status' => "error",
45			'message' => "Please fix the following errors:",
46			'data' => [
47			'errors' => $this->parseErrors($errors)
48			]
49			];
50
51			return new JsonResponse($responseData);
			0 ignored issues – show Bug Best Practice introduced 2017-02-01 19:30 UTC by Report Bug Copy Issue Report The return type of `return new \Illuminate\H...esponse($responseData);` (`Illuminate\Http\JsonResponse`) is incompatible with the return type of the parent method `Angelov\Storgman\Core\Http\Request::response` of type `Illuminate\Http\RedirectResponse`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
52			}
53			}

angelov / storgman

StoreFacultyRequest::response() A last analyzed 2017-02-01 19:30 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

StoreFacultyRequest::response() A
last analyzed 2017-02-01 19:30 UTC