Angelov\Storgman\Members\Http\Controllers\MembersController

Complexity

Total Complexity

17

Size/Duplication

Total Lines	250
Duplicated Lines	13.2 %

Coupling/Cohesion

Components	2
Dependencies	17

Importance

Changes

0

16 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	index()	0	10	1
A	prefetch()	0	16	2
A	board()	0	6	1
A	unapproved()	0	6	1
A	create()	0	6	1
A	store()	10	10	1
A	show()	0	12	1
A	quickMemberInfo()	0	6	1
A	edit()	0	7	1
A	update()	10	10	1
A	destroy()	0	6	1
A	approve()	0	6	1
A	decline()	0	6	1
A	register()	0	6	1
A	postRegister()	13	13	1

<?php

/**
 * Storgman - Student Organizations Management
 * Copyright (C) 2014-2016, Dejan Angelov <angelovdejan92@gmail.com>
 *
 * This file is part of Storgman.
 *
 * Storgman is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * Storgman is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with Storgman.  If not, see <http://www.gnu.org/licenses/>.
 *
 * @package Storgman
 * @copyright Copyright (C) 2014-2016, Dejan Angelov <angelovdejan92@gmail.com>
 * @license https://github.com/angelov/storgman/blob/master/LICENSE
 * @author Dejan Angelov <angelovdejan92@gmail.com>
 */

namespace Angelov\Storgman\Members\Http\Controllers;

use Angelov\Storgman\Core\Http\Controllers\BaseController;
use Angelov\Storgman\Faculties\Repositories\FacultiesRepositoryInterface;
use Angelov\Storgman\Members\Commands\ApproveMemberCommand;
use Angelov\Storgman\Members\Commands\CreateMemberCommand;
use Angelov\Storgman\Members\Commands\DeclineMemberCommand;
use Angelov\Storgman\Members\Commands\DeleteMemberCommand;
use Angelov\Storgman\Members\Commands\UpdateMemberCommand;
use Angelov\Storgman\Members\Http\Requests\StoreMemberRequest;
use Angelov\Storgman\Members\Http\Requests\UpdateMemberRequest;
use Angelov\Storgman\Members\MembersPaginator;
use Angelov\Storgman\Membership\Repositories\FeesRepositoryInterface;
use Angelov\Storgman\Meetings\MeetingsService;
use Angelov\Storgman\Members\Repositories\MembersRepositoryInterface;
use Illuminate\Contracts\Routing\UrlGenerator;
use Illuminate\Contracts\View\View;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;

class MembersController extends BaseController
{
    protected $members;
    protected $fees;

    public function __construct(MembersRepositoryInterface $members, FeesRepositoryInterface $fees)
    {
        $this->members = $members;
        $this->fees = $fees;
    }

    /**
     * Display a listing of members
     *
     * @param Request $request
     * @param MembersPaginator $paginator
     * @return View
     */
    public function index(Request $request, MembersPaginator $paginator)
    {
        $page = $request->get('page', 1);
        $members = $paginator->get($page);

        /** @todo This can get a little optimized */
        $pending = count($this->members->getUnapprovedMembers());

        return view('members.index', compact('members', 'pending'));
    }

    /**
     * Returns the list of members to be used for autocompletion
     *
     * @param UrlGenerator $url
     * @return JsonResponse
     */
    public function prefetch(UrlGenerator $url)
    {
        $members = $this->members->all();
        $result = [];

        foreach ($members as $member) {
            $tmp = [];
            $tmp['value'] = $member->getFullName();
            $tmp['image'] = $url->route('imagecache', ['xsmall', $member->getPhoto()]);
            $tmp['id'] = $member->getId();

            $result[] = $tmp;
        }

        return new JsonResponse($result);
    }

    /**
     * Show a page that lists the board members
     *
     * @return View
     */
    public function board()
    {
        $members = $this->members->getBoardMembers();

        return view('members.board', compact('members'));
    }

    /**
     * Show a page with the unapproved member accounts
     *
     * @return View
     */
    public function unapproved()
    {
        $members = $this->members->getUnapprovedMembers();

        return view('members.unapproved', compact('members'));
    }

    /**
     * Show the form for creating a new member
     *
     * @param FacultiesRepositoryInterface $faculties
     * @return View
     */
    public function create(FacultiesRepositoryInterface $faculties)
    {
        $faculties = $faculties->getEnabled();

        return view('members.create', compact('faculties'));
    }

    /**
     * Store a newly created member in storage.
     *
     * @param StoreMemberRequest $request
     * @return RedirectResponse
     */
    public function store(StoreMemberRequest $request)

This method seems to be duplicated in your project.

    {
        $data = $request->all();

        dispatch(new CreateMemberCommand($data, $approve = true));

        session()->flash('action-message', "Member added successfully.");

        return redirect()->route('members.index');
    }

    /**
     * Display the specified member.
     *
     * @param MeetingsService $meetingsService
     * @param int $id
     * @return View
     *
     * @todo Information separated in tabs (in the view) should be separated in few methods
     */
    public function show(MeetingsService $meetingsService, $id)
    {
        $member = $this->members->get($id);

        $attendance = $meetingsService->calculateAttendanceDetailsForMember($member);

        $latestMeetings = $meetingsService->latestMeetingsAttendanceStatusForMember($member);

        $monthly = json_encode($meetingsService->calculateMonthlyAttendanceDetailsForMember($member));

        return view('members.show', compact('member', 'attendance', 'latestMeetings', 'monthly'));
    }

    /**
     * Returns html component with short member info
     * (focused on the membership)
     *
     * @param int $id
     * @return View
     */
    public function quickMemberInfo($id)
    {
        $member = $this->members->get($id);

        return view('members.components.quick-info', compact('member'));
    }

    /**
     * Show the form for editing the specified member.
     *
     * @param  int $id
     * @param FacultiesRepositoryInterface $faculties
     * @return View
     */
    public function edit($id, FacultiesRepositoryInterface $faculties)
    {
        $member = $this->members->get($id);
        $faculties = $faculties->getEnabled();

        return view('members.edit', compact('member', 'faculties'));
    }

    /**
     * Update the specified member in storage.
     *
     * @param UpdateMemberRequest $request
     * @param  int $id
     * @return RedirectResponse
     */
    public function update(UpdateMemberRequest $request, $id)

This method seems to be duplicated in your project.

    {
        $data = $request->all();

        dispatch(new UpdateMemberCommand($id, $data));

        session()->flash('action-message', "Member updated successfully.");

        return redirect()->route('members.index');
    }

    /**
     * Remove the specified members from storage.
     * Method available only via AJAX requests
     *
     * @param  int $id
     * @return JsonResponse
     */
    public function destroy($id)
    {
        dispatch(new DeleteMemberCommand($id));

        return $this->successfulJsonResponse('Member deleted successfully.');
    }

    /**
     * Approve a pending member account
     * Method available only via AJAX requests
     *
     * @param int $id
     * @return JsonResponse
     */
    public function approve($id)
    {
        dispatch(new ApproveMemberCommand($id));

        return $this->successfulJsonResponse('Member approved successfully.');
    }

    /**
     * Decline a pending member account
     * Method available only via AJAX requests
     *
     * @param int $id
     * @return JsonResponse
     */
    public function decline($id)
    {
        dispatch(new DeclineMemberCommand($id));

        return $this->successfulJsonResponse('Member declined successfully.');
    }

    /**
     * The new members can create their profiles on the system
     *
     * @param FacultiesRepositoryInterface $faculties
     * @return View
     */
    public function register(FacultiesRepositoryInterface $faculties)
    {
        $faculties = $faculties->getEnabled();

        return view('members.register', compact('faculties'));
    }

    /**
     * Proceed the information submitted via the registration form
     *
     * @param StoreMemberRequest $request
     * @return RedirectResponse
     */
    public function postRegister(StoreMemberRequest $request)

This method seems to be duplicated in your project.

    {
        $data = $request->all();

        dispatch(new CreateMemberCommand($data));

        session()->flash(
            'action-message',
            "Your account was created successfully. You will be notified when the board members approve it."
        );

        return redirect()->route('members.register');
    }
}