FileSystemsRegistryServiceProvider   A
last analyzed

Complexity

Total Complexity 2

Size/Duplication

Total Lines 27
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 5

Importance

Changes 0
Metric Value
wmc 2
lcom 1
cbo 5
dl 0
loc 27
c 0
b 0
f 0
rs 10

1 Method

Rating   Name   Duplication   Size   Complexity  
B register() 0 24 2
1
<?php
2
3
/**
4
 * Storgman - Student Organizations Management
5
 * Copyright (C) 2014-2016, Dejan Angelov <[email protected]>
6
 *
7
 * This file is part of Storgman.
8
 *
9
 * Storgman is free software: you can redistribute it and/or modify
10
 * it under the terms of the GNU General Public License as published by
11
 * the Free Software Foundation, either version 3 of the License, or
12
 * (at your option) any later version.
13
 *
14
 * Storgman is distributed in the hope that it will be useful,
15
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
16
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
17
 * GNU General Public License for more details.
18
 *
19
 * You should have received a copy of the GNU General Public License
20
 * along with Storgman.  If not, see <http://www.gnu.org/licenses/>.
21
 *
22
 * @package Storgman
23
 * @copyright Copyright (C) 2014-2016, Dejan Angelov <[email protected]>
24
 * @license https://github.com/angelov/storgman/blob/master/LICENSE
25
 * @author Dejan Angelov <[email protected]>
26
 */
27
28
namespace Angelov\Storgman\Core\FileSystem;
29
30
use Illuminate\Contracts\Config\Repository as ConfigRepository;
31
use Illuminate\Contracts\Foundation\Application;
32
use Illuminate\Support\ServiceProvider;
33
34
class FileSystemsRegistryServiceProvider extends ServiceProvider
35
{
36
    public function register()
37
    {
38
        $this->app->singleton(FileSystemsRegistry::class, function(Application $app) {
39
40
            $registry = new FileSystemsRegistry();
41
42
            /** @var ConfigRepository $config */
43
            $config = $app->make(ConfigRepository::class);
44
            $map = $config->get('filesystems.map');
45
46
            foreach ($map as $subject => $details) {
47
                $filesystem = $details['filesystem'];
48
49
                /** @var FileSystemInterface $filesystem */
50
                $filesystem = $app->make($filesystem);
0 ignored issues
show
Documentation introduced by
$filesystem is of type object<Angelov\Storgman\...em\FileSystemInterface>, but the function expects a string.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
51
                $filesystem->setBasePath($details['base_path']);
52
53
                $registry->addFileSystem($subject, $filesystem);
54
            }
55
56
            return $registry;
57
58
        });
59
    }
60
}