angelov / donut

src/ApiBundle/Console/CreateClientCommand.php

<?php

/**
 * Donut Social Network - Yet another experimental social network.
 * Copyright (C) 2016-2018, Dejan Angelov <angelovdejan92@gmail.com>
 *
 * This file is part of Donut Social Network.
 *
 * Donut Social Network is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * Donut Social Network is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with Donut Social Network.  If not, see <http://www.gnu.org/licenses/>.
 *
 * @package Donut Social Network
 * @copyright Copyright (C) 2016-2018, Dejan Angelov <angelovdejan92@gmail.com>
 * @license https://github.com/angelov/donut/blob/master/LICENSE
 * @author Dejan Angelov <angelovdejan92@gmail.com>
 */

namespace ApiBundle\Console;

use FOS\OAuthServerBundle\Model\ClientManagerInterface;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

class CreateClientCommand extends Command
{
    private $clientManager;

    public function __construct(ClientManagerInterface $clientManager)
    {
        parent::__construct();

        $this->clientManager = $clientManager;
    }

    protected function configure() : void
    {
        $this
            ->setName('api:create-client')
            ->addOption(
                'redirect-uri',
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'Sets redirect uri for client.'
            )
            ->addOption(
                'grant-type',
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'Sets allowed grant type for client.'
            );
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $client = $this->clientManager->createClient();

        $client->setRedirectUris($input->getOption('redirect-uri'));

It seems like $input->getOption('redirect-uri') can also be of type boolean and null and string; however, parameter $redirectUris of FOS\OAuthServerBundle\Model\ClientInterface::setRedirectUris() does only seem to accept array, maybe add an additional type check?

        $client->setAllowedGrantTypes($input->getOption('grant-type'));

It seems like $input->getOption('grant-type') can also be of type boolean and null and string; however, parameter $grantTypes of FOS\OAuthServerBundle\Model\ClientInterface::setAllowedGrantTypes() does only seem to accept array, maybe add an additional type check?

        $this->clientManager->updateClient($client);

        $output->writeln(sprintf(
            'Added a new client with public id <info>%s</info> and secret <info>%s</info>.',
            $client->getPublicId(),
            $client->getSecret()
        ));
    }
}