angellco\spoon\controllers\ConfiguratorController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	82
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	actionGetHtml()	0	28	2
A	actionGetFieldsHtml()	0	19	1

<?php
/**
 * Spoon plugin for Craft CMS 3.x
 *
 * Enhance Matrix
 *
 * @link      https://angell.io
 * @copyright Copyright (c) 2018 Angell & Co
 */

namespace angellco\spoon\controllers;

use angellco\spoon\Spoon;

use Craft;
use craft\web\Controller;

/**
 * Configurator Controller
 *
 * @author    Angell & Co
 * @package   Spoon
 * @since     3.0.0
 */
class ConfiguratorController extends Controller
{

    // Protected Properties
    // =========================================================================

    /**
     * @var    bool|array Allows anonymous access to this controller's actions.
     *         The actions must be in 'kebab-case'
     * @access protected
     */
    protected $allowAnonymous = false;

    // Public Methods
    // =========================================================================

    /**
     * Returns the fld HTML for the main configurator
     *
     * @return \yii\web\Response
     * @throws \Twig_Error_Loader
     * @throws \yii\base\Exception
     * @throws \yii\web\BadRequestHttpException
     */
    public function actionGetHtml()
    {
        $this->requirePostRequest();
        $this->requireAcceptsJson();

        $fieldId = Craft::$app->getRequest()->getParam('fieldId');
        $field = Craft::$app->fields->getFieldById($fieldId);
        $blockTypes = Craft::$app->matrix->getBlockTypesByFieldId($fieldId);

        $blockTypeIds = [];
        foreach ($blockTypes as $blockType)
        {
            $blockTypeIds[] = $blockType->id;
        }

        $context = Craft::$app->getRequest()->getParam('context');

        $spoonedBlockTypes = Spoon::$plugin->blockTypes->getByContext($context, 'groupName', false, $fieldId);

It seems like $context can also be of type array; however, parameter $context of angellco\spoon\services\BlockTypes::getByContext() does only seem to accept string, maybe add an additional type check?

        $fld = Craft::$app->view->renderTemplate('spoon/flds/configurator', array(
            'matrixField' => $field,
            'blockTypes' => $blockTypes,
            'blockTypeIds' => $blockTypeIds,
            'spoonedBlockTypes' => $spoonedBlockTypes
        ));

        return $this->asJson([
            'html' => $fld
        ]);
    }

    /**
     * Returns the html for the individual block type fld.
     *
     * @return \yii\web\Response
     * @throws \Twig_Error_Loader
     * @throws \yii\base\Exception
     * @throws \yii\web\BadRequestHttpException
     */
    public function actionGetFieldsHtml()
    {
        $this->requirePostRequest();
        $this->requireAcceptsJson();

        $context = Craft::$app->getRequest()->getParam('context');
        $blockTypeId = Craft::$app->getRequest()->getParam('blockTypeId');

        $spoonedBlockType = Spoon::$plugin->blockTypes->getBlockType($context, $blockTypeId);

        $fieldLayout = $spoonedBlockType->getFieldLayout();

The method getFieldLayout() does not exist on angellco\spoon\models\BlockType. Since you implemented __call, consider adding a @method annotation.

        $fld = Craft::$app->view->renderTemplate('spoon/flds/fields', array(
            'spoonedBlockType' => $spoonedBlockType,
            'fieldLayout' => $fieldLayout
        ));

        return $this->asJson([
            'html' => $fld
        ]);
    }

}