angelcamposm / ipv4-address-converter

src/Converters/DecimalIPv4AddressConverter.php

<?php

namespace Acamposm\IPv4AddressConverter\Converters;

use Acamposm\IPv4AddressConverter\Enums\IPAddressFormatEnum as IPAddressFormat;
use Acamposm\IPv4AddressConverter\Traits\MutableIPv4AddressTrait as MutableIPv4Address;

class DecimalIPv4AddressConverter extends BaseAddressConverter
{
    use MutableIPv4Address;

    /**
     * Performs the conversion from the input format to Binary string.
     *
     * @return int|string
     */
    public function convert(): int | string
    {
        return match ($this->inputFormat) {
            IPAddressFormat::BINARY      => $this->fromBinaryToDecimal($this->address),
            IPAddressFormat::HEXADECIMAL => $this->fromHexadecimalToDecimal($this->address),
            IPAddressFormat::LONG        => $this->fromLongToDecimal($this->address),

It seems like $this->address can also be of type string; however, parameter $address of Acamposm\IPv4AddressConverter\Converters\DecimalIPv4AddressConverter::fromLongToDecimal() does only seem to accept integer, maybe add an additional type check?

            default                      => $this->address,
        };
    }
}