Acamposm\IPv4AddressConverter\Converters\HexadecimalIPv4AddressConverter::convert()

Complexity

Conditions	4
Paths	1

Size

Total Lines	13
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function convert(): int | string
    {
        return match ($this->inputFormat) {
            IPAddressFormat::BINARY => $this->withDotNotation
                ? $this->fromBinaryToDottedHex($this->address)
                : $this->fromBinaryToHex($this->address),
            IPAddressFormat::DECIMAL => $this->withDotNotation
                ? $this->fromDecimalToDottedHex($this->address)
                : $this->fromDecimalToHex($this->address),
            IPAddressFormat::LONG => $this->withDotNotation ?
                $this->fromLongToDottedHex($this->address) :

It seems like $this->address can also be of type string; however, parameter $address of Acamposm\IPv4AddressConverter\Converters\HexadecimalIPv4AddressConverter::fromLongToDottedHex() does only seem to accept integer, maybe add an additional type check?

                $this->fromLongToHex($this->address),

It seems like $this->address can also be of type string; however, parameter $address of Acamposm\IPv4AddressConverter\Converters\HexadecimalIPv4AddressConverter::fromLongToHex() does only seem to accept integer, maybe add an additional type check?

            default => '',
        };