BaseAddressConverter::fromBinary() - Code Metrics - angelcamposm/ipv4-address-converter - Measure and Improve Code Quality continuously with Scrutinizer

BaseAddressConverter::fromBinary() A
last analyzed 2021-06-27 21:43 UTC

↳ Parent: BaseAddressConverter

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	3
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	6
rs	10

<?php

namespace Acamposm\IPv4AddressConverter\Converters;

use Acamposm\IPv4AddressConverter\Enums\IPAddressFormatEnum as IPAddressFormat;
use Acamposm\IPv4AddressConverter\Interfaces\IPv4AddressConverterInterface;

abstract class BaseAddressConverter implements IPv4AddressConverterInterface
{
    protected int | string $address;
    protected int $inputFormat;

    /**
     * BaseAddressConverter constructor.
     *
     * @param false $withDotNotation
     */
    public function __construct(
        protected $withDotNotation = false,
    ) {
    }

    /**
     * Set the value of $address from Binary string.
     *
     * @param string $address
     *
     * @return BaseAddressConverter
     */
    public function fromBinary(string $address): BaseAddressConverter
    {
        $this->address = $address;
        $this->inputFormat = IPAddressFormat::BINARY;

        return $this;
    }

    /**
     * Set the value of $address from Decimal string.
     *
     * @param string $address
     *
     * @return BaseAddressConverter
     */
    public function fromDecimal(string $address): BaseAddressConverter
    {
        $this->address = $address;
        $this->inputFormat = IPAddressFormat::DECIMAL;

        return $this;
    }

    /**
     * Set the value of $address from Hexadecimal string.
     *
     * @param string $address
     *
     * @return BaseAddressConverter
     */
    public function fromHexadecimal(string $address): BaseAddressConverter
    {
        $this->address = $address;
        $this->inputFormat = IPAddressFormat::HEXADECIMAL;

        return $this;
    }

    /**
     * Set the value of $address from Long Integer.
     *
     * @param int $address
     *
     * @return BaseAddressConverter
     */
    public function fromLong(int $address): BaseAddressConverter
    {
        $this->address = $address;
        $this->inputFormat = IPAddressFormat::LONG;

        return $this;
    }

    /**
     * Set the output format as dot notation.
     *
     * @return BaseAddressConverter
     */
    public function withDotNotation(): BaseAddressConverter
    {
        $this->withDotNotation = true;
$answer = 42;

$correct = false;

$correct = (bool) $answer;

        return $this;
    }

    /**
     * @inheritDoc
     */
    public function convert(): int | string
    {
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
}


1			<?php
2
3			namespace Acamposm\IPv4AddressConverter\Converters;
4
5			use Acamposm\IPv4AddressConverter\Enums\IPAddressFormatEnum as IPAddressFormat;
6			use Acamposm\IPv4AddressConverter\Interfaces\IPv4AddressConverterInterface;
7
8			abstract class BaseAddressConverter implements IPv4AddressConverterInterface
9			{
10			protected int \| string $address;
11			protected int $inputFormat;
12
13			/**
14			* BaseAddressConverter constructor.
15			*
16			* @param false $withDotNotation
17			*/
18			public function __construct(
19			protected $withDotNotation = false,
20			) {
21			}
22
23			/**
24			* Set the value of $address from Binary string.
25			*
26			* @param string $address
27			*
28			* @return BaseAddressConverter
29			*/
30			public function fromBinary(string $address): BaseAddressConverter
31			{
32			$this->address = $address;
33			$this->inputFormat = IPAddressFormat::BINARY;
34
35			return $this;
36			}
37
38			/**
39			* Set the value of $address from Decimal string.
40			*
41			* @param string $address
42			*
43			* @return BaseAddressConverter
44			*/
45			public function fromDecimal(string $address): BaseAddressConverter
46			{
47			$this->address = $address;
48			$this->inputFormat = IPAddressFormat::DECIMAL;
49
50			return $this;
51			}
52
53			/**
54			* Set the value of $address from Hexadecimal string.
55			*
56			* @param string $address
57			*
58			* @return BaseAddressConverter
59			*/
60			public function fromHexadecimal(string $address): BaseAddressConverter
61			{
62			$this->address = $address;
63			$this->inputFormat = IPAddressFormat::HEXADECIMAL;
64
65			return $this;
66			}
67
68			/**
69			* Set the value of $address from Long Integer.
70			*
71			* @param int $address
72			*
73			* @return BaseAddressConverter
74			*/
75			public function fromLong(int $address): BaseAddressConverter
76			{
77			$this->address = $address;
78			$this->inputFormat = IPAddressFormat::LONG;
79
80			return $this;
81			}
82
83			/**
84			* Set the output format as dot notation.
85			*
86			* @return BaseAddressConverter
87			*/
88			public function withDotNotation(): BaseAddressConverter
89			{
90			$this->withDotNotation = true;
			0 ignored issues – show Documentation Bug introduced 2021-05-16 02:02 UTC by Report Bug Copy Issue Report The property `$withDotNotation` was declared of type `false`, but `true` is of type `true`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
91
92			return $this;
93			}
94
95			/**
96			* @inheritDoc
97			*/
98			public function convert(): int \| string
99			{
100			}
			0 ignored issues – show Bug Best Practice introduced 2021-05-16 02:02 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `integer\|string`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
101			}
102

angelcamposm / ipv4-address-converter

BaseAddressConverter::fromBinary() A last analyzed 2021-06-27 21:43 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

BaseAddressConverter::fromBinary() A
last analyzed 2021-06-27 21:43 UTC