anfischer / laravel-foundation

src/Job/Concerns/DispatchesJobs.php

<?php

namespace Anfischer\Foundation\Job\Concerns;

use Anfischer\Foundation\Job\Job;
use Illuminate\Http\Request;
use Illuminate\Support\Collection;

trait DispatchesJobs
{
    /**
     * Beautifier function to be called instead of the
     * laravel function dispatch.
     *
     * @param mixed                          $job
     * @param array|\Illuminate\Http\Request $arguments
     * @param array                          $extra
     *
     * @return mixed
     */
    public function run($job, $arguments = [], array $extra = [])
    {
        return $this->dispatch($this->prepare($job, $arguments, $extra));

It seems like dispatch() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Runs the job in the given queue.
     *
     * @param string $job
     * @param array|\Illuminate\Http\Request $arguments
     * @param array $extra
     * @param string $queue
     *
     * @return mixed
     */
    public function runInQueue($job, $arguments = [], array $extra = [], string $queue = 'default')
    {
        $job = $this->prepare($job, $arguments, $extra);
        $job->onQueue($queue);

The method onQueue() does not exist on Anfischer\Foundation\Job\Job. It seems like you code against a sub-type of Anfischer\Foundation\Job\Job such as Anfischer\Foundation\Job\QueueableJob.

        return $this->dispatch($job);
    }


    /**
     * Prepare a job by marshalling it if needed.
     *
     * @param $job
     * @param $arguments
     * @param array $extra
     * @return mixed
     */
    private function prepare($job, $arguments, array $extra) : Job
    {
        if ($arguments instanceof Request) {
            return $this->marshal($job, $arguments, $extra);

It seems like marshal() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        if (! \is_object($job)) {
            return $this->marshal($job, new Collection($arguments), $extra);
        }

        return $job;
    }
}