Inspection of "Redis connection refused" - anetwork/respond - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#5)

by Alireza

created 2017-01-21 13:10 UTC

Status

Spacing +66 added lines, -66 removed lines patch added patch discarded remove patch

@@ -13,11 +13,11 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function succeed( $data ) {
+	public function succeed($data) {
 
-		return $this->setStatusCode( 200 )
-					->setStatusText( 'success' )
-					->respondWithResult( $data );
+		return $this->setStatusCode(200)
+					->setStatusText('success')
+					->respondWithResult($data);
 
 	}
 
@@ -29,14 +29,14 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function deleteSucceeded( $message = null ) {
+	public function deleteSucceeded($message = null) {
 
-		if ( is_null( $message ) )
+		if (is_null($message))
 			$message = $this->config[ 'success' ][ 'delete' ];
 
-		return $this->setStatusCode( 200 )
-					->setStatusText( 'success' )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(200)
+					->setStatusText('success')
+					->respondWithMessage($message);
 
 	}
 
@@ -48,14 +48,14 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function updateSucceeded( $message = null ) {
+	public function updateSucceeded($message = null) {
 
-		if ( is_null( $message ) )
+		if (is_null($message))
 			$message = $this->config[ 'success' ][ 'update' ];
 
-		return $this->setStatusCode( 200 )
-					->setStatusText( 'success' )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(200)
+					->setStatusText('success')
+					->respondWithMessage($message);
 
 	}
 
@@ -67,14 +67,14 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function insertSucceeded( $message = null ) {
+	public function insertSucceeded($message = null) {
 
-		if ( is_null( $message ) )
+		if (is_null($message))
 			$message = $this->config[ 'success' ][ 'insert' ];
 
-		return $this->setStatusCode( 200 )
-					->setStatusText( 'success' )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(200)
+					->setStatusText('success')
+					->respondWithMessage($message);
 
 	}
 
@@ -86,15 +86,15 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function deleteFaild( $message = null ) {
+	public function deleteFaild($message = null) {
 
-		if ( is_null( $message ) )
+		if (is_null($message))
 			$message = $this->config[ 'fail' ][ 'delete' ];
 
-		return $this->setStatusCode( 447 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5447 )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(447)
+					->setStatusText('fail')
+					->setErrorCode(5447)
+					->respondWithMessage($message);
 
 	}
 
@@ -106,15 +106,15 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function updateFaild( $message = null ) {
+	public function updateFaild($message = null) {
 
-		if ( is_null( $message ) )
+		if (is_null($message))
 			$message = $this->config[ 'fail' ][ 'update' ];
 
-		return $this->setStatusCode( 449 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5449 )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(449)
+					->setStatusText('fail')
+					->setErrorCode(5449)
+					->respondWithMessage($message);
 
 	}
 
@@ -126,15 +126,15 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function insertFaild( $message = null ) {
+	public function insertFaild($message = null) {
 
-		if ( is_null( $message ) )
+		if (is_null($message))
 			$message = $this->config[ 'fail' ][ 'insert' ];
 
-		return $this->setStatusCode( 448 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5448 )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(448)
+					->setStatusText('fail')
+					->setErrorCode(5448)
+					->respondWithMessage($message);
 
 	}
 
@@ -148,9 +148,9 @@  discard block
 block discarded – undo
 	 */
 	public function connectionRefused() {
 
-		return $this->setStatusCode( 445 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5445 )
+		return $this->setStatusCode(445)
+					->setStatusText('fail')
+					->setErrorCode(5445)
 					->respondWithMessage();
 
 	}
@@ -163,9 +163,9 @@  discard block
 block discarded – undo
      */
     public function redisConnectionRefused()
     {
-        return $this->setStatusCode( 445 )
-            ->setStatusText( 'fail' )
-            ->setErrorCode( 5445 )
+        return $this->setStatusCode(445)
+            ->setStatusText('fail')
+            ->setErrorCode(5445)
             ->respondWithMessage();
 	}
 
@@ -179,9 +179,9 @@  discard block
 block discarded – undo
 	 */
 	public function notFound() {
 
-		return $this->setStatusCode( 404 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5404 )
+		return $this->setStatusCode(404)
+					->setStatusText('fail')
+					->setErrorCode(5404)
 					->respondWithMessage();
 
 	}
@@ -196,9 +196,9 @@  discard block
 block discarded – undo
 	 */
 	public function wrongParameters() {
 
-		return $this->setStatusCode( 406 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5406 )
+		return $this->setStatusCode(406)
+					->setStatusText('fail')
+					->setErrorCode(5406)
 					->respondWithMessage();
 
 	}
@@ -213,9 +213,9 @@  discard block
 block discarded – undo
 	 */
 	public function methodNotAllowed() {
 
-		return $this->setStatusCode( 405 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5405 )
+		return $this->setStatusCode(405)
+					->setStatusText('fail')
+					->setErrorCode(5405)
 					->respondWithMessage();
 
 	}
@@ -228,12 +228,12 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function validationErrors( $message = null ) {
+	public function validationErrors($message = null) {
 
-		return $this->setStatusCode( 420 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5420 )
-					->respondWithResult( $message );
+		return $this->setStatusCode(420)
+					->setStatusText('fail')
+					->setErrorCode(5420)
+					->respondWithResult($message);
 
 	}
 
@@ -247,9 +247,9 @@  discard block
 block discarded – undo
 	 */
 	public function requestFieldNotFound() {
 
-		return $this->setStatusCode( 446 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 1001 )
+		return $this->setStatusCode(446)
+					->setStatusText('fail')
+					->setErrorCode(1001)
 					->respondWithMessage();
 
 	}
@@ -262,8 +262,8 @@  discard block
 block discarded – undo
 	 */
 	public function requestFieldDuplicated() {
 
-	  return $this->setStatusCode( 400 )
-					->setStatusText( 'fail' )
+	  return $this->setStatusCode(400)
+					->setStatusText('fail')
 					->SetErrorCode(1004)
 					->respondWithMessage();
 
@@ -276,11 +276,11 @@  discard block
 block discarded – undo
 	 * @param $code integer
 	 * @return mixed
 	 */
-	public function error( $code ) {
+	public function error($code) {
 
-	  return $this->setStatusCode( 400 )
-					->setStatusText( 'fail' )
-					->setErrorCode( $code )
+	  return $this->setStatusCode(400)
+					->setStatusText('fail')
+					->setErrorCode($code)
 					->respondWithMessage();
 
 	}

Please login to merge, or discard this patch.

		@@ -13,11 +13,11 @@ discard block
		block discarded – undo
13	13	* @uses
14	14	* @see
15	15	*/
16		- public function succeed( $data ) {
	16	+ public function succeed($data) {
17	17
18		- return $this->setStatusCode( 200 )
19		- ->setStatusText( 'success' )
20		- ->respondWithResult( $data );
	18	+ return $this->setStatusCode(200)
	19	+ ->setStatusText('success')
	20	+ ->respondWithResult($data);
21	21
22	22	}
23	23
		@@ -29,14 +29,14 @@ discard block
		block discarded – undo
29	29	* @uses
30	30	* @see
31	31	*/
32		- public function deleteSucceeded( $message = null ) {
	32	+ public function deleteSucceeded($message = null) {
33	33
34		- if ( is_null( $message ) )
	34	+ if (is_null($message))
35	35	$message = $this->config[ 'success' ][ 'delete' ];
36	36
37		- return $this->setStatusCode( 200 )
38		- ->setStatusText( 'success' )
39		- ->respondWithMessage( $message );
	37	+ return $this->setStatusCode(200)
	38	+ ->setStatusText('success')
	39	+ ->respondWithMessage($message);
40	40
41	41	}
42	42
		@@ -48,14 +48,14 @@ discard block
		block discarded – undo
48	48	* @uses
49	49	* @see
50	50	*/
51		- public function updateSucceeded( $message = null ) {
	51	+ public function updateSucceeded($message = null) {
52	52
53		- if ( is_null( $message ) )
	53	+ if (is_null($message))
54	54	$message = $this->config[ 'success' ][ 'update' ];
55	55
56		- return $this->setStatusCode( 200 )
57		- ->setStatusText( 'success' )
58		- ->respondWithMessage( $message );
	56	+ return $this->setStatusCode(200)
	57	+ ->setStatusText('success')
	58	+ ->respondWithMessage($message);
59	59
60	60	}
61	61
		@@ -67,14 +67,14 @@ discard block
		block discarded – undo
67	67	* @uses
68	68	* @see
69	69	*/
70		- public function insertSucceeded( $message = null ) {
	70	+ public function insertSucceeded($message = null) {
71	71
72		- if ( is_null( $message ) )
	72	+ if (is_null($message))
73	73	$message = $this->config[ 'success' ][ 'insert' ];
74	74
75		- return $this->setStatusCode( 200 )
76		- ->setStatusText( 'success' )
77		- ->respondWithMessage( $message );
	75	+ return $this->setStatusCode(200)
	76	+ ->setStatusText('success')
	77	+ ->respondWithMessage($message);
78	78
79	79	}
80	80
		@@ -86,15 +86,15 @@ discard block
		block discarded – undo
86	86	* @uses
87	87	* @see
88	88	*/
89		- public function deleteFaild( $message = null ) {
	89	+ public function deleteFaild($message = null) {
90	90
91		- if ( is_null( $message ) )
	91	+ if (is_null($message))
92	92	$message = $this->config[ 'fail' ][ 'delete' ];
93	93
94		- return $this->setStatusCode( 447 )
95		- ->setStatusText( 'fail' )
96		- ->setErrorCode( 5447 )
97		- ->respondWithMessage( $message );
	94	+ return $this->setStatusCode(447)
	95	+ ->setStatusText('fail')
	96	+ ->setErrorCode(5447)
	97	+ ->respondWithMessage($message);
98	98
99	99	}
100	100
		@@ -106,15 +106,15 @@ discard block
		block discarded – undo
106	106	* @uses
107	107	* @see
108	108	*/
109		- public function updateFaild( $message = null ) {
	109	+ public function updateFaild($message = null) {
110	110
111		- if ( is_null( $message ) )
	111	+ if (is_null($message))
112	112	$message = $this->config[ 'fail' ][ 'update' ];
113	113
114		- return $this->setStatusCode( 449 )
115		- ->setStatusText( 'fail' )
116		- ->setErrorCode( 5449 )
117		- ->respondWithMessage( $message );
	114	+ return $this->setStatusCode(449)
	115	+ ->setStatusText('fail')
	116	+ ->setErrorCode(5449)
	117	+ ->respondWithMessage($message);
118	118
119	119	}
120	120
		@@ -126,15 +126,15 @@ discard block
		block discarded – undo
126	126	* @uses
127	127	* @see
128	128	*/
129		- public function insertFaild( $message = null ) {
	129	+ public function insertFaild($message = null) {
130	130
131		- if ( is_null( $message ) )
	131	+ if (is_null($message))
132	132	$message = $this->config[ 'fail' ][ 'insert' ];
133	133
134		- return $this->setStatusCode( 448 )
135		- ->setStatusText( 'fail' )
136		- ->setErrorCode( 5448 )
137		- ->respondWithMessage( $message );
	134	+ return $this->setStatusCode(448)
	135	+ ->setStatusText('fail')
	136	+ ->setErrorCode(5448)
	137	+ ->respondWithMessage($message);
138	138
139	139	}
140	140
		@@ -148,9 +148,9 @@ discard block
		block discarded – undo
148	148	*/
149	149	public function connectionRefused() {
150	150
151		- return $this->setStatusCode( 445 )
152		- ->setStatusText( 'fail' )
153		- ->setErrorCode( 5445 )
	151	+ return $this->setStatusCode(445)
	152	+ ->setStatusText('fail')
	153	+ ->setErrorCode(5445)
154	154	->respondWithMessage();
155	155
156	156	}
		@@ -163,9 +163,9 @@ discard block
		block discarded – undo
163	163	*/
164	164	public function redisConnectionRefused()
165	165	{
166		- return $this->setStatusCode( 445 )
167		- ->setStatusText( 'fail' )
168		- ->setErrorCode( 5445 )
	166	+ return $this->setStatusCode(445)
	167	+ ->setStatusText('fail')
	168	+ ->setErrorCode(5445)
169	169	->respondWithMessage();
170	170	}
171	171
		@@ -179,9 +179,9 @@ discard block
		block discarded – undo
179	179	*/
180	180	public function notFound() {
181	181
182		- return $this->setStatusCode( 404 )
183		- ->setStatusText( 'fail' )
184		- ->setErrorCode( 5404 )
	182	+ return $this->setStatusCode(404)
	183	+ ->setStatusText('fail')
	184	+ ->setErrorCode(5404)
185	185	->respondWithMessage();
186	186
187	187	}
		@@ -196,9 +196,9 @@ discard block
		block discarded – undo
196	196	*/
197	197	public function wrongParameters() {
198	198
199		- return $this->setStatusCode( 406 )
200		- ->setStatusText( 'fail' )
201		- ->setErrorCode( 5406 )
	199	+ return $this->setStatusCode(406)
	200	+ ->setStatusText('fail')
	201	+ ->setErrorCode(5406)
202	202	->respondWithMessage();
203	203
204	204	}
		@@ -213,9 +213,9 @@ discard block
		block discarded – undo
213	213	*/
214	214	public function methodNotAllowed() {
215	215
216		- return $this->setStatusCode( 405 )
217		- ->setStatusText( 'fail' )
218		- ->setErrorCode( 5405 )
	216	+ return $this->setStatusCode(405)
	217	+ ->setStatusText('fail')
	218	+ ->setErrorCode(5405)
219	219	->respondWithMessage();
220	220
221	221	}
		@@ -228,12 +228,12 @@ discard block
		block discarded – undo
228	228	* @uses
229	229	* @see
230	230	*/
231		- public function validationErrors( $message = null ) {
	231	+ public function validationErrors($message = null) {
232	232
233		- return $this->setStatusCode( 420 )
234		- ->setStatusText( 'fail' )
235		- ->setErrorCode( 5420 )
236		- ->respondWithResult( $message );
	233	+ return $this->setStatusCode(420)
	234	+ ->setStatusText('fail')
	235	+ ->setErrorCode(5420)
	236	+ ->respondWithResult($message);
237	237
238	238	}
239	239
		@@ -247,9 +247,9 @@ discard block
		block discarded – undo
247	247	*/
248	248	public function requestFieldNotFound() {
249	249
250		- return $this->setStatusCode( 446 )
251		- ->setStatusText( 'fail' )
252		- ->setErrorCode( 1001 )
	250	+ return $this->setStatusCode(446)
	251	+ ->setStatusText('fail')
	252	+ ->setErrorCode(1001)
253	253	->respondWithMessage();
254	254
255	255	}
		@@ -262,8 +262,8 @@ discard block
		block discarded – undo
262	262	*/
263	263	public function requestFieldDuplicated() {
264	264
265		- return $this->setStatusCode( 400 )
266		- ->setStatusText( 'fail' )
	265	+ return $this->setStatusCode(400)
	266	+ ->setStatusText('fail')
267	267	->SetErrorCode(1004)
268	268	->respondWithMessage();
269	269
		@@ -276,11 +276,11 @@ discard block
		block discarded – undo
276	276	* @param $code integer
277	277	* @return mixed
278	278	*/
279		- public function error( $code ) {
	279	+ public function error($code) {
280	280
281		- return $this->setStatusCode( 400 )
282		- ->setStatusText( 'fail' )
283		- ->setErrorCode( $code )
	281	+ return $this->setStatusCode(400)
	282	+ ->setStatusText('fail')
	283	+ ->setErrorCode($code)
284	284	->respondWithMessage();
285	285
286	286	}

anetwork / respond

Pull Request — master (#5)

Status

Category

Spacing +66 added lines, -66 removed lines patch added patch discarded remove patch