Inspection of "Added some changes on failed messages" - anetwork/respond - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bb5a47...9983dd )

unknown

created 2016-09-25 11:44 UTC

Status

Spacing +60 added lines, -60 removed lines patch added patch discarded remove patch

@@ -14,11 +14,11 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function succeed( $data ) {
+	public function succeed($data) {
 
-		return $this->setStatusCode( 200 )
-					->setStatusText( 'success' )
-					->respondWithResult( $data );
+		return $this->setStatusCode(200)
+					->setStatusText('success')
+					->respondWithResult($data);
 
 	}
 
@@ -30,14 +30,14 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function deleteSucceeded( $message ) {
+	public function deleteSucceeded($message) {
 
-		if ( empty( $message ) )
+		if (empty($message))
 			$message = $this->config[ 'success' ][ 'delete' ];
 
-		return $this->setStatusCode( 200 )
-					->setStatusText( 'success' )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(200)
+					->setStatusText('success')
+					->respondWithMessage($message);
 
 	}
 
@@ -49,14 +49,14 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function updateSucceeded( $message ) {
+	public function updateSucceeded($message) {
 
-		if ( empty( $message ) )
+		if (empty($message))
 			$message = $this->config[ 'success' ][ 'update' ];
 
-		return $this->setStatusCode( 200 )
-					->setStatusText( 'success' )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(200)
+					->setStatusText('success')
+					->respondWithMessage($message);
 
 	}
 
@@ -68,14 +68,14 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function insertSucceeded( $message ) {
+	public function insertSucceeded($message) {
 
-		if ( empty( $message ) )
+		if (empty($message))
 			$message = $this->config[ 'success' ][ 'insert' ];
 
-		return $this->setStatusCode( 200 )
-					->setStatusText( 'success' )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(200)
+					->setStatusText('success')
+					->respondWithMessage($message);
 
 	}
 
@@ -87,12 +87,12 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function deleteFaild( $message ) {
+	public function deleteFaild($message) {
 
-		return $this->setStatusCode( 447 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5447 )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(447)
+					->setStatusText('fail')
+					->setErrorCode(5447)
+					->respondWithMessage($message);
 
 	}
 
@@ -104,12 +104,12 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function updateFaild( $message ) {
+	public function updateFaild($message) {
 
-		return $this->setStatusCode( 449 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5449 )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(449)
+					->setStatusText('fail')
+					->setErrorCode(5449)
+					->respondWithMessage($message);
 
 	}
 
@@ -121,12 +121,12 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function insertFaild( $message ) {
+	public function insertFaild($message) {
 
-		return $this->setStatusCode( 448 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5448 )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(448)
+					->setStatusText('fail')
+					->setErrorCode(5448)
+					->respondWithMessage($message);
 
 	}
 
@@ -140,9 +140,9 @@  discard block
 block discarded – undo
 	 */
 	public function connectionRefused() {
 
-		return $this->setStatusCode( 445 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5445 )
+		return $this->setStatusCode(445)
+					->setStatusText('fail')
+					->setErrorCode(5445)
 					->respondWithMessage();
 
 	}
@@ -157,9 +157,9 @@  discard block
 block discarded – undo
 	 */
 	public function notFound() {
 
-		return $this->setStatusCode( 404 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5404 )
+		return $this->setStatusCode(404)
+					->setStatusText('fail')
+					->setErrorCode(5404)
 					->respondWithMessage();
 
 	}
@@ -174,9 +174,9 @@  discard block
 block discarded – undo
 	 */
 	public function wrongParameters() {
 
-		return $this->setStatusCode( 406 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5406 )
+		return $this->setStatusCode(406)
+					->setStatusText('fail')
+					->setErrorCode(5406)
 					->respondWithMessage();
 
 	}
@@ -191,9 +191,9 @@  discard block
 block discarded – undo
 	 */
 	public function methodNotAllowed() {
 
-		return $this->setStatusCode( 405 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5405 )
+		return $this->setStatusCode(405)
+					->setStatusText('fail')
+					->setErrorCode(5405)
 					->respondWithMessage();
 
 	}
@@ -206,12 +206,12 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function validationErrors( $data ) {
+	public function validationErrors($data) {
 
-		return $this->setStatusCode( 420 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5420 )
-					->respondWithResult( $data );
+		return $this->setStatusCode(420)
+					->setStatusText('fail')
+					->setErrorCode(5420)
+					->respondWithResult($data);
 
 	}
 
@@ -225,9 +225,9 @@  discard block
 block discarded – undo
 	 */
 	public function requestFieldNotFound() {
 
-		return $this->setStatusCode( 446 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 1001 )
+		return $this->setStatusCode(446)
+					->setStatusText('fail')
+					->setErrorCode(1001)
 					->respondWithMessage();
 
 	}
@@ -240,8 +240,8 @@  discard block
 block discarded – undo
 	 */
 	public function requestFieldDuplicated() {
 
-	  return $this->setStatusCode( 400 )
-					->setStatusText( 'fail' )
+	  return $this->setStatusCode(400)
+					->setStatusText('fail')
 					->SetErrorCode(1004)
 					->respondWithMessage();
 
@@ -254,11 +254,11 @@  discard block
 block discarded – undo
 	 * @param $code integer
 	 * @return json
 	 */
-	public function error( $code ) {
+	public function error($code) {
 
-	  return $this->SetStatusCode( 400 )
-					->setStatusText( 'fail' )
-					->setErrorCode( $code )
+	  return $this->SetStatusCode(400)
+					->setStatusText('fail')
+					->setErrorCode($code)
 					->respondWithMessage();
 
 	}

Please login to merge, or discard this patch.

		@@ -14,11 +14,11 @@ discard block
		block discarded – undo
14	14	* @uses
15	15	* @see
16	16	*/
17		- public function succeed( $data ) {
	17	+ public function succeed($data) {
18	18
19		- return $this->setStatusCode( 200 )
20		- ->setStatusText( 'success' )
21		- ->respondWithResult( $data );
	19	+ return $this->setStatusCode(200)
	20	+ ->setStatusText('success')
	21	+ ->respondWithResult($data);
22	22
23	23	}
24	24
		@@ -30,14 +30,14 @@ discard block
		block discarded – undo
30	30	* @uses
31	31	* @see
32	32	*/
33		- public function deleteSucceeded( $message ) {
	33	+ public function deleteSucceeded($message) {
34	34
35		- if ( empty( $message ) )
	35	+ if (empty($message))
36	36	$message = $this->config[ 'success' ][ 'delete' ];
37	37
38		- return $this->setStatusCode( 200 )
39		- ->setStatusText( 'success' )
40		- ->respondWithMessage( $message );
	38	+ return $this->setStatusCode(200)
	39	+ ->setStatusText('success')
	40	+ ->respondWithMessage($message);
41	41
42	42	}
43	43
		@@ -49,14 +49,14 @@ discard block
		block discarded – undo
49	49	* @uses
50	50	* @see
51	51	*/
52		- public function updateSucceeded( $message ) {
	52	+ public function updateSucceeded($message) {
53	53
54		- if ( empty( $message ) )
	54	+ if (empty($message))
55	55	$message = $this->config[ 'success' ][ 'update' ];
56	56
57		- return $this->setStatusCode( 200 )
58		- ->setStatusText( 'success' )
59		- ->respondWithMessage( $message );
	57	+ return $this->setStatusCode(200)
	58	+ ->setStatusText('success')
	59	+ ->respondWithMessage($message);
60	60
61	61	}
62	62
		@@ -68,14 +68,14 @@ discard block
		block discarded – undo
68	68	* @uses
69	69	* @see
70	70	*/
71		- public function insertSucceeded( $message ) {
	71	+ public function insertSucceeded($message) {
72	72
73		- if ( empty( $message ) )
	73	+ if (empty($message))
74	74	$message = $this->config[ 'success' ][ 'insert' ];
75	75
76		- return $this->setStatusCode( 200 )
77		- ->setStatusText( 'success' )
78		- ->respondWithMessage( $message );
	76	+ return $this->setStatusCode(200)
	77	+ ->setStatusText('success')
	78	+ ->respondWithMessage($message);
79	79
80	80	}
81	81
		@@ -87,12 +87,12 @@ discard block
		block discarded – undo
87	87	* @uses
88	88	* @see
89	89	*/
90		- public function deleteFaild( $message ) {
	90	+ public function deleteFaild($message) {
91	91
92		- return $this->setStatusCode( 447 )
93		- ->setStatusText( 'fail' )
94		- ->setErrorCode( 5447 )
95		- ->respondWithMessage( $message );
	92	+ return $this->setStatusCode(447)
	93	+ ->setStatusText('fail')
	94	+ ->setErrorCode(5447)
	95	+ ->respondWithMessage($message);
96	96
97	97	}
98	98
		@@ -104,12 +104,12 @@ discard block
		block discarded – undo
104	104	* @uses
105	105	* @see
106	106	*/
107		- public function updateFaild( $message ) {
	107	+ public function updateFaild($message) {
108	108
109		- return $this->setStatusCode( 449 )
110		- ->setStatusText( 'fail' )
111		- ->setErrorCode( 5449 )
112		- ->respondWithMessage( $message );
	109	+ return $this->setStatusCode(449)
	110	+ ->setStatusText('fail')
	111	+ ->setErrorCode(5449)
	112	+ ->respondWithMessage($message);
113	113
114	114	}
115	115
		@@ -121,12 +121,12 @@ discard block
		block discarded – undo
121	121	* @uses
122	122	* @see
123	123	*/
124		- public function insertFaild( $message ) {
	124	+ public function insertFaild($message) {
125	125
126		- return $this->setStatusCode( 448 )
127		- ->setStatusText( 'fail' )
128		- ->setErrorCode( 5448 )
129		- ->respondWithMessage( $message );
	126	+ return $this->setStatusCode(448)
	127	+ ->setStatusText('fail')
	128	+ ->setErrorCode(5448)
	129	+ ->respondWithMessage($message);
130	130
131	131	}
132	132
		@@ -140,9 +140,9 @@ discard block
		block discarded – undo
140	140	*/
141	141	public function connectionRefused() {
142	142
143		- return $this->setStatusCode( 445 )
144		- ->setStatusText( 'fail' )
145		- ->setErrorCode( 5445 )
	143	+ return $this->setStatusCode(445)
	144	+ ->setStatusText('fail')
	145	+ ->setErrorCode(5445)
146	146	->respondWithMessage();
147	147
148	148	}
		@@ -157,9 +157,9 @@ discard block
		block discarded – undo
157	157	*/
158	158	public function notFound() {
159	159
160		- return $this->setStatusCode( 404 )
161		- ->setStatusText( 'fail' )
162		- ->setErrorCode( 5404 )
	160	+ return $this->setStatusCode(404)
	161	+ ->setStatusText('fail')
	162	+ ->setErrorCode(5404)
163	163	->respondWithMessage();
164	164
165	165	}
		@@ -174,9 +174,9 @@ discard block
		block discarded – undo
174	174	*/
175	175	public function wrongParameters() {
176	176
177		- return $this->setStatusCode( 406 )
178		- ->setStatusText( 'fail' )
179		- ->setErrorCode( 5406 )
	177	+ return $this->setStatusCode(406)
	178	+ ->setStatusText('fail')
	179	+ ->setErrorCode(5406)
180	180	->respondWithMessage();
181	181
182	182	}
		@@ -191,9 +191,9 @@ discard block
		block discarded – undo
191	191	*/
192	192	public function methodNotAllowed() {
193	193
194		- return $this->setStatusCode( 405 )
195		- ->setStatusText( 'fail' )
196		- ->setErrorCode( 5405 )
	194	+ return $this->setStatusCode(405)
	195	+ ->setStatusText('fail')
	196	+ ->setErrorCode(5405)
197	197	->respondWithMessage();
198	198
199	199	}
		@@ -206,12 +206,12 @@ discard block
		block discarded – undo
206	206	* @uses
207	207	* @see
208	208	*/
209		- public function validationErrors( $data ) {
	209	+ public function validationErrors($data) {
210	210
211		- return $this->setStatusCode( 420 )
212		- ->setStatusText( 'fail' )
213		- ->setErrorCode( 5420 )
214		- ->respondWithResult( $data );
	211	+ return $this->setStatusCode(420)
	212	+ ->setStatusText('fail')
	213	+ ->setErrorCode(5420)
	214	+ ->respondWithResult($data);
215	215
216	216	}
217	217
		@@ -225,9 +225,9 @@ discard block
		block discarded – undo
225	225	*/
226	226	public function requestFieldNotFound() {
227	227
228		- return $this->setStatusCode( 446 )
229		- ->setStatusText( 'fail' )
230		- ->setErrorCode( 1001 )
	228	+ return $this->setStatusCode(446)
	229	+ ->setStatusText('fail')
	230	+ ->setErrorCode(1001)
231	231	->respondWithMessage();
232	232
233	233	}
		@@ -240,8 +240,8 @@ discard block
		block discarded – undo
240	240	*/
241	241	public function requestFieldDuplicated() {
242	242
243		- return $this->setStatusCode( 400 )
244		- ->setStatusText( 'fail' )
	243	+ return $this->setStatusCode(400)
	244	+ ->setStatusText('fail')
245	245	->SetErrorCode(1004)
246	246	->respondWithMessage();
247	247
		@@ -254,11 +254,11 @@ discard block
		block discarded – undo
254	254	* @param $code integer
255	255	* @return json
256	256	*/
257		- public function error( $code ) {
	257	+ public function error($code) {
258	258
259		- return $this->SetStatusCode( 400 )
260		- ->setStatusText( 'fail' )
261		- ->setErrorCode( $code )
	259	+ return $this->SetStatusCode(400)
	260	+ ->setStatusText('fail')
	261	+ ->setErrorCode($code)
262	262	->respondWithMessage();
263	263
264	264	}

anetwork / respond

Push — master ( bb5a47...9983dd )

Status

Category

Spacing +60 added lines, -60 removed lines patch added patch discarded remove patch