Inspection of "Fixed #3 issue" - anetwork/respond - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fdaee3...701f5d )

by mehdi

created 2016-12-16 11:56 UTC

Status

Spacing +63 added lines, -63 removed lines patch added patch discarded remove patch

@@ -13,11 +13,11 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function succeed( $data ) {
+	public function succeed($data) {
 
-		return $this->setStatusCode( 200 )
-					->setStatusText( 'success' )
-					->respondWithResult( $data );
+		return $this->setStatusCode(200)
+					->setStatusText('success')
+					->respondWithResult($data);
 
 	}
 
@@ -29,14 +29,14 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function deleteSucceeded( $message = null ) {
+	public function deleteSucceeded($message = null) {
 
-		if ( is_null( $message ) )
+		if (is_null($message))
 			$message = $this->config[ 'success' ][ 'delete' ];
 
-		return $this->setStatusCode( 200 )
-					->setStatusText( 'success' )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(200)
+					->setStatusText('success')
+					->respondWithMessage($message);
 
 	}
 
@@ -48,14 +48,14 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function updateSucceeded( $message = null ) {
+	public function updateSucceeded($message = null) {
 
-		if ( is_null( $message ) )
+		if (is_null($message))
 			$message = $this->config[ 'success' ][ 'update' ];
 
-		return $this->setStatusCode( 200 )
-					->setStatusText( 'success' )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(200)
+					->setStatusText('success')
+					->respondWithMessage($message);
 
 	}
 
@@ -67,14 +67,14 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function insertSucceeded( $message = null ) {
+	public function insertSucceeded($message = null) {
 
-		if ( is_null( $message ) )
+		if (is_null($message))
 			$message = $this->config[ 'success' ][ 'insert' ];
 
-		return $this->setStatusCode( 200 )
-					->setStatusText( 'success' )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(200)
+					->setStatusText('success')
+					->respondWithMessage($message);
 
 	}
 
@@ -86,15 +86,15 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function deleteFaild( $message = null ) {
+	public function deleteFaild($message = null) {
 
-		if ( is_null( $message ) )
+		if (is_null($message))
 			$message = $this->config[ 'fail' ][ 'delete' ];
 
-		return $this->setStatusCode( 447 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5447 )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(447)
+					->setStatusText('fail')
+					->setErrorCode(5447)
+					->respondWithMessage($message);
 
 	}
 
@@ -106,15 +106,15 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function updateFaild( $message = null ) {
+	public function updateFaild($message = null) {
 
-		if ( is_null( $message ) )
+		if (is_null($message))
 			$message = $this->config[ 'fail' ][ 'update' ];
 
-		return $this->setStatusCode( 449 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5449 )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(449)
+					->setStatusText('fail')
+					->setErrorCode(5449)
+					->respondWithMessage($message);
 
 	}
 
@@ -126,15 +126,15 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function insertFaild( $message = null ) {
+	public function insertFaild($message = null) {
 
-		if ( is_null( $message ) )
+		if (is_null($message))
 			$message = $this->config[ 'fail' ][ 'insert' ];
 
-		return $this->setStatusCode( 448 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5448 )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(448)
+					->setStatusText('fail')
+					->setErrorCode(5448)
+					->respondWithMessage($message);
 
 	}
 
@@ -148,9 +148,9 @@  discard block
 block discarded – undo
 	 */
 	public function connectionRefused() {
 
-		return $this->setStatusCode( 445 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5445 )
+		return $this->setStatusCode(445)
+					->setStatusText('fail')
+					->setErrorCode(5445)
 					->respondWithMessage();
 
 	}
@@ -165,9 +165,9 @@  discard block
 block discarded – undo
 	 */
 	public function notFound() {
 
-		return $this->setStatusCode( 404 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5404 )
+		return $this->setStatusCode(404)
+					->setStatusText('fail')
+					->setErrorCode(5404)
 					->respondWithMessage();
 
 	}
@@ -182,9 +182,9 @@  discard block
 block discarded – undo
 	 */
 	public function wrongParameters() {
 
-		return $this->setStatusCode( 406 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5406 )
+		return $this->setStatusCode(406)
+					->setStatusText('fail')
+					->setErrorCode(5406)
 					->respondWithMessage();
 
 	}
@@ -199,9 +199,9 @@  discard block
 block discarded – undo
 	 */
 	public function methodNotAllowed() {
 
-		return $this->setStatusCode( 405 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5405 )
+		return $this->setStatusCode(405)
+					->setStatusText('fail')
+					->setErrorCode(5405)
 					->respondWithMessage();
 
 	}
@@ -214,12 +214,12 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function validationErrors( $message = null ) {
+	public function validationErrors($message = null) {
 
-		return $this->setStatusCode( 420 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5420 )
-					->respondWithResult( $message );
+		return $this->setStatusCode(420)
+					->setStatusText('fail')
+					->setErrorCode(5420)
+					->respondWithResult($message);
 
 	}
 
@@ -233,9 +233,9 @@  discard block
 block discarded – undo
 	 */
 	public function requestFieldNotFound() {
 
-		return $this->setStatusCode( 446 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 1001 )
+		return $this->setStatusCode(446)
+					->setStatusText('fail')
+					->setErrorCode(1001)
 					->respondWithMessage();
 
 	}
@@ -248,8 +248,8 @@  discard block
 block discarded – undo
 	 */
 	public function requestFieldDuplicated() {
 
-	  return $this->setStatusCode( 400 )
-					->setStatusText( 'fail' )
+	  return $this->setStatusCode(400)
+					->setStatusText('fail')
 					->SetErrorCode(1004)
 					->respondWithMessage();
 
@@ -262,11 +262,11 @@  discard block
 block discarded – undo
 	 * @param $code integer
 	 * @return mixed
 	 */
-	public function error( $code ) {
+	public function error($code) {
 
-	  return $this->setStatusCode( 400 )
-					->setStatusText( 'fail' )
-					->setErrorCode( $code )
+	  return $this->setStatusCode(400)
+					->setStatusText('fail')
+					->setErrorCode($code)
 					->respondWithMessage();
 
 	}

Please login to merge, or discard this patch.

		@@ -13,11 +13,11 @@ discard block
		block discarded – undo
13	13	* @uses
14	14	* @see
15	15	*/
16		- public function succeed( $data ) {
	16	+ public function succeed($data) {
17	17
18		- return $this->setStatusCode( 200 )
19		- ->setStatusText( 'success' )
20		- ->respondWithResult( $data );
	18	+ return $this->setStatusCode(200)
	19	+ ->setStatusText('success')
	20	+ ->respondWithResult($data);
21	21
22	22	}
23	23
		@@ -29,14 +29,14 @@ discard block
		block discarded – undo
29	29	* @uses
30	30	* @see
31	31	*/
32		- public function deleteSucceeded( $message = null ) {
	32	+ public function deleteSucceeded($message = null) {
33	33
34		- if ( is_null( $message ) )
	34	+ if (is_null($message))
35	35	$message = $this->config[ 'success' ][ 'delete' ];
36	36
37		- return $this->setStatusCode( 200 )
38		- ->setStatusText( 'success' )
39		- ->respondWithMessage( $message );
	37	+ return $this->setStatusCode(200)
	38	+ ->setStatusText('success')
	39	+ ->respondWithMessage($message);
40	40
41	41	}
42	42
		@@ -48,14 +48,14 @@ discard block
		block discarded – undo
48	48	* @uses
49	49	* @see
50	50	*/
51		- public function updateSucceeded( $message = null ) {
	51	+ public function updateSucceeded($message = null) {
52	52
53		- if ( is_null( $message ) )
	53	+ if (is_null($message))
54	54	$message = $this->config[ 'success' ][ 'update' ];
55	55
56		- return $this->setStatusCode( 200 )
57		- ->setStatusText( 'success' )
58		- ->respondWithMessage( $message );
	56	+ return $this->setStatusCode(200)
	57	+ ->setStatusText('success')
	58	+ ->respondWithMessage($message);
59	59
60	60	}
61	61
		@@ -67,14 +67,14 @@ discard block
		block discarded – undo
67	67	* @uses
68	68	* @see
69	69	*/
70		- public function insertSucceeded( $message = null ) {
	70	+ public function insertSucceeded($message = null) {
71	71
72		- if ( is_null( $message ) )
	72	+ if (is_null($message))
73	73	$message = $this->config[ 'success' ][ 'insert' ];
74	74
75		- return $this->setStatusCode( 200 )
76		- ->setStatusText( 'success' )
77		- ->respondWithMessage( $message );
	75	+ return $this->setStatusCode(200)
	76	+ ->setStatusText('success')
	77	+ ->respondWithMessage($message);
78	78
79	79	}
80	80
		@@ -86,15 +86,15 @@ discard block
		block discarded – undo
86	86	* @uses
87	87	* @see
88	88	*/
89		- public function deleteFaild( $message = null ) {
	89	+ public function deleteFaild($message = null) {
90	90
91		- if ( is_null( $message ) )
	91	+ if (is_null($message))
92	92	$message = $this->config[ 'fail' ][ 'delete' ];
93	93
94		- return $this->setStatusCode( 447 )
95		- ->setStatusText( 'fail' )
96		- ->setErrorCode( 5447 )
97		- ->respondWithMessage( $message );
	94	+ return $this->setStatusCode(447)
	95	+ ->setStatusText('fail')
	96	+ ->setErrorCode(5447)
	97	+ ->respondWithMessage($message);
98	98
99	99	}
100	100
		@@ -106,15 +106,15 @@ discard block
		block discarded – undo
106	106	* @uses
107	107	* @see
108	108	*/
109		- public function updateFaild( $message = null ) {
	109	+ public function updateFaild($message = null) {
110	110
111		- if ( is_null( $message ) )
	111	+ if (is_null($message))
112	112	$message = $this->config[ 'fail' ][ 'update' ];
113	113
114		- return $this->setStatusCode( 449 )
115		- ->setStatusText( 'fail' )
116		- ->setErrorCode( 5449 )
117		- ->respondWithMessage( $message );
	114	+ return $this->setStatusCode(449)
	115	+ ->setStatusText('fail')
	116	+ ->setErrorCode(5449)
	117	+ ->respondWithMessage($message);
118	118
119	119	}
120	120
		@@ -126,15 +126,15 @@ discard block
		block discarded – undo
126	126	* @uses
127	127	* @see
128	128	*/
129		- public function insertFaild( $message = null ) {
	129	+ public function insertFaild($message = null) {
130	130
131		- if ( is_null( $message ) )
	131	+ if (is_null($message))
132	132	$message = $this->config[ 'fail' ][ 'insert' ];
133	133
134		- return $this->setStatusCode( 448 )
135		- ->setStatusText( 'fail' )
136		- ->setErrorCode( 5448 )
137		- ->respondWithMessage( $message );
	134	+ return $this->setStatusCode(448)
	135	+ ->setStatusText('fail')
	136	+ ->setErrorCode(5448)
	137	+ ->respondWithMessage($message);
138	138
139	139	}
140	140
		@@ -148,9 +148,9 @@ discard block
		block discarded – undo
148	148	*/
149	149	public function connectionRefused() {
150	150
151		- return $this->setStatusCode( 445 )
152		- ->setStatusText( 'fail' )
153		- ->setErrorCode( 5445 )
	151	+ return $this->setStatusCode(445)
	152	+ ->setStatusText('fail')
	153	+ ->setErrorCode(5445)
154	154	->respondWithMessage();
155	155
156	156	}
		@@ -165,9 +165,9 @@ discard block
		block discarded – undo
165	165	*/
166	166	public function notFound() {
167	167
168		- return $this->setStatusCode( 404 )
169		- ->setStatusText( 'fail' )
170		- ->setErrorCode( 5404 )
	168	+ return $this->setStatusCode(404)
	169	+ ->setStatusText('fail')
	170	+ ->setErrorCode(5404)
171	171	->respondWithMessage();
172	172
173	173	}
		@@ -182,9 +182,9 @@ discard block
		block discarded – undo
182	182	*/
183	183	public function wrongParameters() {
184	184
185		- return $this->setStatusCode( 406 )
186		- ->setStatusText( 'fail' )
187		- ->setErrorCode( 5406 )
	185	+ return $this->setStatusCode(406)
	186	+ ->setStatusText('fail')
	187	+ ->setErrorCode(5406)
188	188	->respondWithMessage();
189	189
190	190	}
		@@ -199,9 +199,9 @@ discard block
		block discarded – undo
199	199	*/
200	200	public function methodNotAllowed() {
201	201
202		- return $this->setStatusCode( 405 )
203		- ->setStatusText( 'fail' )
204		- ->setErrorCode( 5405 )
	202	+ return $this->setStatusCode(405)
	203	+ ->setStatusText('fail')
	204	+ ->setErrorCode(5405)
205	205	->respondWithMessage();
206	206
207	207	}
		@@ -214,12 +214,12 @@ discard block
		block discarded – undo
214	214	* @uses
215	215	* @see
216	216	*/
217		- public function validationErrors( $message = null ) {
	217	+ public function validationErrors($message = null) {
218	218
219		- return $this->setStatusCode( 420 )
220		- ->setStatusText( 'fail' )
221		- ->setErrorCode( 5420 )
222		- ->respondWithResult( $message );
	219	+ return $this->setStatusCode(420)
	220	+ ->setStatusText('fail')
	221	+ ->setErrorCode(5420)
	222	+ ->respondWithResult($message);
223	223
224	224	}
225	225
		@@ -233,9 +233,9 @@ discard block
		block discarded – undo
233	233	*/
234	234	public function requestFieldNotFound() {
235	235
236		- return $this->setStatusCode( 446 )
237		- ->setStatusText( 'fail' )
238		- ->setErrorCode( 1001 )
	236	+ return $this->setStatusCode(446)
	237	+ ->setStatusText('fail')
	238	+ ->setErrorCode(1001)
239	239	->respondWithMessage();
240	240
241	241	}
		@@ -248,8 +248,8 @@ discard block
		block discarded – undo
248	248	*/
249	249	public function requestFieldDuplicated() {
250	250
251		- return $this->setStatusCode( 400 )
252		- ->setStatusText( 'fail' )
	251	+ return $this->setStatusCode(400)
	252	+ ->setStatusText('fail')
253	253	->SetErrorCode(1004)
254	254	->respondWithMessage();
255	255
		@@ -262,11 +262,11 @@ discard block
		block discarded – undo
262	262	* @param $code integer
263	263	* @return mixed
264	264	*/
265		- public function error( $code ) {
	265	+ public function error($code) {
266	266
267		- return $this->setStatusCode( 400 )
268		- ->setStatusText( 'fail' )
269		- ->setErrorCode( $code )
	267	+ return $this->setStatusCode(400)
	268	+ ->setStatusText('fail')
	269	+ ->setErrorCode($code)
270	270	->respondWithMessage();
271	271
272	272	}

anetwork / respond

Push — master ( fdaee3...701f5d )

Status

Category

Spacing +63 added lines, -63 removed lines patch added patch discarded remove patch